From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SSsMKTYnB2oLQT0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 10:01:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tDQHLBD5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IsMRaGQx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tDQHLBD5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IsMRaGQx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 80E6E1E0B1; Fri, 15 May 2026 10:01:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BEC181E093 for ; Fri, 15 May 2026 10:01:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E608A4C900C2 for ; Fri, 15 May 2026 14:01:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E608A4C900C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tDQHLBD5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IsMRaGQx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tDQHLBD5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IsMRaGQx Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 3CC454BA23C2 for ; Fri, 15 May 2026 13:58:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3CC454BA23C2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3CC454BA23C2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778853538; cv=none; b=N5hE2uq6boVpndFskxNHAfyZjOZTW5VD3GNLZjJvQGhyH5MHrc/ouFlLrWrO0R7JLUZxWdQD0Sz1ClmRxoJDbbp7CU365m1/A2lljfu6BvHdUWqFvoTx90sHo45s9D/u3lkgMvaoc0RvIley0w7mIonQq0THvqQkPUzcwfcCE8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778853538; c=relaxed/simple; bh=H2R0gF+F9KFURII4wa73nmIhMaIDHtV0hbA0KsI96bs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=V7yhpj4Pn48GSjz+8ZWcMro0F6hdtVtDqYTvG+i3bwnFjOgSw/3H2aA09lCZXbsDTME7VtNTMxZZKf6SP4vEglMIP4JmNP8iM76xorzUF9XXbIwdsxjFGcvLyUcESOzSLITYhra6YV/oiyojxjaPOQqzZtiKDYU46epWPWGGDxU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tDQHLBD5; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IsMRaGQx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=tDQHLBD5; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IsMRaGQx DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CC454BA23C2 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5E7196317D for ; Fri, 15 May 2026 13:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Dy1toBPhPmAKSwz2c6XE36JaOkbrRuam9G2fSgNE9w=; b=tDQHLBD5jXspcaOITzrFPBdUmAYpnZxPcQlutd+BTzSsVNHCZuBFt+3xbB8cM21e9mV5qu X7RtcTE63an+YY1KssFHExCBhYH+RGi7MFkhZ5EPcNd0z07VxCbnMy6u2t9h7c0yyBF1O3 Uuk/4IAIyZWSj+dTCRtqZmzkVVuh2Lw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Dy1toBPhPmAKSwz2c6XE36JaOkbrRuam9G2fSgNE9w=; b=IsMRaGQxqzg0EcL4OQH7x+C5AhFhNhAFExauB/d+9nef6Nurs4UQ2YtQz0xbTiWD11bJr6 e+9HHckIA4cDGuCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Dy1toBPhPmAKSwz2c6XE36JaOkbrRuam9G2fSgNE9w=; b=tDQHLBD5jXspcaOITzrFPBdUmAYpnZxPcQlutd+BTzSsVNHCZuBFt+3xbB8cM21e9mV5qu X7RtcTE63an+YY1KssFHExCBhYH+RGi7MFkhZ5EPcNd0z07VxCbnMy6u2t9h7c0yyBF1O3 Uuk/4IAIyZWSj+dTCRtqZmzkVVuh2Lw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778853515; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Dy1toBPhPmAKSwz2c6XE36JaOkbrRuam9G2fSgNE9w=; b=IsMRaGQxqzg0EcL4OQH7x+C5AhFhNhAFExauB/d+9nef6Nurs4UQ2YtQz0xbTiWD11bJr6 e+9HHckIA4cDGuCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 47F33593AB for ; Fri, 15 May 2026 13:58:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id MNb4D4smB2q9CAAAD6G6ig (envelope-from ) for ; Fri, 15 May 2026 13:58:35 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v3 4/5] [gdb/python] Use py_{none,false} more often Date: Fri, 15 May 2026 15:58:33 +0200 Message-ID: <20260515135834.2502165-4-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260515135834.2502165-1-tdevries@suse.de> References: <20260515135834.2502165-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Do: ... $ sed -i \ "s/gdbpy_ref<>::new_reference (Py_False)/py_false ()/" \ gdb/python/*.{c,h} ... Likewise for py_none. --- gdb/python/py-cmd.c | 2 +- gdb/python/py-connection.c | 2 +- gdb/python/py-corefile.c | 4 ++-- gdb/python/py-frame.c | 4 ++-- gdb/python/py-inferior.c | 2 +- gdb/python/py-prettyprint.c | 8 ++++---- gdb/python/py-record-btrace.c | 2 +- gdb/python/py-symbol.c | 6 +++--- gdb/python/py-threadevent.c | 2 +- gdb/python/py-type.c | 10 +++++----- gdb/python/python.c | 4 ++-- 11 files changed, 23 insertions(+), 23 deletions(-) diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c index bcb1ba37d93..c515446dad8 100644 --- a/gdb/python/py-cmd.c +++ b/gdb/python/py-cmd.c @@ -186,7 +186,7 @@ cmdpy_completer_helper (struct cmd_list_element *command, if (word == NULL) { /* "brkchars" phase. */ - wordobj = gdbpy_ref<>::new_reference (Py_None); + wordobj = py_none (); } else { diff --git a/gdb/python/py-connection.c b/gdb/python/py-connection.c index 2d0b2e94659..3f20e8876f9 100644 --- a/gdb/python/py-connection.c +++ b/gdb/python/py-connection.c @@ -74,7 +74,7 @@ gdbpy_ref<> target_to_connection_object (process_stratum_target *target) { if (target == nullptr) - return gdbpy_ref<>::new_reference (Py_None); + return py_none (); gdbpy_ref conn_obj; auto conn_obj_iter = all_connection_objects.find (target); diff --git a/gdb/python/py-corefile.c b/gdb/python/py-corefile.c index 2c5596d093c..5acfd98d326 100644 --- a/gdb/python/py-corefile.c +++ b/gdb/python/py-corefile.c @@ -117,7 +117,7 @@ gdbpy_core_file_from_inferior (inferior *inf) gdb_assert (inf->pspace != nullptr); if (get_inferior_core_bfd (inf) == nullptr) - return gdbpy_ref<>::new_reference (Py_None); + return py_none (); PyObject *result = (PyObject *) cfpy_inferior_corefile_data_key.get (inf); if (result != nullptr) @@ -265,7 +265,7 @@ cfpy_mapped_files (PyObject *self, PyObject *args) return nullptr; } else - build_id = gdbpy_ref<>::new_reference (Py_None); + build_id = py_none (); /* List to hold all the gdb.CorefileMappedFileRegion objects. */ gdbpy_ref<> regions (PyTuple_New (file.regions.size ())); diff --git a/gdb/python/py-frame.c b/gdb/python/py-frame.c index 2a674ba52f8..068b6260af5 100644 --- a/gdb/python/py-frame.c +++ b/gdb/python/py-frame.c @@ -420,7 +420,7 @@ frapy_older (PyObject *self, PyObject *args) if (prev) prev_obj = frame_info_to_frame_object (prev); else - prev_obj = gdbpy_ref<>::new_reference (Py_None); + prev_obj = py_none (); return prev_obj.release (); } @@ -449,7 +449,7 @@ frapy_newer (PyObject *self, PyObject *args) if (next) next_obj = frame_info_to_frame_object (next); else - next_obj = gdbpy_ref<>::new_reference (Py_None); + next_obj = py_none (); return next_obj.release (); } diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index d2fc159c227..426aec31e9e 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -1026,7 +1026,7 @@ python_context_changed (user_selected_what selection) if (has_stack_frames ()) frame_obj = gdbpy_ref<> (gdbpy_selected_frame (nullptr, nullptr)); else - frame_obj = gdbpy_ref<>::new_reference (Py_None); + frame_obj = py_none (); if (frame_obj == nullptr) { diff --git a/gdb/python/py-prettyprint.c b/gdb/python/py-prettyprint.c index a561196a2a9..72ad5efcf07 100644 --- a/gdb/python/py-prettyprint.c +++ b/gdb/python/py-prettyprint.c @@ -86,7 +86,7 @@ search_pp_list (PyObject *list, PyObject *value) return printer; } - return gdbpy_ref<>::new_reference (Py_None); + return py_none (); } /* Subroutine of find_pretty_printer to simplify it. @@ -151,11 +151,11 @@ find_pretty_printer_from_gdb (PyObject *value) /* Fetch the global pretty printer list. */ if (gdb_python_module == NULL || ! PyObject_HasAttrString (gdb_python_module, "pretty_printers")) - return gdbpy_ref<>::new_reference (Py_None); + return py_none (); gdbpy_ref<> pp_list (PyObject_GetAttrString (gdb_python_module, "pretty_printers")); if (pp_list == NULL || ! PyList_Check (pp_list.get ())) - return gdbpy_ref<>::new_reference (Py_None); + return py_none (); return search_pp_list (pp_list.get (), value); } @@ -199,7 +199,7 @@ pretty_print_one_value (PyObject *printer, struct value **out_value) try { if (!PyObject_HasAttr (printer, gdbpy_to_string_cst)) - result = gdbpy_ref<>::new_reference (Py_None); + result = py_none (); else { result.reset (PyObject_CallMethodObjArgs (printer, gdbpy_to_string_cst, diff --git a/gdb/python/py-record-btrace.c b/gdb/python/py-record-btrace.c index 5f1c93170c6..bacb172fec4 100644 --- a/gdb/python/py-record-btrace.c +++ b/gdb/python/py-record-btrace.c @@ -824,7 +824,7 @@ recpy_call_filter (const uint64_t payload, std::optional ip, gdbpy_ref<> py_ip; if (!ip.has_value ()) - py_ip = gdbpy_ref<>::new_reference (Py_None); + py_ip = py_none (); else py_ip = gdb_py_object_from_ulongest (*ip); diff --git a/gdb/python/py-symbol.c b/gdb/python/py-symbol.c index bf803a3b487..224e5d90f26 100644 --- a/gdb/python/py-symbol.c +++ b/gdb/python/py-symbol.c @@ -450,7 +450,7 @@ gdbpy_lookup_symbol (PyObject *self, PyObject *args, PyObject *kw) return nullptr; } else - sym_obj = gdbpy_ref<>::new_reference (Py_None); + sym_obj = py_none (); if (PyTuple_SetItem (ret_tuple.get (), 0, sym_obj.release ()) < 0) return nullptr; @@ -495,7 +495,7 @@ gdbpy_lookup_global_symbol (PyObject *self, PyObject *args, PyObject *kw) return nullptr; } else - sym_obj = gdbpy_ref<>::new_reference (Py_None); + sym_obj = py_none (); return sym_obj.release (); } @@ -560,7 +560,7 @@ gdbpy_lookup_static_symbol (PyObject *self, PyObject *args, PyObject *kw) return nullptr; } else - sym_obj = gdbpy_ref<>::new_reference (Py_None); + sym_obj = py_none (); return sym_obj.release (); } diff --git a/gdb/python/py-threadevent.c b/gdb/python/py-threadevent.c index 13ce0d18daf..3c28aa1174a 100644 --- a/gdb/python/py-threadevent.c +++ b/gdb/python/py-threadevent.c @@ -33,7 +33,7 @@ py_get_event_thread (ptid_t ptid) PyErr_SetString (PyExc_RuntimeError, "Could not find event thread"); return NULL; } - return gdbpy_ref<>::new_reference (Py_None); + return py_none (); } gdbpy_ref<> diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c index 89ff19cd759..775145a8135 100644 --- a/gdb/python/py-type.c +++ b/gdb/python/py-type.c @@ -147,7 +147,7 @@ convert_field (struct type *type, int field) else { if (type->field (field).loc_is_dwarf_block ()) - arg = gdbpy_ref<>::new_reference (Py_None); + arg = py_none (); else arg = gdb_py_object_from_longest (type->field (field).loc_bitpos ()); attrstring = "bitpos"; @@ -173,7 +173,7 @@ convert_field (struct type *type, int field) } } if (arg == NULL) - arg = gdbpy_ref<>::new_reference (Py_None); + arg = py_none (); if (PyObject_SetAttrString (result.get (), "name", arg.get ()) < 0) return NULL; @@ -185,7 +185,7 @@ convert_field (struct type *type, int field) if (type->code () == TYPE_CODE_STRUCT) arg.reset (PyBool_FromLong (field < TYPE_N_BASECLASSES (type))); else - arg = gdbpy_ref<>::new_reference (Py_False); + arg = py_false (); if (PyObject_SetAttrString (result.get (), "is_base_class", arg.get ()) < 0) return NULL; @@ -197,7 +197,7 @@ convert_field (struct type *type, int field) /* A field can have a NULL type in some situations. */ if (type->field (field).type () == NULL) - arg = gdbpy_ref<>::new_reference (Py_None); + arg = py_none (); else arg = type_to_type_object (type->field (field).type ()); if (arg == NULL) @@ -219,7 +219,7 @@ field_name (struct type *type, int field) if (type->field (field).name ()) result.reset (PyUnicode_FromString (type->field (field).name ())); else - result = gdbpy_ref<>::new_reference (Py_None); + result = py_none (); return result; } diff --git a/gdb/python/python.c b/gdb/python/python.c index 4644d286855..fd254a340d8 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -1030,7 +1030,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args) } } else - result = gdbpy_ref<>::new_reference (Py_None); + result = py_none (); gdbpy_ref<> return_result (PyTuple_New (2)); if (return_result == NULL) @@ -1043,7 +1043,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args) return NULL; } else - unparsed = gdbpy_ref<>::new_reference (Py_None); + unparsed = py_none (); if (PyTuple_SetItem (return_result.get (), 0, unparsed.release ()) < 0 || PyTuple_SetItem (return_result.get (), 1, result.release ()) < 0) -- 2.51.0