From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TThoNr4mB2qVQD0AWB0awg (envelope-from ) for ; Fri, 15 May 2026 09:59:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AYlnU2JH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LHvP2LCW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AYlnU2JH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LHvP2LCW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CCC631E0B1; Fri, 15 May 2026 09:59:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DBCAE1E093 for ; Fri, 15 May 2026 09:59:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC06440A1F93 for ; Fri, 15 May 2026 13:59:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC06440A1F93 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AYlnU2JH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LHvP2LCW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AYlnU2JH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LHvP2LCW Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id CD19B4BA23C2 for ; Fri, 15 May 2026 13:58:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CD19B4BA23C2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CD19B4BA23C2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778853516; cv=none; b=sem9uBj86rAJH0I3iLWrbPsho6j6ePFp2z3EWu/laSPpi8EG9RSR2vFI+iy8N4drQuq65oMMN/MzBEpNSIEbm5lDRIxYUdIw4M6Wdtm5iCgXzJh8sWNU2r8a9yBiKhxaNn8XO0DRjAJ0STCR8NJLfpCr6IAvlDAO2oDtLyF96+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778853516; c=relaxed/simple; bh=UxSmPPY7Gi8Btc4Z0McW9sWwhb5/iZaNoEYX1+in42I=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Mw9CCOMROvOp15SkMB3j6zV85PmuKOGkS7BZPX+D9X8uIBqqMmLy3g80CyVrIglRJUcIZwWQRoEmDmZYcvIs7a6NkYzO9LnYT9mJAL98jdciDndbygdhpzN0xqrj5cH6eRvzTmR+m7ZIYxGifYKrNQ5XAC/+cdKMDIZw/A+CjNs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AYlnU2JH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LHvP2LCW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AYlnU2JH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LHvP2LCW DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD19B4BA23C2 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1CCB5EC97 for ; Fri, 15 May 2026 13:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778853514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eWzVF2B+Zv23IxM11ZsuJWJEx7QRrWneC/GuBB0XBXM=; b=AYlnU2JHrKRE7Uj92JdtA/nhePvnaKsjenFdyPtjVoc38lweKmvuvU/HxzLlaSc3EGRxHG 3Im8bvY0pz3WRQcAngqn8+VAzkmJ7PbJ4KtfeNYMb2b8Vqw6Z8TxC4U4ATs/6lqo0ZeKqU YpG51Q2S927P4DVkFsQORZ8WIIMxOvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778853514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eWzVF2B+Zv23IxM11ZsuJWJEx7QRrWneC/GuBB0XBXM=; b=LHvP2LCWsMiEQ/avybN5sho2pkGx+L6H5Hctt4ZinVin9Z+xipfFs9UnwmHSuFKSGRPMSp dby0CRhtookUJWCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778853514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eWzVF2B+Zv23IxM11ZsuJWJEx7QRrWneC/GuBB0XBXM=; b=AYlnU2JHrKRE7Uj92JdtA/nhePvnaKsjenFdyPtjVoc38lweKmvuvU/HxzLlaSc3EGRxHG 3Im8bvY0pz3WRQcAngqn8+VAzkmJ7PbJ4KtfeNYMb2b8Vqw6Z8TxC4U4ATs/6lqo0ZeKqU YpG51Q2S927P4DVkFsQORZ8WIIMxOvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778853514; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eWzVF2B+Zv23IxM11ZsuJWJEx7QRrWneC/GuBB0XBXM=; b=LHvP2LCWsMiEQ/avybN5sho2pkGx+L6H5Hctt4ZinVin9Z+xipfFs9UnwmHSuFKSGRPMSp dby0CRhtookUJWCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BB8BC593A9 for ; Fri, 15 May 2026 13:58:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HszMK4omB2q9CAAAD6G6ig (envelope-from ) for ; Fri, 15 May 2026 13:58:34 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v3 1/5] [gdb/python] Introduce py_{none, true, false, notimplemented} functions Date: Fri, 15 May 2026 15:58:30 +0200 Message-ID: <20260515135834.2502165-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,sourceware.org:url]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I came across this code: ... if (c) return v; else Py_RETURN_NONE; ... and realized I couldn't easily rewrite it into "return c ? v : ...". Probably something like this would work: ... return c ? v : ([] { Py_RETURN_NONE; } ()); ... but it made me wonder if we can rid of Py_RETURN_NONE. The only point of it seems to be to increase the reference count on the Py_None object for older python versions. Add a refcount-safe wrapper py_none (returning a gdbpy_ref), with the aim of replacing all uses of Py_RETURN_NONE with "return py_none ().release ()". Likewise for Py_RETURN_TRUE/Py_RETURN_FALSE/Py_RETURN_NOTIMPLEMENTED. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34145 --- gdb/python/python-internal.h | 44 ++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 3147156d5be..7c58309e4d4 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -1343,4 +1343,48 @@ class gdbpy_memoizing_registry_storage extern int eval_python_command (const char *command, int start_symbol, const char *filename = nullptr); +/* The following four functions are refcount-safe wrappers around + Py_RETURN_{NONE,TRUE,FALSE,NOTIMPLEMENTED}. + + Starting with python 3.12, None, True, False and Py_NotImplemented are + immortal, and increasing and decreasing refcount for such objects is a + no-op, and consequently for the limited C API 3.12 and newer, + Py_RETURN_NONE is simply "return Py_None". + + So for the limited C API 3.12 and newer, we could just return a + "PyObject *" instead. + + For the limited C API 3.12 and newer, while returning gdbpy_ref<> there's + an imbalance (we do a Py_DECREF in gdbpy_ref_policy::decref, without + corresponding Py_INCREF in Py_RETURN_NONE), but this is not harmful because + Py_DECREF is no-op for immortal objects. */ + +static inline gdbpy_ref<> +py_none () +{ + auto f = [] { Py_RETURN_NONE; }; + return gdbpy_ref<> (f ()); +} + +static inline gdbpy_ref<> +py_true () +{ + auto f = [] { Py_RETURN_TRUE; }; + return gdbpy_ref<> (f ()); +} + +static inline gdbpy_ref<> +py_false () +{ + auto f = [] { Py_RETURN_FALSE; }; + return gdbpy_ref<> (f ()); +} + +static inline gdbpy_ref<> +py_notimplemented () +{ + auto f = [] { Py_RETURN_NOTIMPLEMENTED; }; + return gdbpy_ref<> (f ()); +} + #endif /* GDB_PYTHON_PYTHON_INTERNAL_H */ base-commit: 79fcceafcbfe9aa02441445eb9444718b17330df -- 2.51.0