From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AUMzB0WoBGpxnjYAWB0awg (envelope-from ) for ; Wed, 13 May 2026 12:35:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Oql5aM/u; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VX3k3iFD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e4s4Zm1c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C+S+Ygq7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 18D661E067; Wed, 13 May 2026 12:35:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 986CE1E067 for ; Wed, 13 May 2026 12:35:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B22034BB8F63 for ; Wed, 13 May 2026 16:35:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B22034BB8F63 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Oql5aM/u; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VX3k3iFD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e4s4Zm1c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C+S+Ygq7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id C16924BBC096 for ; Wed, 13 May 2026 16:30:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C16924BBC096 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C16924BBC096 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778689821; cv=none; b=HsiiQkKnC8Z3z6KrEZSOH1vMdszxDLwuirgn1gJvWQey7IbtUquw6jZgVteKYdEylFqwLbEfWUjvVH52ZHokyAWDTBDnHm6hwxZ05n9Lf4I/a9wl+ZtDAnCHnO6FMStmu/Er2ik+rWRL3z0Qb9GB7l2kKAfqJJGKFgQ6j5ytn3o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778689821; c=relaxed/simple; bh=gZ0vJdsWuatz9HpfzPLsL0M5rlMDruBlRAHiBzC01oY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=InMfTd/vztaJSg7WE9vLkNaGY0ygepTh6sB5LIvyyt5fg/3Ln67iviTEt6KAo3JsNv4fMYyYKTq+AwzmqxcySHPiSQ1Mg4szj7eKHU+Yjrssb5JelIm4jMkgNskmbVtwXokVqFreK0gGJ2+6PEdA8JsX+3mbVnf+mbxpQLbNZDY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Oql5aM/u; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=VX3k3iFD; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=e4s4Zm1c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C+S+Ygq7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C16924BBC096 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E86B65D34E for ; Wed, 13 May 2026 16:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778689806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ct0PGxc52acpikFnAdoWKqtEqZIYCUIirzqiO3L+BNU=; b=Oql5aM/ullbVuAs57a5xD3WNJHngOoGkRA7CBSPYJ2Wez6MjttAakmydYfANMHZTyb+WwQ 3vlkhR9YID8xx9KdH8k59HEdDvPjE/1Nn3ocxqvuj6ldarMpfcKSwQFWL/o2NsdB3rA6P8 7ZLjGQmcJL4kgsf/OnyZKyvyNDas0Ks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778689806; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ct0PGxc52acpikFnAdoWKqtEqZIYCUIirzqiO3L+BNU=; b=VX3k3iFDoEzLVVU0YGwpVyTeQrZ0Kcempq7GMxFblsGqNQ96Vc6aPUDsnONCJt8MnfqhZU Ylq1dHu8cd3XycBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=e4s4Zm1c; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=C+S+Ygq7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778689805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ct0PGxc52acpikFnAdoWKqtEqZIYCUIirzqiO3L+BNU=; b=e4s4Zm1cSOfbHDVhgNdS4OApPjmEMvTTLrL1TxZsIJr8Vc53DfrQ5GMAm8kbXki7Twau2s 5XzrvqG2tvkCi/7UVMtNEY6nlpYnJ00hTgcq/bT4wCs2qz9MKzOc4yK+pt1gRlQb+Z1e/3 +7CGmKhtE6UbUm5nNDWe1h0ywliNXOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778689805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ct0PGxc52acpikFnAdoWKqtEqZIYCUIirzqiO3L+BNU=; b=C+S+Ygq787L5EzX6Mijf/92z0aNmTaRLS5maHnL7UVikZ17nIpzothEh4ncHIBjIBo85tX adPQ70gwPBcs8iAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CF698593AA for ; Wed, 13 May 2026 16:30:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mGpJMQ2nBGqzFgAAD6G6ig (envelope-from ) for ; Wed, 13 May 2026 16:30:05 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 1/2] [gdb/python] Introduce py_none/py_true/py_false functions Date: Wed, 13 May 2026 18:30:04 +0200 Message-ID: <20260513163005.3997485-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260513163005.3997485-1-tdevries@suse.de> References: <20260513163005.3997485-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, imap1.dmz-prg2.suse.org:rdns, imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: E86B65D34E X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I came across this code: ... if (c) return v; else Py_RETURN_NONE; ... and realized I couldn't easily rewrite it into "return c ? v : ...". Probably something like this would work: ... return c ? v : ([] { Py_RETURN_NONE; } ()); ... but it made me wonder if we can rid of Py_RETURN_NONE. The only point of it seems to be to increase the reference count on the Py_None object for older python versions. Add a refcount-safe wrapper py_none (returning a gdbpy_ref), with the aim of replacing all uses of Py_RETURN_NONE with "return py_none ().release ()". Likewise for Py_RETURN_TRUE/Py_RETURN_FALSE. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34145 --- gdb/python/python-internal.h | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 37bc37691fe..c3c1f0e6a6f 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -1340,4 +1340,27 @@ class gdbpy_memoizing_registry_storage extern int eval_python_command (const char *command, int start_symbol, const char *filename = nullptr); +/* The following three functions are refcount-safe wrappers around + Py_RETURN_{NONE,TRUE,FALSE}. Starting with python 3.12, None, True and + False are immortal, and increasing and decreasing refcount for such object + is a no-op, but while supporting older versions we ignore that aspect + here. */ + +static inline gdbpy_ref<> +py_none () +{ + return gdbpy_ref<> ([] { Py_RETURN_NONE; } ()); +} + +static inline gdbpy_ref<> +py_true () +{ + return gdbpy_ref<> ([] { Py_RETURN_TRUE; } ()); +} + +static inline gdbpy_ref<> +py_false () +{ + return gdbpy_ref<> ([] { Py_RETURN_FALSE; } ()); +} #endif /* GDB_PYTHON_PYTHON_INTERNAL_H */ -- 2.51.0