From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id X0qKLPu1BGrptDYAWB0awg (envelope-from ) for ; Wed, 13 May 2026 13:33:47 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=QoIDsvEC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A53031E0BA; Wed, 13 May 2026 13:33:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B87D61E067 for ; Wed, 13 May 2026 13:33:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4AECC4BBC0B0 for ; Wed, 13 May 2026 17:33:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4AECC4BBC0B0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=QoIDsvEC Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id C8C314BBC094 for ; Wed, 13 May 2026 17:33:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C8C314BBC094 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C8C314BBC094 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778693580; cv=none; b=WeGbr1XgdFq/kVrDa2jDERDdmoBSu5PNEJwP6WJx8s0M0ojwp/FX4UqAArQzAR8KL8Uq7t4fDowTDEmO2N08GwWbU3BAz9URcdo5Ss7c22ooHl7PA20oj2q/P67iKJD6qvZ01HvjQ2vfLt87zSA+G+k2easyobcXLFnm+A4niYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778693580; c=relaxed/simple; bh=iAT5NgbD5wkj4GqvGbN404dmcDhdk6XOUfY2hGJ72P8=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=k1EQ4AYDUDbNj+s/kFKjavkr/aI1OmQ3Wi9PV0DLjEad+DxYcZzpCG4Cxck2rTm7Bfa60wcn5SOI8hkGHZwsPGsKdcN/EX3Gesp88oeF0/1hLWOUQJOaq52RnGNOvN5W9PSdbX+CbGZ/ijW9aIhIrmyqaXPdfqa6oGOkbbMxFEg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=QoIDsvEC DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C8C314BBC094 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-47cacb4ed99so4604542b6e.1 for ; Wed, 13 May 2026 10:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1778693580; x=1779298380; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=ndHLX6JP6cOWY3Mso4kSxcojsdAQK/kQIgWyL3FlfTI=; b=QoIDsvEC0ABw/1Ivzf6oB+SNJZyRAIzjIrTfzlS6eMh5tlUwuhPlrjC8TEbjO1dCe7 HK1yCwg8630K5UatQzv4GCXnuLW5Szs1bEpA6/054zpHbqClj/9wY1/hbyqW/iPFMSLw J1Wyv4Ngxn5lCKfF5nEwBxORj43N7kGr4Qh+OyrcGWLc6XS/sZf5GPiqhZT9mcArKhr9 wkgCCO06k8U3wJOl3M2usEtqw7EPE0epoBjVn8uVXzq9mA18Y2JboKITaIwwBu0foeer LLvCLE+7OmnO70esei8taXj30YIHLJqdz1exYbY99rYNYwqNVf2aOfXqOBQQSGswrXJB DHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778693580; x=1779298380; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ndHLX6JP6cOWY3Mso4kSxcojsdAQK/kQIgWyL3FlfTI=; b=HSETH63oQpXwqv7vEZ5gNrzN/hJgpk9uVkvVqdFQgzCSWSBXctz0vCeIu2/5W1V4XR hQyWUwF7fLPwe9hqoI22IoJv/9zlEtf/Agikfii2wyj2Ix2qwc/XI5F9Te4nUV6JQEdx k5hzN+4IVOkT6Bs5kxN7xFgYaFeLarbfLFl0I20u6dImMNrIwkn7M5GRpIGURwI+byXf iadwWnyMHVQWFKLY4T6JJ48TQ9JR0AZ56DczA4B7QwnVY2lUPI0dOYxRfmj8IxySYD9v LVhsbkK5HRT91wgafpjWKenH4ZvtE7TVCjbwtCyNp8kM0QkyMxoRaE7dcYFUlziwhLdf kLqw== X-Gm-Message-State: AOJu0YwPlvPpF2y1c3gWx9jT6Rc8XEgAWcRCls21Nj9OkVcykvW8RdZf e96Oege8C8DB4aqxxoUaUSvJ1PyUdVMYgMe5js78FXRdPja7PcN5MkOq1zWZCfmfdGWgKH7Y2Y1 +cDM= X-Gm-Gg: Acq92OF3wu+QjGknPHU1BS79Dv1TXWFefzDcNJZLRA8yAmWqrCqHWvbbyy1dz62vuIz hz97cGqBRe485y6doAQ6g2fyX7tIR0RXEfz4OKi3zCv3lrWt6qr/jUmskQRDF2u6eFlwGeSUXIF I4jnTDAVAMZssljQrojdGtuq68pypTo2tch6KU5cIWmHGsALb8qx8IxchmDRdg6b3owwI7oqeCc jjU7xWx2s0H0tPZBHYZR0i5pAYAqTIsB6NDzBa2eHEeGTdh4lm6bmQIDNDLHwv0xpvlZPKxIrlR H66nNplKxQXdCiW/YV36tGM//jXMbD3gW828ghMN7O8OQw1y6mkKE7FZUMupGEMaXSSW3KvV9TH xkdpJ3d65CftK20Q1sLK7miTrbi0HE+n4eyzQk0W84ivTlz0Mwqc07/lAdvEjIhVrOoxKACvE1E G+mcLMl7gjEXHreDy8ew92ULeaxkL80cdDhFYkScnoaNN9zv6LPqxGMA== X-Received: by 2002:a05:6808:d52:b0:467:eccb:b788 with SMTP id 5614622812f47-482b2908abemr2690362b6e.9.1778693579969; Wed, 13 May 2026 10:32:59 -0700 (PDT) Received: from [192.168.0.26] (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-439fc1d7be5sm47734fac.5.2026.05.13.10.32.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 10:32:59 -0700 (PDT) From: Tom Tromey Subject: [PATCH 0/2] Remove for_each_thread Date: Wed, 13 May 2026 11:32:57 -0600 Message-Id: <20260513-remove-for-each-v1-0-8793bd79f781@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MwQqDMAyA4VeRnBe0lQ7Zq4wd0hptDrYjGSKI7 75ux+/w/ycYq7DBoztBeReTWhrcrYOUqayMMjeDH/x9CG5E5a3ujEtVZEoZ3ex88mkKMYzQqrf yIsf/+Hw1RzLGqFRS/n2qyiql38g+rHBdX7QtDqaBAAAA X-Change-ID: 20260513-remove-for-each-1d12c2c85b53 To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org As mentioned elsewhere on the list, here is a short series to remove for_each_thread. My view is that in most cases using 'foreach' and an iterator is preferable to using a callback-style iteration function. An explicit loop is clearer and often involves less code. This series removes for_each_thread. Note I left the NetBSD-specific variant alone, as I can't build or test this. Regression tested on x86-64 Fedora 43. Signed-off-by: Tom Tromey --- Tom Tromey (2): Use bool in continue_1 Remove for_each_thread gdb/breakpoint.c | 6 ++---- gdb/gdbthread.h | 9 --------- gdb/infcmd.c | 59 +++++++++++++++++++++++++++----------------------------- gdb/inferior.h | 2 +- gdb/mi/mi-main.c | 34 +++++++++++++++----------------- gdb/thread.c | 9 --------- 6 files changed, 47 insertions(+), 72 deletions(-) --- base-commit: b301725d35c1d6d80649180dcad1d3bdc42de862 change-id: 20260513-remove-for-each-1d12c2c85b53 Best regards, -- Tom Tromey