From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Wb+JMf1WA2rZ0DMAWB0awg (envelope-from ) for ; Tue, 12 May 2026 12:36:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l8H9n3NR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IwZYa6Qr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l8H9n3NR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IwZYa6Qr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C5D561E0C3; Tue, 12 May 2026 12:36:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3E6661E067 for ; Tue, 12 May 2026 12:36:13 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CFCF94BAE7E5 for ; Tue, 12 May 2026 16:36:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CFCF94BAE7E5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l8H9n3NR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IwZYa6Qr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l8H9n3NR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IwZYa6Qr Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 879C84BAD166 for ; Tue, 12 May 2026 16:34:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 879C84BAD166 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 879C84BAD166 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778603680; cv=none; b=ez9bUIPjqCdMsqZFLN5aXODREC2Nk1o/HlYn9BztF24ZXrbojGPtuhienr7CpvHD8rP4jYSiwm2BN0plTqGlPhyq7KAaWlRXL35xOHBHkwHvpWiHts03rCcSJt/AxrROCg31+HznW4XhOu4/LPT9QMH60ttHr0DIqdD7/CjpGUU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778603680; c=relaxed/simple; bh=YUGCeUIE3dEmOTo8fzy9KQTqH/iMCTa7dm1IQQIItug=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=CbQeav2vAAVyEqO6ZRHmOY83gp72KE7dLiuePfbqwqZYGb/gLobaGSJCgWOMWETC70Lg6hGsenDHgSour0OTVNjulYV1oVs3oB5pbVLJXRBpmZ4GyzHmRRd/Fk41rTDT0o8iVjBEhyXvF6bVl4Aku2hKjojedQRW+LbNBtaK+ko= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l8H9n3NR; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IwZYa6Qr; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=l8H9n3NR; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=IwZYa6Qr DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 879C84BAD166 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5E467760F5 for ; Tue, 12 May 2026 16:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778603679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G+wlG9QBOxynKi7m9ISLPPjYX+U3587uso0SM+bzuOE=; b=l8H9n3NR/8xEFF4rYg7mboPBSq1qFvfSiutBuCT3R2tWiQ/xTjOGHiaEthvC1hrkuVwKV/ Sq43ZZaj45tv+19BWmMjLKWvMGJEfMnEMIK0LanbQueRpg0p1g+vbzKGiShmgQvB2E99Pg w2/WfEPTjCM7HrICV1W/wU6eo+8YkSw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778603679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G+wlG9QBOxynKi7m9ISLPPjYX+U3587uso0SM+bzuOE=; b=IwZYa6QryYJ2xFJu+blIzN9HNB/bMg0XM4wvUY7/PjI/59EeqRDMEtFrGYeqrU4ljz+XhO NUX2UC1aE0ReU2Ag== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778603679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G+wlG9QBOxynKi7m9ISLPPjYX+U3587uso0SM+bzuOE=; b=l8H9n3NR/8xEFF4rYg7mboPBSq1qFvfSiutBuCT3R2tWiQ/xTjOGHiaEthvC1hrkuVwKV/ Sq43ZZaj45tv+19BWmMjLKWvMGJEfMnEMIK0LanbQueRpg0p1g+vbzKGiShmgQvB2E99Pg w2/WfEPTjCM7HrICV1W/wU6eo+8YkSw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778603679; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=G+wlG9QBOxynKi7m9ISLPPjYX+U3587uso0SM+bzuOE=; b=IwZYa6QryYJ2xFJu+blIzN9HNB/bMg0XM4wvUY7/PjI/59EeqRDMEtFrGYeqrU4ljz+XhO NUX2UC1aE0ReU2Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 454FC593A9 for ; Tue, 12 May 2026 16:34:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4aGAD59WA2pbEwAAD6G6ig (envelope-from ) for ; Tue, 12 May 2026 16:34:39 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 0/2] [gdb/python] Remove Py_RETURN_{NONE,TRUE,FALSE} Date: Tue, 12 May 2026 18:34:36 +0200 Message-ID: <20260512163438.2446764-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; URIBL_BLOCKED(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I came across this code: ... if (c) return v; else Py_RETURN_NONE; ... and realized I couldn't easily rewrite it into "return c ? v : ...". Probably something like this would work: ... return c ? v : ([] { Py_RETURN_NONE; } ()); ... but it made me wonder if we can rid of Py_RETURN_NONE. The only point of it seems to be to increase the reference count on the Py_None object for older python versions. ISTM unnecessary to increase the reference count for each Py_RETURN_NONE use. Instead, increase the reference count of Py_None once, and use a simple "return Py_None" instead of Py_RETURN_NONE everywhere. Tom de Vries (2): [gdb/python] Add init_py_immortals [gdb/python] Remove Py_RETURN_{NONE,TRUE,FALSE} gdb/python/py-block.c | 22 ++++++------- gdb/python/py-breakpoint.c | 54 ++++++++++++++++---------------- gdb/python/py-cmd.c | 2 +- gdb/python/py-connection.c | 6 ++-- gdb/python/py-corefile.c | 8 ++--- gdb/python/py-disasm.c | 6 ++-- gdb/python/py-evtregistry.c | 6 ++-- gdb/python/py-finishbreakpoint.c | 2 +- gdb/python/py-frame.c | 14 ++++----- gdb/python/py-framefilter.c | 2 +- gdb/python/py-inferior.c | 26 +++++++-------- gdb/python/py-infthread.c | 24 +++++++------- gdb/python/py-linetable.c | 14 ++++----- gdb/python/py-mi.c | 2 +- gdb/python/py-micmd.c | 4 +-- gdb/python/py-objfile.c | 22 ++++++------- gdb/python/py-prettyprint.c | 2 +- gdb/python/py-progspace.c | 18 +++++------ gdb/python/py-record-btrace.c | 48 ++++++++++++++-------------- gdb/python/py-record.c | 12 +++---- gdb/python/py-registers.c | 2 +- gdb/python/py-symbol.c | 10 +++--- gdb/python/py-symtab.c | 18 +++++------ gdb/python/py-tui.c | 10 +++--- gdb/python/py-type.c | 36 ++++++++++----------- gdb/python/py-unwind.c | 12 +++---- gdb/python/py-value.c | 28 ++++++++--------- gdb/python/py-xmethods.c | 2 +- gdb/python/python.c | 49 ++++++++++++++++++++--------- 29 files changed, 241 insertions(+), 220 deletions(-) base-commit: 2d7f2dbbd4adadf7c388fa0d8b9ce95d9dfde641 -- 2.51.0