From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YnBOGsHx/WlW4iMAWB0awg (envelope-from ) for ; Fri, 08 May 2026 10:22:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=CsabypNI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 37F0D1E0BA; Fri, 08 May 2026 10:22:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ED87E1E067 for ; Fri, 08 May 2026 10:22:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 723BD4BA2E09 for ; Fri, 8 May 2026 14:22:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 723BD4BA2E09 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=CsabypNI Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 361744BA2E10 for ; Fri, 8 May 2026 14:22:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 361744BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 361744BA2E10 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778250144; cv=none; b=FX+HLw5SIE2CAICzn+dh5C1v7kipKgSM3sLJThgwDA1r3TBato1E4HW5qBdh3zSi4Jg6VuEQeNa0kFqAtGDb0vxVgUFDBJFiWBoZV4dn0xhDayFTewWMzGtFnU+Si0kGfMUKkXp9IzJlO24vs+pF55iaSIvNegXaKToAq4iyhag= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778250144; c=relaxed/simple; bh=shBaLlrx9BEjjJq4J5vOYQMrBD80cejiFmWDFKSAsac=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FVr93nvcyk8mhE0tcVAiY67iXt58Lb0cm+Gm4dUUiR2/mRXUMAKUidMzlbY1Xe/sjyi+aUFkp5WIuIYBpLxnhWI90sVTdqZrl1AHg5MvMgXwiE9OsZaa5PP8so9aXK62NTUwsuc7MijHKvNK9+tcJZ21wQsdxB2dQ7pV6lr6sNw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=CsabypNI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 361744BA2E10 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-7dccb8644c4so1102484a34.0 for ; Fri, 08 May 2026 07:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1778250143; x=1778854943; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K4P3zDMO2VvT2rDxOv7cGY7ZXFWcX4woKXpsvDit8Iw=; b=CsabypNIAQKKOJV1Z5hLA/baY5u+2XirN4bZ0dZMj7f4mk4ZKMYggnvrOwZT90p+u7 +aMLdWrjlyrbe+rkKkuKtZo9BmOx4gkRw0AbV7w3glSbrgsnqrzGehYYda5b7M6K+ycx WWkN37RJC4v3b/fZfxIH6bZ6Mn3t7jXPMdW96DJ6CZtqGClC8Eemy3Tg2z4dEomKqO7+ FBuOt7GDAHmHof9Kehc631PL9QlU0toe2jn8JLigfP/yzolEwGEGo5LzsGig9kDGR1PN Gx1ZRbmAduQ/genfuRwKV/ganr5JnTrulE3MhiHqgiD8Vl+FpKqt+C25EZiaSY8cNU3J M6Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778250143; x=1778854943; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K4P3zDMO2VvT2rDxOv7cGY7ZXFWcX4woKXpsvDit8Iw=; b=IpAVCUkUs9pwEl1O4Nx8nUMTrlnWEoawyjGVdV0Iodm6azk4AWhZ8LLaonjyFCyAP5 4pAmDzfirn2NT3BLnrut8pmgmLZVDb0fPoyuHsNW22faYNWqS6ui24ibJOAFeH3p+hgs PW41fPAG/OtqTR5D9iav8tfDdzXIdNL9kfdUWocS7MaVYwEciNHA2RM1SM9ajvM5Cv6m Ha0lDJeNonKEVtHcvpTbjx/e74u5vcLMIgTicVwXiRai3WHENRI1UMV2XOAcKH4U4/11 zc5nISz+1tSfrvmITX7eJARpBTEJyQZYaZ+RZB9irOn/wV8bIUyQJoVC1ntQAM4kanpY K6ww== X-Gm-Message-State: AOJu0Yy8skGRO7Q6QC88KA/jftjLEwUgshx9UtOd4/upZZH2qblBKaJA 8IIH1UgFRSjzEli2pfP6tTvhgRKM2bctq9zKUTapxxPCckiv61k0pSxsnZVH038wQYKsCRvz5n5 WLNw= X-Gm-Gg: AeBDievIBKMSavevboTmr2Zzar0uFAzuVezIEqoxwgWbgXQOPb5aGDgHjKaHYLL5klE BLWvhKVecCUrrIJBjmFNYo/6r19PLwPqQMl5hMWb93gRq/BXkMGfQq8kEB35KnXL+jrBK/b9LTK 0Qjgfu0QrkyQFNw+sDO72gvqMXt6ivr2RsvIy7jPZGybjcaSe1L7IIYq1CLAa1tGaVaUWBaqKKy zidVNQVTcnEKo3fTROK3Fr54uhdUrkFroXmTpJsY0ZHBnrGvo+yBMdcvvRwif/u5j5Pcl4feHzH nm84L6eVgFQ+Q6ynbwL/TK/jRRKBHWBsDiwLoHt9bhbVbOgJTA1FrH8yeJZRvamCW9n2zcw9WzE 7orMnaATTOtkRCRLYkc1pmHrDlHDcleNGw4xQH1RMFi4VZyAM411qJaPAC5Hr4iPBLV3zlBJuGD Mj0PhPvCZDbVsGxkBZ27LutTvKub6+C8Vj9ABeuObdyTE= X-Received: by 2002:a05:6830:2584:b0:7dc:cadd:f95d with SMTP id 46e09a7af769-7e1deefa767mr8255064a34.2.1778250143303; Fri, 08 May 2026 07:22:23 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e367c055dcsm1175596a34.11.2026.05.08.07.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 07:22:22 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Use double quotes in some gdb output Date: Fri, 8 May 2026 08:22:21 -0600 Message-ID: <20260508142221.3434435-1-tromey@adacore.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I looked for spots where gdb was using `...' or ``...'' quoting, and changed these to use double quotes instead. I think it might be good to regularize output quoting in gdb. My proposal is to use double quotes, though single quotes would also be fine. Using `...', though, is a kind of older style and has fallen out of favor in GNU; the relevant node is here: https://www.gnu.org/prep/standards/html_node/Quote-Characters.html Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34044 --- gdb/mi/mi-getopt.c | 2 +- gdb/std-regs.c | 4 ++-- gdb/testsuite/gdb.base/radix.exp | 10 +++++----- gdb/testsuite/gdb.base/setshow.exp | 2 +- gdb/testsuite/gdb.trace/mi-trace-save.exp | 2 +- gdb/valprint.c | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gdb/mi/mi-getopt.c b/gdb/mi/mi-getopt.c index 865bba9abf8..14360fd78b5 100644 --- a/gdb/mi/mi-getopt.c +++ b/gdb/mi/mi-getopt.c @@ -72,7 +72,7 @@ mi_getopt_1 (const char *prefix, int argc, const char *const *argv, } if (error_on_unknown) - error (_("%s: Unknown option ``%s''"), prefix, arg + 1); + error (_("%s: Unknown option \"%s\""), prefix, arg + 1); else return -1; } diff --git a/gdb/std-regs.c b/gdb/std-regs.c index d5d946895d6..e8536187323 100644 --- a/gdb/std-regs.c +++ b/gdb/std-regs.c @@ -79,7 +79,7 @@ value_of_builtin_frame_sp_reg (const frame_info_ptr &frame, const void *baton) if (gdbarch_sp_regnum (gdbarch) >= 0) return value_of_register (gdbarch_sp_regnum (gdbarch), get_next_frame_sentinel_okay (frame)); - error (_("Standard register ``$sp'' is not available for this target")); + error (_("Standard register \"$sp\" is not available for this target")); } static struct value * @@ -90,7 +90,7 @@ value_of_builtin_frame_ps_reg (const frame_info_ptr &frame, const void *baton) if (gdbarch_ps_regnum (gdbarch) >= 0) return value_of_register (gdbarch_ps_regnum (gdbarch), get_next_frame_sentinel_okay (frame)); - error (_("Standard register ``$ps'' is not available for this target")); + error (_("Standard register \"$ps\" is not available for this target")); } INIT_GDB_FILE (frame_reg) diff --git a/gdb/testsuite/gdb.base/radix.exp b/gdb/testsuite/gdb.base/radix.exp index 7a4320bbf36..51fac418de8 100644 --- a/gdb/testsuite/gdb.base/radix.exp +++ b/gdb/testsuite/gdb.base/radix.exp @@ -157,34 +157,34 @@ gdb_test "set radix" \ "reset radices" gdb_test "set input-radix 0" \ - "Nonsense input radix ``decimal 0''; input radix unchanged\\." \ + "Nonsense input radix \"decimal 0\"; input radix unchanged\\." \ "Reject input-radix 0" gdb_test "show input-radix" \ "Default input radix for entering numbers is 10\\." \ "input radix unchanged after rejecting 0" gdb_test "set input-radix 1" \ - "Nonsense input radix ``decimal 1''; input radix unchanged\\." \ + "Nonsense input radix \"decimal 1\"; input radix unchanged\\." \ "Reject input-radix 1" gdb_test "show input-radix" \ "Default input radix for entering numbers is 10\\." \ "input radix unchanged after rejecting 1" gdb_test "set output-radix 0" \ - "Unsupported output radix ``decimal 0''; output radix unchanged\\." \ + "Unsupported output radix \"decimal 0\"; output radix unchanged\\." \ "Reject output-radix 0" gdb_test "show output-radix" \ "Default output radix for printing of values is 10\\." \ "Output radix unchanged after rejecting 0" gdb_test "set output-radix 1" \ - "Unsupported output radix ``decimal 1''; output radix unchanged\\." \ + "Unsupported output radix \"decimal 1\"; output radix unchanged\\." \ "Reject output-radix 1" gdb_test "show output-radix" \ "Default output radix for printing of values is 10\\." \ "output radix unchanged after rejecting 1" gdb_test "set radix 7" \ - "Unsupported output radix ``decimal 7''; output radix unchanged\\." \ + "Unsupported output radix \"decimal 7\"; output radix unchanged\\." \ "set radix 7 rejected" gdb_test "show output-radix" \ "Default output radix for printing of values is 10\\." \ diff --git a/gdb/testsuite/gdb.base/setshow.exp b/gdb/testsuite/gdb.base/setshow.exp index feac4e993ac..7ad420e1cf6 100644 --- a/gdb/testsuite/gdb.base/setshow.exp +++ b/gdb/testsuite/gdb.base/setshow.exp @@ -441,7 +441,7 @@ proc_with_prefix test_setshow_radix {} { clean_restart #test set radix 11 - gdb_test "set radix 11" "Unsupported output radix ``decimal 11''; output radix unchanged..*" + gdb_test "set radix 11" "Unsupported output radix \"decimal 11\"; output radix unchanged..*" #test set radix 16 gdb_test "set radix 16" "Input and output radices now set to decimal 16, hex 10, octal 20..*" diff --git a/gdb/testsuite/gdb.trace/mi-trace-save.exp b/gdb/testsuite/gdb.trace/mi-trace-save.exp index a6493d59339..ab2a7008307 100644 --- a/gdb/testsuite/gdb.trace/mi-trace-save.exp +++ b/gdb/testsuite/gdb.trace/mi-trace-save.exp @@ -33,7 +33,7 @@ proc test_trace_save_wrong_num_args { } { # Test with an unrecognized option. proc test_trace_save_wrong_opt { } { - set err_re [string_to_regexp "^error,msg=\"-trace-save: Unknown option ``hey''\""] + set err_re [string_to_regexp "^error,msg=\"-trace-save: Unknown option \\\"hey\\\"\""] mi_gdb_test "-trace-save -hey" "$err_re" "-trace-save with wrong option" } diff --git a/gdb/valprint.c b/gdb/valprint.c index 62b1b33bb66..b5b92eb0b3c 100644 --- a/gdb/valprint.c +++ b/gdb/valprint.c @@ -2272,7 +2272,7 @@ set_input_radix_1 (int from_tty, unsigned radix) if (radix < 2) { input_radix_1 = input_radix; - error (_("Nonsense input radix ``decimal %u''; input radix unchanged."), + error (_("Nonsense input radix \"decimal %u\"; input radix unchanged."), radix); } input_radix_1 = input_radix = radix; @@ -2314,7 +2314,7 @@ set_output_radix_1 (int from_tty, unsigned radix) break; default: output_radix_1 = output_radix; - error (_("Unsupported output radix ``decimal %u''; " + error (_("Unsupported output radix \"decimal %u\"; " "output radix unchanged."), radix); } base-commit: c7c8e5bf414b7512fb19df8bf153372d56cb7fc1 -- 2.54.0