From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QfmAMYak+2mXWBsAWB0awg (envelope-from ) for ; Wed, 06 May 2026 16:28:54 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=JFWsA/Mm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C23501E0BA; Wed, 06 May 2026 16:28:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C8D741E067 for ; Wed, 06 May 2026 16:28:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 51CF64BA2E37 for ; Wed, 6 May 2026 20:28:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51CF64BA2E37 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=JFWsA/Mm Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C6E554BA2E25 for ; Wed, 6 May 2026 20:28:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6E554BA2E25 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C6E554BA2E25 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778099291; cv=none; b=I4vP70tF/PGrsfYeuBomjstLUWKOGXG4h6oQe84ZBqVD29Bdy5Ppr98Jkgm4cpez6AmJ/uCdWSfTLItp24Vcq19lmEbWs8JOi4pRi1Mrqf298J0dARYeaTSSNNHLWlGvVQ5+70pDgB3mKLIKuOspNHYXbjFEEbP3bCdDTywjUKE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1778099291; c=relaxed/simple; bh=j0TdDxuHHcUZ+GrlNW7PV+tC3cvPZGnKn//lHRp8ZP4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ijwufXBv4i5WhbnyC7303kFtt44piv0ruAcLX471oh/ZYS08LZPH345W7OuZb0d5X0oXQU7QZr1AbWiaN9jmQSdhUhYsvFu03JSBmx6Bbq081/i/nYASlhiV1ncHFzH8cZ0TkSI0A5NGurHPogfbvjHeuVM/weZlO+z9NzuJwRM= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=JFWsA/Mm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6E554BA2E25 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 646KS6Fm154433 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 May 2026 16:28:10 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 646KS6Fm154433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1778099291; bh=ffVRrfMcyNoYeGFycjQPt7PFnnCiB22/1bibWV+AvYM=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=JFWsA/MmN1/7JGZLQ6hQHhaXdGmTMyMi4lq5uavWKuABamWNx1FVG22g6/crzV4t2 C1voKAx7V9i6sU2RPVz5VezWNuUFP6ZQ5MI97QCoFpNwNFnVzBZRJtxPxbksSzc5lM pOuomvspJ/H7qP6TxF383NuaSSkJVDdI348NQbYbYhbHenVT+USNzLkaWHxUedCSut yRryxCQ/BU69gWJaCQR4eBFfXwnMMjQXqzYmrA0jrPTeex6rOQxq7IpeBqV8qWz1yT IdCmJCkcXGdB2D2ko6KvncL9gHXrn8AjZKQ5rJxms5ZGa7YuuLK4wvQqwyIA9URVth ZuarhjB+k4cYw== Received: by simark.ca (Postfix) id 0E5131E0B1; Wed, 06 May 2026 16:28:05 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/7] gdb/testsuite: remove unused arguments to gdb_breakpoint Date: Wed, 6 May 2026 16:27:49 -0400 Message-ID: <20260506202804.1681886-2-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506202804.1681886-1-simon.marchi@polymtl.ca> References: <20260506202804.1681886-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 6 May 2026 20:28:06 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi These arguments don't actually do anything, remove them. Change-Id: Ifd6a18d3effc521ba410fd40280a197d37661b12 --- gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp | 4 +--- gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp | 6 ++---- gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp | 12 ++++-------- gdb/testsuite/gdb.base/gcore-memory-usage.exp | 2 +- gdb/testsuite/gdb.base/valgrind-disp-step.exp | 2 +- gdb/testsuite/gdb.base/watchpoint-unaligned.exp | 5 ++--- gdb/testsuite/gdb.threads/fork-thread-pending.exp | 2 +- gdb/testsuite/gdb.threads/multiple-step-overs.exp | 2 +- gdb/testsuite/gdb.threads/thread-bp-deleted.exp | 3 +-- 9 files changed, 14 insertions(+), 24 deletions(-) diff --git a/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp b/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp index 269e32cecc74..27a13b346e8a 100644 --- a/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp @@ -29,9 +29,7 @@ if {![runto_main]} { return -1 } -gdb_breakpoint "[gdb_get_line_number "ldxr"]" \ - "Breakpoint $decimal at $hex" \ - "Set the breakpoint at the start of the sequence" +gdb_breakpoint "[gdb_get_line_number "ldxr"]" gdb_test "continue" "Continuing.*Breakpoint $decimal.*" \ "Continue until breakpoint" diff --git a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp index c020df807f44..80410fe6f7c3 100644 --- a/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/ppc64-atomic-inst.exp @@ -39,12 +39,10 @@ proc do_test { displaced } { gdb_test_no_output "set displaced-stepping $displaced" set bp1 [gdb_get_line_number "lwarx"] - gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lwarx/stwcx sequence" + gdb_breakpoint "$bp1" set bp2 [gdb_get_line_number "ldarx"] - gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the ldarx/stdcx sequence" + gdb_breakpoint "$bp2" gdb_test continue "Continuing.*Breakpoint $decimal.*" \ "continue until lwarx/stwcx start breakpoint" diff --git a/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp index 482dbb4d04fd..0772eda0a0a8 100644 --- a/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp +++ b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp @@ -43,8 +43,7 @@ proc do_test { displaced } { gdb_test_no_output "set displaced-stepping $displaced" - gdb_breakpoint "test_atomic_sequences" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the test function" + gdb_breakpoint "test_atomic_sequences" gdb_test_multiple "continue" "Continue until lbarx/stbcx start breakpoint" { -re "$inferior_exited_re with code 01.\[\r\n\]+$gdb_prompt $" { @@ -57,16 +56,13 @@ proc do_test { displaced } { } set bp1 [gdb_get_line_number "lbarx" "$srcfile2"] - gdb_breakpoint "$bp1" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lbarx/stbcx sequence" + gdb_breakpoint "$bp1" set bp2 [gdb_get_line_number "lharx" "$srcfile2"] - gdb_breakpoint "$bp2" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lharx/sthcx sequence" + gdb_breakpoint "$bp2" set bp3 [gdb_get_line_number "lqarx" "$srcfile2"] - gdb_breakpoint "$bp3" "Breakpoint $decimal at $hex" \ - "set the breakpoint at the start of the lqarx/stqcx sequence" + gdb_breakpoint "$bp3" gdb_test continue "Continuing.*Breakpoint $decimal.*" \ "continue until lbarx/stbcx start breakpoint" diff --git a/gdb/testsuite/gdb.base/gcore-memory-usage.exp b/gdb/testsuite/gdb.base/gcore-memory-usage.exp index fc57d1604e29..d9c8dd0bffc3 100644 --- a/gdb/testsuite/gdb.base/gcore-memory-usage.exp +++ b/gdb/testsuite/gdb.base/gcore-memory-usage.exp @@ -61,7 +61,7 @@ proc run_test {megs max_mem} { gdb_test "attach $inferior_pid" "Attaching to.*" attach set line [gdb_get_line_number "TAG: BREAK HERE" $::testfile.c] - gdb_breakpoint "${::srcfile}:$line" "break at to known line" + gdb_breakpoint "${::srcfile}:$line" gdb_continue_to_breakpoint "continue to known line" # Get the important info. diff --git a/gdb/testsuite/gdb.base/valgrind-disp-step.exp b/gdb/testsuite/gdb.base/valgrind-disp-step.exp index 13f36837d5e2..c2991b247b9d 100644 --- a/gdb/testsuite/gdb.base/valgrind-disp-step.exp +++ b/gdb/testsuite/gdb.base/valgrind-disp-step.exp @@ -35,7 +35,7 @@ if { [vgdb_start] == -1 } { } gdb_test_no_output "set displaced-stepping off" -gdb_breakpoint "main" "breakpoint at main" +gdb_breakpoint "main" gdb_test "continue" " stop 0 .*" "continue to main" delete_breakpoints diff --git a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp index 8b929e5de4e6..3ec57cc9c455 100644 --- a/gdb/testsuite/gdb.base/watchpoint-unaligned.exp +++ b/gdb/testsuite/gdb.base/watchpoint-unaligned.exp @@ -28,7 +28,7 @@ if {![runto_main]} { return -1 } -gdb_breakpoint [gdb_get_line_number "start_again"] "Breakpoint $decimal at $hex" "start_again" +gdb_breakpoint [gdb_get_line_number "start_again"] set sizes {1 2 4 8} array set alignedend {1 1 2 2 3 4 4 4 5 8 6 8 7 8 8 8} @@ -164,8 +164,7 @@ proc size8twice { function cmd offset index } { # Set a breakpoint. set bp_src_string "${function}_return" set bp_loc [gdb_get_line_number $bp_src_string] - gdb_breakpoint $bp_loc \ - "Breakpoint $::decimal at $::hex" "$bp_src_string" + gdb_breakpoint $bp_loc # Set a hardware watchpoint. set watch_index [expr {$offset + $index}] diff --git a/gdb/testsuite/gdb.threads/fork-thread-pending.exp b/gdb/testsuite/gdb.threads/fork-thread-pending.exp index 6f81e5e7e491..91da718d19ce 100644 --- a/gdb/testsuite/gdb.threads/fork-thread-pending.exp +++ b/gdb/testsuite/gdb.threads/fork-thread-pending.exp @@ -29,7 +29,7 @@ if {![runto_main]} { gdb_test_no_output "set follow-fork-mode child" "1, set follow-fork-mode child" gdb_test "catch fork" "Catchpoint \[0-9\]* \\(fork\\)" "1, insert fork catchpoint" -gdb_breakpoint "start" "" "1, set breakpoint at start" +gdb_breakpoint "start" gdb_test "continue" "Catchpoint.*" "1, get to the fork event" diff --git a/gdb/testsuite/gdb.threads/multiple-step-overs.exp b/gdb/testsuite/gdb.threads/multiple-step-overs.exp index 8433e16340ad..dc4f4ce2db9d 100644 --- a/gdb/testsuite/gdb.threads/multiple-step-overs.exp +++ b/gdb/testsuite/gdb.threads/multiple-step-overs.exp @@ -101,7 +101,7 @@ foreach displaced { "off" "on" } { # Switch back to thread 1, and continue. gdb_test "thread 1" "Switching.*" "switch back to thread 1" - gdb_breakpoint "sigusr1_handler" "set break at sigusr1_handler" + gdb_breakpoint "sigusr1_handler" set msg "continue to sigusr1_handler" gdb_test_multiple "continue" $msg { diff --git a/gdb/testsuite/gdb.threads/thread-bp-deleted.exp b/gdb/testsuite/gdb.threads/thread-bp-deleted.exp index 037e8288b62f..84e464f75528 100644 --- a/gdb/testsuite/gdb.threads/thread-bp-deleted.exp +++ b/gdb/testsuite/gdb.threads/thread-bp-deleted.exp @@ -96,8 +96,7 @@ proc check_for_thread_specific_breakpoint { testname bpnum expected } { # Create a thread-specific breakpoint. This will never actually be hit; we # don't care, we just want to see GDB auto-delete this breakpoint. -gdb_breakpoint "main thread $worker_thread" \ - "create a thread-specific breakpoint" +gdb_breakpoint "main thread $worker_thread" set bpnum [get_integer_valueof "\$bpnum" "INVALID" \ "get number for thread-specific breakpoint"] -- 2.54.0