From: Markus Metzger <markus.t.metzger@intel.com>
To: gdb-patches@sourceware.org
Cc: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
Simon Marchi <simark@simark.ca>
Subject: [PATCH v2] gdb: update store_integer's comment
Date: Tue, 5 May 2026 06:38:09 +0000 [thread overview]
Message-ID: <20260505063809.1821415-1-markus.t.metzger@intel.com> (raw)
From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
The comment of store_integer seems slightly outdated and does not
refer to the variants that take an array view. Update the comment.
CC: Simon Marchi <simark@simark.ca>
---
| 3 +--
| 15 ++++++++++++++-
2 files changed, 15 insertions(+), 3 deletions(-)
--git a/gdb/extract-store-integer.c b/gdb/extract-store-integer.c
index a7bce99362d..6749c46fb6b 100644
--- a/gdb/extract-store-integer.c
+++ b/gdb/extract-store-integer.c
@@ -129,8 +129,7 @@ extract_typed_address (const gdb_byte *buf, struct type *type)
return gdbarch_pointer_to_address (type->arch (), type, buf);
}
-/* All 'store' functions accept a host-format integer and store a
- target-format integer at ADDR which is LEN bytes long. */
+/* See extract-store-integer.h. */
template<typename T, typename>
void
store_integer (gdb::array_view<gdb_byte> dst, enum bfd_endian byte_order,
--git a/gdb/extract-store-integer.h b/gdb/extract-store-integer.h
index 76dfd49d62a..49799bb0953 100644
--- a/gdb/extract-store-integer.h
+++ b/gdb/extract-store-integer.h
@@ -57,12 +57,17 @@ extern CORE_ADDR extract_typed_address (const gdb_byte *buf,
struct type *type);
/* All 'store' functions accept a host-format integer and store a
- target-format integer at ADDR which is LEN bytes long. */
+ target-format integer, either at DST, which contains its size,
+ or at ADDR, which is LEN bytes long. */
+/* Take a host-format integer VAL and store it as a target-format
+ integer at DST. */
template<typename T, typename = RequireLongest<T>>
extern void store_integer (gdb::array_view<gdb_byte> dst,
bfd_endian byte_order, T val);
+/* Take a host-format integer VAL and store it as a target-format integer
+ at ADDR which is LEN bytes long. */
template<typename T>
static inline void
store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val)
@@ -70,6 +75,8 @@ store_integer (gdb_byte *addr, int len, bfd_endian byte_order, T val)
return store_integer (gdb::make_array_view (addr, len), byte_order, val);
}
+/* Take a host-format signed integer VAL and store it as a target-format
+ integer at DST. */
static inline void
store_signed_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
LONGEST val)
@@ -77,6 +84,8 @@ store_signed_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
return store_integer (dst, byte_order, val);
}
+/* Take a host-format signed integer VAL and store it as a target-format
+ integer at ADDR which is LEN bytes long. */
static inline void
store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order,
LONGEST val)
@@ -85,6 +94,8 @@ store_signed_integer (gdb_byte *addr, int len, bfd_endian byte_order,
val);
}
+/* Take a host-format unsigned integer VAL and store it as a target-format
+ integer at DST. */
static inline void
store_unsigned_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
ULONGEST val)
@@ -92,6 +103,8 @@ store_unsigned_integer (gdb::array_view<gdb_byte> dst, bfd_endian byte_order,
return store_integer (dst, byte_order, val);
}
+/* Take a host-format unsigned integer VAL and store it as a target-format
+ integer at ADDR which is LEN bytes long. */
static inline void
store_unsigned_integer (gdb_byte *addr, int len, bfd_endian byte_order,
ULONGEST val)
--
2.34.1
Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2026-05-05 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 6:38 Markus Metzger [this message]
2026-05-05 16:05 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505063809.1821415-1-markus.t.metzger@intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox