From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SfMkJ8GP8mm9ZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:09:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Qs38yEBu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 98E431E0BA; Wed, 29 Apr 2026 19:09:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1303A1E093 for ; Wed, 29 Apr 2026 19:09:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B34A94358A72 for ; Wed, 29 Apr 2026 23:09:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B34A94358A72 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Qs38yEBu Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id B1E324BB3BD2 for ; Wed, 29 Apr 2026 23:06:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1E324BB3BD2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B1E324BB3BD2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777504005; cv=none; b=jGLNHuAHDviHm9x1RLdqciVdFw5tJI1IZ+vRNbRwZQTmIezJvIQWv69/7Inz1w+CAL6iiGDKnurhGHqXITkMbLgm/gTNV2KcOd1QoAtDU1XkrzTA7c3YmCLVIhBnbYfSmUp5YzBFEl3EsSPc2+Kv0wOHXPt9CSFBU9CcR5q+2fU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777504005; c=relaxed/simple; bh=vNDn4GuUVKCIIH4zCm7fzLrW5zaO30MhA22woT1WYMc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FkF/4u71sAdwJaftCO/d92V8n00/oswl2LRTD/54y+l8A2vEUV+AszkbGmWCUpic1LQjfmH2MTxi21RHte+/GsGtiDqSeeFYSQnboXdhZGfh825Royxslu5Lc4UJN8yAYi0gnrwCSDTUGUY7WNFrBf1qqkXoIvCwwZISxUTCMG0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1E324BB3BD2 Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-56d933b555cso92748e0c.0 for ; Wed, 29 Apr 2026 16:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777504005; x=1778108805; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=aBYKAQar8/tSECA//E1n/qAmbI1oe7i1J3llcoplrg4=; b=Qs38yEBuj/qkXLloGfuTQlI8x1Hk6NyDDcWP1MHIQYkVSlaoqb7WDkcCad4t0ibyON bt3YiKvAEn3dwB5ftPextSa63NuaJ2EumkoPEtw7BDJ/IsAJGVq8DXLw2HAfrU7EF+uu lZ1Cfu+z0YLRtK2+64ahJMeJn+gkAHbs/GFkkW6+IeChUrUr66Vfam/OBYtUjs7CMrsi o2mkfr/Bv2S4gjLXLocIQpplWBD3puZRTj5yhnl0KZ3Ft6h4n12OBVZf8kvsBGdIDXmc 8RaTHmme4OFtnHUDxQ0B081bkbqpxlpI1PsBcn/WXf1va+xgzHh0mQVQ0emPJ7QVTQ1T u+0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777504005; x=1778108805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aBYKAQar8/tSECA//E1n/qAmbI1oe7i1J3llcoplrg4=; b=N0Sf4y5erhAko+yoFYCIhHW/LcdX2abLJx39jZSy7DUyZhvoMsCCorheUbQzNwwm34 +MkSJF6JzgxZymuZT/YH3OAMKXjzJss6n7SaAs7n051wtVOyA+8jWVrjwndFW1beAUNS l3s9L3TTkG+6Vg9tyLWQJmQsYKjlW3DX+tJILxeQQVEw7iqKRxL+JnjYj0z9787xUezR zcaBBGy9OZgpmBKU8CXBqvNunG7POEC1o7oE6eaokXlVIRlotTluk+V05o2fX2EUcWzy P0WJlgweBTM6b9t3BfnjvP/C+WZN3q7o7GSLqijdLdDKhO9lWgmpYHbbE5x1LAexZcmO acmg== X-Gm-Message-State: AOJu0YxFUW/d9AJKO5xZyRR/rR9774XhJHbD2S39vN9frdAWpObg1y2m Ylcb02CVRHZ19lhcGamESS/Q4z35U4MfeoUgn75U76FM288+d8NW6Q8c7A1s2CiRQPRWyrv6yw9 WlmCC X-Gm-Gg: AeBDiev/AOrgcVsmP7y1hh9799h8XjUKw89wKauSODYmPxrKTm83R6auCleUfchcEaW xWK5lsOy9qOA61IoE5UlcyxUA0MUcU+DrRwFpaDr9b71kmaZdC7b354nRStX4pNDpPbUZVaQAPq IIFFsL/OE7D0UT0wKXCv/zxheHmbZGXHzwA3xruJLASnh/UCnZQBtqT5LL/tqgHC95iYdXbzcqC jIKeLuWdfhizW44ZAAT2pbuwpkUThxPWhKGehWPe33Gpfq2zVuEwST/V5utw5zOtJlPdbIoRWeI hYpFBoNO4f6ESg8/R+0OqAAQDPRbdOE/WQZfKBls3wo0ePztsnQwVpngwTKJIqqL5S93hMzYBHH 2BqtjplJDW5YevDzIvmyA5S5zPlQ09RQvsf2x09ReRqPfwhNZwV4TIHEgKN4s2oX4uIyr+ILltM uSdnAOfW/3kLbHeHLLJiSiL44ns9/KDNOHI7cHFr1oVPG3GRrJYjg4Aek= X-Received: by 2002:a05:6122:8b8b:b0:573:a779:62cf with SMTP id 71dfb90a1353d-573c969445amr88410e0c.7.1777504005104; Wed, 29 Apr 2026 16:06:45 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-573b6bbace7sm2073590e0c.5.2026.04.29.16.06.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:06:44 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 36/37] GDB: testsuite: TUI: Don't return 0 from top-level (manual) Date: Wed, 29 Apr 2026 20:04:27 -0300 Message-ID: <20260429230432.60487-37-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch changes statements that return 0 from the top level, and also one "return -1" statement that wasn't caught by sed. --- gdb/testsuite/gdb.tui/basic.exp | 2 +- gdb/testsuite/gdb.tui/resize-2.exp | 2 +- gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp | 2 +- gdb/testsuite/gdb.tui/tui-mode-switch.exp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.tui/basic.exp b/gdb/testsuite/gdb.tui/basic.exp index 26264082a163..45fdf3a7a76f 100644 --- a/gdb/testsuite/gdb.tui/basic.exp +++ b/gdb/testsuite/gdb.tui/basic.exp @@ -68,11 +68,11 @@ for { set i 1 } { $i <= $Term::_cols } { incr i } { # current way we position source code on the screen, which might change in # the future. gdb_assert { $main_screen_line == 7 } \ "check main is where we expect on the screen" if { $main_screen_line == -1 } { - return 0 + return } # Check the horizontal scrolling. set shifted_main_re [string range $main_re 1 end] set regexp "$main_line\[\\t \]+$shifted_main_re" diff --git a/gdb/testsuite/gdb.tui/resize-2.exp b/gdb/testsuite/gdb.tui/resize-2.exp index 69578cc4a22e..b7eb38f3c046 100644 --- a/gdb/testsuite/gdb.tui/resize-2.exp +++ b/gdb/testsuite/gdb.tui/resize-2.exp @@ -25,11 +25,11 @@ set screen_dim { 0 0 80 24 } # Use a layout with just a command window. gdb_test "tui new-layout command-layout cmd 1" if {![Term::prepare_for_tui]} { unsupported "TUI not supported" - return 0 + return } # Enter TUI. Term::command_no_prompt_prefix "layout command-layout" diff --git a/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp b/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp index 58add6dc3291..00f52c7cdfb6 100644 --- a/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp +++ b/gdb/testsuite/gdb.tui/tui-disasm-long-lines.exp @@ -29,11 +29,11 @@ if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "$binfile" \ # Try with a shorter version. lappend ccopts "additional_flags=-DSHORT_IDENTIFIERS" if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "$binfile" \ executable $ccopts] != "" } { untested "compile" - return -1 + return } } Term::clean_restart 24 80 $testfile if {![Term::prepare_for_tui]} { diff --git a/gdb/testsuite/gdb.tui/tui-mode-switch.exp b/gdb/testsuite/gdb.tui/tui-mode-switch.exp index c60596213b85..250b557125ec 100644 --- a/gdb/testsuite/gdb.tui/tui-mode-switch.exp +++ b/gdb/testsuite/gdb.tui/tui-mode-switch.exp @@ -13,11 +13,11 @@ Term::with_term $term { Term::clean_restart 12 40 } if {![Term::prepare_for_tui]} { unsupported "TUI not supported" - return 0 + return } # Generate prompt. Term::gen_prompt