From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6eH3JJqP8mkiaAQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:09:14 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qB8lYMa6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8A6031E0E2; Wed, 29 Apr 2026 19:09:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABAD51E0CA for ; Wed, 29 Apr 2026 19:09:11 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 516314358A40 for ; Wed, 29 Apr 2026 23:09:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 516314358A40 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=qB8lYMa6 Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) by sourceware.org (Postfix) with ESMTPS id ADFD24BB3BE9 for ; Wed, 29 Apr 2026 23:06:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADFD24BB3BE9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ADFD24BB3BE9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::92f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503987; cv=none; b=m1OB//A4osFhDgbJGh7klhUxCYwzKsUlywPQoGZaSLCM61AvK7bb+i9HRfLbN0DYmxm1aT8BI8uGB/Y6mFqGSTJMR64sF1VCX2T6OjzR+C4xiFXPBBGkps/ayEtExwcFRzd6mxVORqut1OFGC6qYLj7zG1tmuA3DXMaYJOwfbhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503987; c=relaxed/simple; bh=8UuNgweJSa5e/SSPTG6c1oG/5EXdwVALfPfRPGSTvZc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c+SqUsqoQEf0RqK5FVAxnFnnzrEit9FgI6/XW21hed/hiLclS3hOgfj1g9Fk16Cxk4lKiMirbphhC83YfBv+3eaijgI9780jk5RPlJgqRljuTCCwqCtFkqKIQsbotJY5TE+QWrX2zdyJQHHSMwHBCzs6G9yPncTncMsMK1f9ucA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ADFD24BB3BE9 Received: by mail-ua1-x92f.google.com with SMTP id a1e0cc1a2514c-953a44f8404so120279241.0 for ; Wed, 29 Apr 2026 16:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503987; x=1778108787; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=kX5XOo/uK60yqBS7sro77nCo5Y/QPlP5bbIRzqBCV9E=; b=qB8lYMa6OaXffUb+w6P4nWLJ7LAsyVDqIjB4iEdxt0F6k08+2cyN8LHgsRIIz+wznC IGEo9YhSt3hytxH0TS4O8CGK9cDcGl0axKE5SG6m7xstYLdl+W//iBNk+Xu2MeQcvjoS dkcoL/5ALgnu3s6BJQC4sUn+jNrryS7XZ1pIE5Ki5SqZ9PpUtR/oeEYnWziEdH7ljhV8 Os8RqznFp18guSHjDnW+fj7nF1rL5IGHUy6ZBOt4Nvk2LAhn+4Qg7RDz4u4RNsTEZ1Nu m7KiDkypcPyj2vIlZ/fSBMoDK1fiTgW1CSL4iuKkLZeC7mvpRgYT4AfMND61N+KNyAKB RI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503987; x=1778108787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kX5XOo/uK60yqBS7sro77nCo5Y/QPlP5bbIRzqBCV9E=; b=HaRQa4Oq4G2EgBwSJOoInq/Ts1dz2jrj/uonkICKORpKMVTU0hdggWnL6cZFHsiz+h JbWy57tAz2GzOJwETZqz0v0MDtJ+0WV+GKrZG3gQmYbwXmCnann/J41xjd531R7z30Dk DwD21sKn4x6W4K9u/+0+WUfBECreIn2DZZHR49V0uwGccKlplnvNgptkBD7fPsO2ULDq ls2+KQ8QTtMpCB7fK4uEu7ITUwRZsd04NnPB0/e3JLYvnGx0pcoXS+7Mn79Phhr076Pc bSN6YM792q81+clUgXiExbyl6x9qWR4Yfmhg+hQMTvEbGQjxQz4fDud9m3PndmZyayX4 H5oQ== X-Gm-Message-State: AOJu0Yy3rg4BYH9bf2itpe/jCrxSKsyI9fBgY2xydZUnYqzj6MsE0GbT kbhkoyJkbm7nCv3vNV8r53iaS+yTO3PUEDbGgDF9IXRQG6bcBzYU2Kb35sJGJChkXGkBirZRRT0 NmrOG X-Gm-Gg: AeBDiev0hLuLu+2GNPDWxGaaflcFAhdACPDgv5XzC0iHL6SxSemv1OEOIn+Df/ih+WT Ejdq502mpDPb03DlCcjuDWBLE1tMWbrY5ds9MR8PAEg9a/YjuH30TCcvy3BB8Ca4Lm4dBCRR4+m r+uXvPhphcjzeloxwvr2ew3EFGqCHrNQ6sPpR3mUJ+irQWW9OF0R50TtiDwBmOK5L7LQq4TsHnx n5Cua8ciPMMwumyFq8ITNg1y+aSm8bLoO6uQyhc0nbWXDPideGF/47ahUfcXu7L7SllDRz9Zo7f o2gfQjtlczHnux0MecPJSGxD+NFgfqOJYoUty0674Yrh2DrJBXBR/i/VFTk15espGFo8tiN/bWC SuSZ5xJqpFIQmMuWX1Or9q2V52BiahuPshSR8ogo3ZQSn3HL4xQ+pbIHM/U7ebSee3mtQtBcG95 d2xF8oKdMO2Y9RErdJS7OoVezVu9bsv4nEE6OMiVaKCDCv X-Received: by 2002:a05:6102:508e:b0:60f:7499:9b63 with SMTP id ada2fe7eead31-62adc184180mr209045137.17.1777503987036; Wed, 29 Apr 2026 16:06:27 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95cc4f4d418sm807065241.9.2026.04.29.16.06.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:06:26 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 31/37] GDB: testsuite: server: Don't return value from top-level (manual) Date: Wed, 29 Apr 2026 20:04:22 -0300 Message-ID: <20260429230432.60487-32-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch manually changes "return -1" statements that weren't caught by the sed command. These return statements return at top level but inside block such as save_vars and with_test_prefix. I also fixed one case of top-level "return 0". --- gdb/testsuite/gdb.server/abspath.exp | 2 +- gdb/testsuite/gdb.server/exit-multiple-threads.exp | 2 +- gdb/testsuite/gdb.server/ext-restart.exp | 2 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 2 +- gdb/testsuite/gdb.server/extended-remote-restart.exp | 2 +- gdb/testsuite/gdb.server/multi-ui-errors.exp | 2 +- gdb/testsuite/gdb.server/reconnect-ctrl-c.exp | 2 +- gdb/testsuite/gdb.server/wrapper.exp | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.server/abspath.exp b/gdb/testsuite/gdb.server/abspath.exp index 5bd7f7e842bb..7c4d43ff474d 100644 --- a/gdb/testsuite/gdb.server/abspath.exp +++ b/gdb/testsuite/gdb.server/abspath.exp @@ -36,11 +36,11 @@ save_vars { GDBFLAGS } { if { ![is_remote host] } { set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\"" } if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. diff --git a/gdb/testsuite/gdb.server/exit-multiple-threads.exp b/gdb/testsuite/gdb.server/exit-multiple-threads.exp index 1b0941eb3c78..c6e19f8dfb44 100644 --- a/gdb/testsuite/gdb.server/exit-multiple-threads.exp +++ b/gdb/testsuite/gdb.server/exit-multiple-threads.exp @@ -138,11 +138,11 @@ foreach_with_prefix test { exit signal } { set func "run_${test}_test" set executable "$binfile-${test}" if {[build_executable "failed to prepare" $executable $srcfile \ [list debug pthreads additional_flags=-D${def}]]} { - return -1 + return } set target_executable [gdb_remote_download target $executable] foreach_with_prefix multi_process { 0 1 } { diff --git a/gdb/testsuite/gdb.server/ext-restart.exp b/gdb/testsuite/gdb.server/ext-restart.exp index 39d42d7a4416..031aaeb5db85 100644 --- a/gdb/testsuite/gdb.server/ext-restart.exp +++ b/gdb/testsuite/gdb.server/ext-restart.exp @@ -29,11 +29,11 @@ save_vars { GDBFLAGS } { if { ![is_remote host] && ![is_remote target] } { set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\"" } if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp index 912a8ce37708..757127b15488 100644 --- a/gdb/testsuite/gdb.server/ext-wrapper.exp +++ b/gdb/testsuite/gdb.server/ext-wrapper.exp @@ -31,11 +31,11 @@ save_vars { GDBFLAGS } { if { ![is_remote host] && ![is_remote target] } { set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\"" } if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp index f10d2f374c09..a592dba79ed5 100644 --- a/gdb/testsuite/gdb.server/extended-remote-restart.exp +++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp @@ -40,11 +40,11 @@ require {is_any_target "*-*-linux*" "*-*-openbsd*"} # And we need to be able to reconnect to gdbserver. set gdbserver_reconnect_p 1 if { [info proc gdb_reconnect] == "" } { unsupported "requires gdbserver reconnect" - return 0 + return } standard_testfile if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/gdb.server/multi-ui-errors.exp index c17de8bf2e48..dde936c1a455 100644 --- a/gdb/testsuite/gdb.server/multi-ui-errors.exp +++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp @@ -35,11 +35,11 @@ save_vars { GDBFLAGS } { if { ![is_remote host] && ![is_remote target] } { set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\"" } if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} { - return -1 + return } } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp index 63502887bf55..c0e129db76d5 100644 --- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp +++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp @@ -31,11 +31,11 @@ save_vars { GDBFLAGS } { if { ![is_remote host] && ![is_remote target] } { set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\"" } if {[prepare_for_testing "failed to prepare" $testfile $srcfile]} { - return -1 + return } } set target_binfile [gdb_remote_download target $binfile] diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp index 15643fb92a7c..40c29c441fab 100644 --- a/gdb/testsuite/gdb.server/wrapper.exp +++ b/gdb/testsuite/gdb.server/wrapper.exp @@ -35,11 +35,11 @@ save_vars { GDBFLAGS } { if { ![is_remote host] && ![is_remote target] } { set GDBFLAGS "$GDBFLAGS -ex \"set sysroot\"" } if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected.