From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GQFTNAyR8mm9ZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:15:24 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=gIbOnyHk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D0D971E0BA; Wed, 29 Apr 2026 19:15:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 93B821E093 for ; Wed, 29 Apr 2026 19:15:23 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 327444BAE7CF for ; Wed, 29 Apr 2026 23:15:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 327444BAE7CF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=gIbOnyHk Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by sourceware.org (Postfix) with ESMTPS id EEE814358A79 for ; Wed, 29 Apr 2026 23:06:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEE814358A79 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEE814358A79 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::e2a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503984; cv=none; b=wrLpDlK8ORpOPYEjDuJ8A9VsZdkjePXKOb3P5PWjZzWFTK1kVXKv0/OE2ynLIbO/5c61jCS6TnEw0pSWabKo5TPjtzpTRHHQNZdVFp7j3dhrjx6h+U9o7TTUiNfS6PruBbGirY/4dSyR64x/FwWgku1c1x6hD/xyuDWfCIQ7YMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503984; c=relaxed/simple; bh=8a0afmV92UHfhIVeVpL4NH/QCQp8Jqzod588BAky7FE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ljCYk0ZFFy5StkHhW9gRxcoYR1i+Rm4weXo14FG+U0oRu/PrdDvLRYQydCPJ4CMvA1v63u2c9pmCDSqtTHtDxf9y39xJnZ+vDv3zJSsS1hl07R/2Js4Xn19g9FOfHpWnhboPQaajpLaH9ccgL+a2gnOhzCsDtGYLio8gmWRl/zo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEE814358A79 Received: by mail-vs1-xe2a.google.com with SMTP id ada2fe7eead31-61316792e42so168664137.2 for ; Wed, 29 Apr 2026 16:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503983; x=1778108783; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YLzkI72oGqGa6fsS/tE8ukjBHnjUL1OHV3ggr2JW4RY=; b=gIbOnyHkGt6A75e/A2g8r7gMykfvQA2JgTTRPzalbozw9+m8JKKkX8KnltMAhha4yy dkscFD6iUtpuYqMry4c0pp+e6XXNs2P1Ovgzp71Ujv0CdEG5MZH2+zFM9OgMqX9g8omP VwC1PISvgnwSTqjr5hgVJ8VEqj61385ybKZ4xu3bXeU2rudNuBO5su7SizRDqEAw/1QW 3olCHZgWO1MYPi1dxsfiWAWvlnqe2spXpgwxLyWjR5YUb8BD3UDCkystmr8ZR7JiKyLA cVGXUKMQgMdJgshl9ec5xpKtbmnMbqkuDcMoTz4XQjLagBvTnhhfKoGBn7cKDlsYWorl 0LaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503983; x=1778108783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YLzkI72oGqGa6fsS/tE8ukjBHnjUL1OHV3ggr2JW4RY=; b=Mr8Lv6nGEI43jGGGx8nV6cJn50E1am9mYp0OxRDJZEpu5SEsUZRDlL/NiP+m3cVJwx a5SyT64O0YSetaKs/80ZMdMeFQXhnzAeNzDf29hXviWkfB1A8XCUCB7athbHl8Rj+RJM hyahTc+HQ9xYq1R8oWxupWdX1cgGxEHmlMNkurjglIJjck9zLKJkn7jpLyhTZFAcObV/ eOXQjIqEiq5HPvOmggDmutDINvw9+WRwxvlW/M13Wf044fUEiJwPs30i2BeM2XG6QAsf 3whcGo2baGFLvRr0CUi1s61wmGPcwUJ0RdhyTnozpBE6ilxSdDvW/ZYqY/gtxh14E+iM F78g== X-Gm-Message-State: AOJu0YyV/y4IODKMhCdtpCJT6wF2vDsC0l5pRez1t+REfWgiYH0sbPCK mQKi5d+sHICs1qJHKNGpdK2WrsN+vkyn7Jp6YZ/EnnKR2z0DwgPuFX2gA6rNA99cGKup6rCHE2W 3cNP/ X-Gm-Gg: AeBDievsbIPBN+EAwzT+LSjrbrPMvRyUgSRGvGsMkkz56WZGXDVQoLOQO4NdFgT+RsG vPWA6kk1XNnhyiB5hjaZ4vlpMtjJarHr5AXevMEmB0f4zTwGj0YcR2TVzZcV7KwfUBJKf0Qxcwm V8oMAqNDbtQPZ0kd/yH7rU0ZELC8Xlf5EG+y1gfzy4Xn7rXtAf/U5i2xXx50ROaRawv1Rfap+oZ w28SwP2t45IEx88E24yM0hOXrIqQPmTEpRbNoYSqad15MWMXfwua5S9b454kMHcgZ6kieozASHW Mfv7VcmucRhG6zobEpUW1sNaqRajRCB5+vH6EPXlJwPhMmll4uF9FdAMitn8VQkJk3ymWymUVq5 pJz/oHrXGB60rew/KpYGfhUhg8C7BsIU6x4N5iMO3zBT6SjjzyZaFFyecVLW9Cs0mr5Kh8ME7i4 NW04zNznfiA0pIDRVSp5+5QZuALpkxMsgi99VmJdkSdotF X-Received: by 2002:a05:6102:554c:b0:604:f029:224c with SMTP id ada2fe7eead31-62ad223bf06mr287533137.8.1777503983079; Wed, 29 Apr 2026 16:06:23 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95cb7830468sm1841694241.13.2026.04.29.16.06.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:06:22 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 30/37] GDB: testsuite: server: Don't return -1 from top-level (sed) Date: Wed, 29 Apr 2026 20:04:21 -0300 Message-ID: <20260429230432.60487-31-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch is purely the result of running: $ sed -i 's/^ return -1/ return/' *.exp* inside gdb/testsuite/gdb.server. --- gdb/testsuite/gdb.server/build-id-seqno.exp | 4 ++-- gdb/testsuite/gdb.server/connect-stopped-target.exp | 2 +- gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp | 2 +- gdb/testsuite/gdb.server/connect-without-multi-process.exp | 2 +- gdb/testsuite/gdb.server/ext-attach.exp | 2 +- gdb/testsuite/gdb.server/ext-run.exp | 2 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 2 +- gdb/testsuite/gdb.server/extended-remote-restart.exp | 2 +- gdb/testsuite/gdb.server/file-transfer.exp | 2 +- gdb/testsuite/gdb.server/inferior-args.exp | 2 +- gdb/testsuite/gdb.server/monitor-exit-quit.exp | 2 +- gdb/testsuite/gdb.server/no-thread-db.exp | 2 +- gdb/testsuite/gdb.server/pread-offset-size.exp | 2 +- gdb/testsuite/gdb.server/remote-read-msgs.exp | 4 ++-- gdb/testsuite/gdb.server/run-without-local-binary.exp | 2 +- gdb/testsuite/gdb.server/server-connect.exp | 2 +- gdb/testsuite/gdb.server/server-exec-info.exp | 2 +- gdb/testsuite/gdb.server/server-kill-python.exp | 2 +- gdb/testsuite/gdb.server/server-kill.exp | 2 +- gdb/testsuite/gdb.server/server-mon.exp | 2 +- gdb/testsuite/gdb.server/server-pipe.exp | 2 +- gdb/testsuite/gdb.server/server-run.exp | 2 +- gdb/testsuite/gdb.server/solib-list.exp | 2 +- gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp | 2 +- gdb/testsuite/gdb.server/stop-reply-no-thread.exp | 2 +- gdb/testsuite/gdb.server/sysroot.exp | 2 +- gdb/testsuite/gdb.server/target-exec-file.exp | 4 ++-- gdb/testsuite/gdb.server/twice-connect.exp | 2 +- gdb/testsuite/gdb.server/wrapper.exp | 2 +- 29 files changed, 32 insertions(+), 32 deletions(-) diff --git a/gdb/testsuite/gdb.server/build-id-seqno.exp b/gdb/testsuite/gdb.server/build-id-seqno.exp index 44bdb09b60ad..1fa27e80aa0f 100644 --- a/gdb/testsuite/gdb.server/build-id-seqno.exp +++ b/gdb/testsuite/gdb.server/build-id-seqno.exp @@ -34,16 +34,16 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile] == -1} { - return -1 + return } # Split out BINFILE.debug. Remove debug from BINFILE. if {[gdb_gnu_strip_debug $binfile] != 0} { - return -1 + return } # Get the '.build-id/xx/xxx...xxx' part of the filename. set build_id_filename [build_id_debug_filename_get $binfile] diff --git a/gdb/testsuite/gdb.server/connect-stopped-target.exp b/gdb/testsuite/gdb.server/connect-stopped-target.exp index cfe38fcbfc6a..74ccd774561e 100644 --- a/gdb/testsuite/gdb.server/connect-stopped-target.exp +++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp @@ -24,11 +24,11 @@ require allow_gdbserver_tests standard_testfile set executable ${testfile} if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } proc do_test {nonstop} { global binfile global gdb_prompt diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp index fcdc6978d618..7e2b33e09a98 100644 --- a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp +++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp @@ -26,11 +26,11 @@ load_lib gdbserver-support.exp standard_testfile require allow_gdbserver_tests if { [build_executable "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } # Test connecting GDB to GDBserver without loading a symbol file. # # SYSROOT is the desired sysroot string diff --git a/gdb/testsuite/gdb.server/connect-without-multi-process.exp b/gdb/testsuite/gdb.server/connect-without-multi-process.exp index 4b41f461a79d..33787acded51 100644 --- a/gdb/testsuite/gdb.server/connect-without-multi-process.exp +++ b/gdb/testsuite/gdb.server/connect-without-multi-process.exp @@ -21,11 +21,11 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Test spawning gdbserver with a program, connect to it and run to # main, with both multiprocess extensions on and off. proc do_test {multiprocess} { diff --git a/gdb/testsuite/gdb.server/ext-attach.exp b/gdb/testsuite/gdb.server/ext-attach.exp index 0dd02c145ac4..cb4c12772289 100644 --- a/gdb/testsuite/gdb.server/ext-attach.exp +++ b/gdb/testsuite/gdb.server/ext-attach.exp @@ -25,11 +25,11 @@ standard_testfile require allow_gdbserver_tests require can_spawn_for_attach if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Run the test. TARGET_NON_STOP and TARGET_ASYNC should be 'on' # or 'off'. TO_DISABLE should be either the empty string, or # something that can be passed to gdbserver's --disable-packet command diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp index 83de771902b4..4fb2fe004f26 100644 --- a/gdb/testsuite/gdb.server/ext-run.exp +++ b/gdb/testsuite/gdb.server/ext-run.exp @@ -22,11 +22,11 @@ load_lib gdbserver-support.exp standard_testfile server.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } # allow_xml_test must be called while gdb is not running. set do_xml_test [allow_xml_test] diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp index 836c32a75745..912a8ce37708 100644 --- a/gdb/testsuite/gdb.server/ext-wrapper.exp +++ b/gdb/testsuite/gdb.server/ext-wrapper.exp @@ -20,11 +20,11 @@ load_lib gdbserver-support.exp standard_testfile wrapper.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to avoid # reading files via the remote protocol. diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp index 5fe4ebd57297..f10d2f374c09 100644 --- a/gdb/testsuite/gdb.server/extended-remote-restart.exp +++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp @@ -46,11 +46,11 @@ if { [info proc gdb_reconnect] == "" } { } standard_testfile if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Core of the test. DO_KILL_P controls whether we kill one of the # inferiors before reconnecting. And FOLLOW_CHILD_P controls whether # we follow the child or the parent at the fork. diff --git a/gdb/testsuite/gdb.server/file-transfer.exp b/gdb/testsuite/gdb.server/file-transfer.exp index f33c589c961e..a4517582b257 100644 --- a/gdb/testsuite/gdb.server/file-transfer.exp +++ b/gdb/testsuite/gdb.server/file-transfer.exp @@ -21,11 +21,11 @@ load_lib gdbserver-support.exp standard_testfile server.c require allow_gdbserver_tests if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. gdb_test "disconnect" ".*" diff --git a/gdb/testsuite/gdb.server/inferior-args.exp b/gdb/testsuite/gdb.server/inferior-args.exp index 312e756f0d80..f6ad3e69b407 100644 --- a/gdb/testsuite/gdb.server/inferior-args.exp +++ b/gdb/testsuite/gdb.server/inferior-args.exp @@ -33,11 +33,11 @@ if { $gdbserver == "" } { return } standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile]} { - return -1 + return } # EXTENDED_P is a boolean, when true gdbserver is started with --multi, and # GDB connects using extended-remote protocol. Otherwise, no --multi flag # is passed, and GDB connects with the remote protocol. diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite/gdb.server/monitor-exit-quit.exp index c5f8426cb5de..cb90169ef0cc 100644 --- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp +++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp @@ -22,11 +22,11 @@ load_lib gdbserver-support.exp standard_testfile server.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to avoid # reading files via the remote protocol. diff --git a/gdb/testsuite/gdb.server/no-thread-db.exp b/gdb/testsuite/gdb.server/no-thread-db.exp index e04e43c78a3c..9cbe962bc3c0 100644 --- a/gdb/testsuite/gdb.server/no-thread-db.exp +++ b/gdb/testsuite/gdb.server/no-thread-db.exp @@ -26,11 +26,11 @@ standard_testfile set unresolvable_thread_db_path "/foo/bar" require allow_gdbserver_tests if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { - return -1 + return } save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to avoid # reading files via the remote protocol. diff --git a/gdb/testsuite/gdb.server/pread-offset-size.exp b/gdb/testsuite/gdb.server/pread-offset-size.exp index 4362878c8e6e..68f938d42c67 100644 --- a/gdb/testsuite/gdb.server/pread-offset-size.exp +++ b/gdb/testsuite/gdb.server/pread-offset-size.exp @@ -22,11 +22,11 @@ require allow_gdbserver_tests standard_testfile .S if { [prepare_for_testing ${testfile}.exp $testfile \ $srcfile {debug additional_flags=-nostdlib} ] } { - return -1 + return } clean_restart gdb_test_no_output "set remote exec-file $binfile" \ diff --git a/gdb/testsuite/gdb.server/remote-read-msgs.exp b/gdb/testsuite/gdb.server/remote-read-msgs.exp index 86c2d610c00b..e9d03388e398 100644 --- a/gdb/testsuite/gdb.server/remote-read-msgs.exp +++ b/gdb/testsuite/gdb.server/remote-read-msgs.exp @@ -30,16 +30,16 @@ require {!is_remote host} standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile \ {debug build-id}] == -1} { - return -1 + return } # Split out BINFILE.debug. Remove debug from BINFILE. if {[gdb_gnu_strip_debug $binfile] != 0} { - return -1 + return } # Get the '.build-id/xx/xxx...xxx' part of the filename. set build_id_filename [build_id_debug_filename_get $binfile] diff --git a/gdb/testsuite/gdb.server/run-without-local-binary.exp b/gdb/testsuite/gdb.server/run-without-local-binary.exp index 3aa9eba2d05d..24521f21b0f9 100644 --- a/gdb/testsuite/gdb.server/run-without-local-binary.exp +++ b/gdb/testsuite/gdb.server/run-without-local-binary.exp @@ -18,11 +18,11 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests standard_testfile normal.c if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] # Test running GDB without providing a local binary for it. In order diff --git a/gdb/testsuite/gdb.server/server-connect.exp b/gdb/testsuite/gdb.server/server-connect.exp index bb6a5758d359..3c8dd114166a 100644 --- a/gdb/testsuite/gdb.server/server-connect.exp +++ b/gdb/testsuite/gdb.server/server-connect.exp @@ -26,11 +26,11 @@ require allow_gdbserver_tests # We want to have control over where we start gdbserver. require {!is_remote target} if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. gdb_test "disconnect" ".*" diff --git a/gdb/testsuite/gdb.server/server-exec-info.exp b/gdb/testsuite/gdb.server/server-exec-info.exp index 7163785348d9..4ef9ede9cec0 100644 --- a/gdb/testsuite/gdb.server/server-exec-info.exp +++ b/gdb/testsuite/gdb.server/server-exec-info.exp @@ -20,11 +20,11 @@ load_lib gdbserver-support.exp # are present. require allow_gdbserver_tests allow_shlib_tests standard_testfile server.c if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { - return -1 + return } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. gdb_test "disconnect" ".*" diff --git a/gdb/testsuite/gdb.server/server-kill-python.exp b/gdb/testsuite/gdb.server/server-kill-python.exp index 09e4d561bee9..7c08090c1656 100644 --- a/gdb/testsuite/gdb.server/server-kill-python.exp +++ b/gdb/testsuite/gdb.server/server-kill-python.exp @@ -25,11 +25,11 @@ standard_testfile multi-ui-errors.c require allow_gdbserver_tests allow_python_tests if {[build_executable "failed to prepare" ${testfile} \ ${srcfile}] == -1} { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] set host_binfile [gdb_remote_download host $binfile] diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 9a92ef2a6c75..d4bbb466f04c 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -23,11 +23,11 @@ load_lib gdbserver-support.exp standard_testfile require allow_gdbserver_tests if { [build_executable "failed to prepare" ${testfile}] } { - return -1 + return } # Spawn GDBserver, run to main, extract GDBserver's PID and save it in # the SERVER_PID global. diff --git a/gdb/testsuite/gdb.server/server-mon.exp b/gdb/testsuite/gdb.server/server-mon.exp index 8811a0c8afa7..ef054059faf8 100644 --- a/gdb/testsuite/gdb.server/server-mon.exp +++ b/gdb/testsuite/gdb.server/server-mon.exp @@ -22,11 +22,11 @@ load_lib gdbserver-support.exp standard_testfile server.c require allow_gdbserver_tests if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Make sure we're disconnected, in case we're testing with an # extended-remote board, therefore already connected. gdb_test "disconnect" ".*" diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.server/server-pipe.exp index ca9d9cab8b67..724e5a047b1e 100644 --- a/gdb/testsuite/gdb.server/server-pipe.exp +++ b/gdb/testsuite/gdb.server/server-pipe.exp @@ -40,11 +40,11 @@ if { $gdbserver == "" } { standard_testfile normal.c set executable ${testfile} if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Start GDB using remote type TARGET, which should be either "remote" # or "extended-remote". Check the output of 'info connections', and # the contents of the gdb.TargetConnection.details string. diff --git a/gdb/testsuite/gdb.server/server-run.exp b/gdb/testsuite/gdb.server/server-run.exp index 776851b36955..a20ef0a5a1fc 100644 --- a/gdb/testsuite/gdb.server/server-run.exp +++ b/gdb/testsuite/gdb.server/server-run.exp @@ -22,11 +22,11 @@ load_lib gdbserver-support.exp standard_testfile server.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to avoid # reading files via the remote protocol. diff --git a/gdb/testsuite/gdb.server/solib-list.exp b/gdb/testsuite/gdb.server/solib-list.exp index ab0fd1586cb1..c529bb6edd06 100644 --- a/gdb/testsuite/gdb.server/solib-list.exp +++ b/gdb/testsuite/gdb.server/solib-list.exp @@ -30,11 +30,11 @@ set srclibfile ${testfile}-lib.c set binlibfile [standard_output_file ${testfile}.so] if { [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfile}" "${binlibfile}" {debug}] != "" || [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "shlib=${binlibfile} build-id"] != "" } { untested "failed to compile" - return -1 + return } set interp_system [section_get ${binfile} .interp] verbose -log "system interpreter is: $interp_system" diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp index 01bf3ef67dca..a7eda3f76f06 100644 --- a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp +++ b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp @@ -32,11 +32,11 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile {debug pthreads}] == -1 } { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] # Run the tests with different features of GDBserver disabled. diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp index fec2246b4791..700b70224151 100644 --- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp +++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp @@ -24,11 +24,11 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile] == -1 } { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] # Run the tests with different features of GDBserver disabled. diff --git a/gdb/testsuite/gdb.server/sysroot.exp b/gdb/testsuite/gdb.server/sysroot.exp index 634168db4693..7e4a796e8791 100644 --- a/gdb/testsuite/gdb.server/sysroot.exp +++ b/gdb/testsuite/gdb.server/sysroot.exp @@ -22,11 +22,11 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile "additional_flags=--no-builtin"] == -1} { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] set host_binfile [gdb_remote_download host $binfile] diff --git a/gdb/testsuite/gdb.server/target-exec-file.exp b/gdb/testsuite/gdb.server/target-exec-file.exp index 7c204cc9abde..a9e6f801165d 100644 --- a/gdb/testsuite/gdb.server/target-exec-file.exp +++ b/gdb/testsuite/gdb.server/target-exec-file.exp @@ -24,11 +24,11 @@ load_lib gdbserver-support.exp require allow_gdbserver_tests !use_gdb_stub standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } clean_restart # Some boards specifically set the sysroot to the empty string to @@ -221,11 +221,11 @@ if { [allow_python_tests] } { sleep 1 set res [remote_exec target "touch $target_exec"] set status [lindex $res 0] if { $status != 0 } { fail "touching executable on target" - return -1 + return } # Start the inferior again, we expect to see the symbols being re-read # from the remote file. start_inferior "start inferior a third time" true diff --git a/gdb/testsuite/gdb.server/twice-connect.exp b/gdb/testsuite/gdb.server/twice-connect.exp index eaf910179f7f..45f2eb5aa596 100644 --- a/gdb/testsuite/gdb.server/twice-connect.exp +++ b/gdb/testsuite/gdb.server/twice-connect.exp @@ -21,11 +21,11 @@ standard_testfile require allow_gdbserver_tests if { [build_executable "failed to prepare" $::testfile $::srcfile \ {debug}] } { - return -1 + return } # Don't use $binfile arg, to make sure we use the remote file target:$binfile. clean_restart diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp index 9478640c40e2..15643fb92a7c 100644 --- a/gdb/testsuite/gdb.server/wrapper.exp +++ b/gdb/testsuite/gdb.server/wrapper.exp @@ -24,11 +24,11 @@ standard_testfile require allow_gdbserver_tests if { [istarget *-*-mingw*] || [istarget *-*-cygwin*] } { unsupported "gdbserver does not support --wrapper on this target (PR server/15967)" - return -1 + return } save_vars { GDBFLAGS } { # If GDB and GDBserver are both running locally, set the sysroot to avoid # reading files via the remote protocol.