From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yYs6IZuP8mm9ZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:09:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=XVRdtuPx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6F5471E0BA; Wed, 29 Apr 2026 19:09:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C37FD1E0BA for ; Wed, 29 Apr 2026 19:09:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 71E594358A5B for ; Wed, 29 Apr 2026 23:09:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71E594358A5B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=XVRdtuPx Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id D0ADE4BB589A for ; Wed, 29 Apr 2026 23:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0ADE4BB589A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D0ADE4BB589A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503980; cv=none; b=GjPPDgt0jLuAov5fliYwKJgdYs6QSaeau5iiSSfwO1jBQnPLoPahtrKLN/+lm7yTLkyejC4CUoyMqt7D1s+24dFBLC1K7MbWRMWhYH2h4uiQAnQb8eI1idz8QiL3pHPL3a1F06sibzKjtZHOGmkTIZOEmhZ+pW02QUTIxM4wOK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503980; c=relaxed/simple; bh=9SRDuqMt1PyWyklVUVebqmzDlRKVT9i16km8b7isTdY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kWrFzQLLaYIutbwLP5csHtcQgNBZi8OjCszRx3OHAMdOKLHqV8fEqVoBIHYFrQ+1r2GrvqjSmRZp48A5kpJY+Pvcny9kQwBdQwn02Jk6bJqrinb70jeUDVeIMmiD5w7GwPXxn6PWRrsOMJiSEiI6gakTDsLi/tZHctBuRN+2gXQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0ADE4BB589A Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-56a8e0ea02aso298571e0c.0 for ; Wed, 29 Apr 2026 16:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503980; x=1778108780; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ywjyD9CeuvTYp3upDgeqwjMwMYYzAZ5JiREE1LLFWQc=; b=XVRdtuPxp/pYjSWz+UQWwJ6mitE1TdPkPNej1KnTMfJ8lL35saQi2zosUBf1tChTiD gzCmajZ9KNoAr9rHPkOristwhTgzEMc1P/YSJN7qDtOx5o3vSnQM/MRjarM+566b9gC7 B+1tJXnBL9QfvmmNy19NzhIj7lOfhuaYbdMD9nD+tHGLGQBgG4F7UNXQm/2nC4qRtfm9 HZg6vusydhPA7Ovm9SQpOT3K+wpZA+gOQBQTBoALzEUfmNMKys0WQh7ilbtV4Ur1WeqP E79rBuRh5JruQfTOxdQt5X06cwav22s5ijxlq2IbffoNxzTxvjwYwiF98IOPGgF6ZWny wK2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503980; x=1778108780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ywjyD9CeuvTYp3upDgeqwjMwMYYzAZ5JiREE1LLFWQc=; b=N+Dqq7md48kE9oLDRdamhD10z7dR3psPuzFr1KU18fxufCorL9+kbSf0tLrmqu/Jf3 P97zndc5GDlkYEblwcCcTgj66bl7On4OcVRv44FZHU7CuNFAxwP3eCcP2wTCer+QJSwq ta1Edo9ojYJiAvAD9nL6GeuFJj5yv8/GCPa4d17r/7ywxzwR65wsX1IhEQb5ozXKoS/y re1wMP9exiZu/MZXYEECZ2rgvgkoD7WbCDyNHiSUtunWgu+5e/WQitC7fXHGfn5X7RTx QD5/ba8CdZ+3gMQcoxgl2xrDE2uAcAz2fA9vwTm5WxfPCse6JfKOJUglu81jsYSzb5D9 K92w== X-Gm-Message-State: AOJu0YzvfenCeOlsuoheju6/3fuTQx7QXs8pNvHPoKacdvTChJgfhHLa eAFtS8fwmIFZZL8/41lLxtWMEIUnnl/5jYuswNfTrOuExerZG0R0CkDz4wFkApEWPZ/cTEP6sj7 dF/mF X-Gm-Gg: AeBDiesp3jFkA8g8/v1I9dJoLyoZeaCPipYUDzKRzYQmT+QmoEa+Nt8oFqm1OQCJEXo VvXO44T6HjoMOmqCQaA1/yahL4YeHYPOK0+CFBovU/5ZGL6YpfZANZZHqAcPCOdyi1VnVeaef/q UZOp4DEyz7nbPi5WKQyQWby5/9S/jYSdA0UHYy5NYZDuGsfOMTYrFku9vCgCKnCzbY2h1AEhcoA Vzm41IXg/8wvtc0TMWhOPYW6LUTEPaHvDBBEjYDc9xtl/DbImC9Z6sdfVs409WH8qpptJVNTVmI +KvoES4rHIlVFpL/EQxbyigpUKjo5byxw4nc0PS+Bs/ToewLka55RyWn4O7VBnlkUy5wfS6SXuK GAgQ4oS4A8wLArvFs1s89QEMEx7QWsQSr3edxoc7rton75J+yGaf5NrtoTrymXuZcyvhmGZOhRa emZN+oCuBPqXfWevjQBTGuMFGpseRedm1EGoxE2JthAQQoEOsYtFWAbNE= X-Received: by 2002:a05:6122:490d:b0:56f:6add:9029 with SMTP id 71dfb90a1353d-573c9568354mr122458e0c.1.1777503980208; Wed, 29 Apr 2026 16:06:20 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-573b6b7d905sm2054570e0c.1.2026.04.29.16.06.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:06:19 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 29/37] GDB: testsuite: reverse: Don't return value from top-level (manual) Date: Wed, 29 Apr 2026 20:04:20 -0300 Message-ID: <20260429230432.60487-30-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch manually changes "return -1" statements that weren't caught by the sed command. It also changes a few "return 0" statements. These return statements fall into one of these criteria: - misaligned line, which is then fixed by this patch; - return at top level but inside block such as with_test_prefix, foreach_with_prefix, with_timeout_factor, gdb_test_multiple. --- gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp | 2 +- gdb/testsuite/gdb.reverse/func-map-to-same-line.exp | 2 +- gdb/testsuite/gdb.reverse/i386-sse-reverse.exp | 6 +++--- gdb/testsuite/gdb.reverse/maint-print-instruction.exp | 2 +- gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp | 2 +- gdb/testsuite/gdb.reverse/sigall-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/sigall-reverse.exp | 2 +- gdb/testsuite/gdb.reverse/singlejmp-reverse.exp | 4 ++-- gdb/testsuite/gdb.reverse/solib-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/solib-reverse.exp | 2 +- gdb/testsuite/gdb.reverse/until-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/until-reverse.exp | 2 +- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp index 19ebebf6a126..0432dd47cc08 100644 --- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp +++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp @@ -47,11 +47,11 @@ standard_testfile if { [prepare_for_testing "failed to prepare" "$testfile" $srcfile] } { return } if {![runto_main]} { - return 0 + return } if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" diff --git a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp index dd36528eb3ef..76febe312f58 100644 --- a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp +++ b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp @@ -131,10 +131,10 @@ standard_testfile .c foreach_with_prefix column_info_flag {column-info no-column-info} { set options [list debug $column_info_flag] if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ $options]} { - return -1 + return } run_tests } diff --git a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp index dc1308861e2c..3ed1d7e6fae2 100644 --- a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp @@ -62,11 +62,11 @@ gdb_test_multiple "continue" $test { -re " end sse_test .*\r\n$gdb_prompt $" { pass $test } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-sse-reverse - return -1 + return } } gdb_test "reverse-step" "xorps.*" "reverse-step to xorps" @@ -588,11 +588,11 @@ gdb_test_multiple "continue" $test { -re " end ssse3_test .*\r\n$gdb_prompt $" { pass $test } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-ssse3-reverse - return -1 + return } } gdb_test "info register xmm0" \ "xmm0 .*uint128 = 0x1f1e1d1c1b1a19181716151413121110.*" \ @@ -664,11 +664,11 @@ gdb_test_multiple "continue" $test { -re " end sse4_test .*\r\n$gdb_prompt $" { pass $test } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-sse4-reverse - return -1 + return } } gdb_test "reverse-step" "blendvps.*" "reverse-step to blendvps" diff --git a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp index ad8009b415a9..edf6ec081cdf 100644 --- a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp +++ b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp @@ -44,11 +44,11 @@ proc test_print { has_history level test_name } { } } } if { ![runto_main] } { - return 0 + return } #confirm that GDB doesn't go crazy if recording isn't enabled test_print false "" "print before starting to record" diff --git a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp index d34fe130e8e5..b175774aee4f 100644 --- a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp +++ b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp @@ -47,11 +47,11 @@ standard_testfile if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { return } if {![runto_main]} { - return 0 + return } if {[supports_process_record]} { # Activate process record/replay gdb_test_no_output "record" "turn on process record" diff --git a/gdb/testsuite/gdb.reverse/sigall-precsave.exp b/gdb/testsuite/gdb.reverse/sigall-precsave.exp index d8bc6dfaccfa..5ce7de0ea1fe 100644 --- a/gdb/testsuite/gdb.reverse/sigall-precsave.exp +++ b/gdb/testsuite/gdb.reverse/sigall-precsave.exp @@ -256,11 +256,11 @@ gdb_test_multiple "continue" "run to end of main" { send_gdb "continue\n" exp_continue } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } delete_breakpoints diff --git a/gdb/testsuite/gdb.reverse/sigall-reverse.exp b/gdb/testsuite/gdb.reverse/sigall-reverse.exp index 2dae1933d818..45bb49ecfebe 100644 --- a/gdb/testsuite/gdb.reverse/sigall-reverse.exp +++ b/gdb/testsuite/gdb.reverse/sigall-reverse.exp @@ -237,11 +237,11 @@ set thissig "ABRT" with_test_prefix "sig-test-1" { set record_instruction_kfail 0 foreach sig [lrange $signals 1 end] { test_one_sig $sig if { $record_instruction_kfail } { - return -1 + return } } } # The last signal (SIGTERM) gets handled slightly differently because diff --git a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp index 830292cd6669..dfa8ac179f07 100644 --- a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp +++ b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp @@ -22,17 +22,17 @@ if {[info exists COMPILE]} { # make check RUNTESTFLAGS="gdb.reverse/singlejmp-reverse.exp COMPILE=1" if { [build_executable_from_specs ${testfile}.exp $executable {} \ ${testfile}.c {debug optimize=-O2} \ ${testfile}-nodebug.c {optimize=-O2} \ ] == -1 } { - return -1 + return } } else { require is_x86_64_m64_target if { [build_executable ${testfile}.exp ${testfile} \ [list ${srcfile} ${srcfile2}] {}] == -1 } { - return -1 + return } } clean_restart $executable diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/gdb.reverse/solib-precsave.exp index ef3229c74927..cad30320048b 100644 --- a/gdb/testsuite/gdb.reverse/solib-precsave.exp +++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp @@ -78,11 +78,11 @@ gdb_test_multiple "continue" "run to end of main" { -wrap -re "Breakpoint .* end of main .*" { pass $gdb_test_name } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } gdb_test "record save $precsave" \ "Saved core file $precsave with execution log\." \ diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.exp b/gdb/testsuite/gdb.reverse/solib-reverse.exp index c5a610fcb391..b5f49fb72994 100644 --- a/gdb/testsuite/gdb.reverse/solib-reverse.exp +++ b/gdb/testsuite/gdb.reverse/solib-reverse.exp @@ -75,11 +75,11 @@ gdb_test_multiple "until $end_part_one" "run until end part one" { -wrap -re " end part one.*" { pass $gdb_test_name } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } gdb_test "reverse-step" " shr1 three .*" "reverse-step third shr1" gdb_test "reverse-step" " shr1 two .*" "reverse-step second shr1" diff --git a/gdb/testsuite/gdb.reverse/until-precsave.exp b/gdb/testsuite/gdb.reverse/until-precsave.exp index 411fc14fed27..075a87dc2d87 100644 --- a/gdb/testsuite/gdb.reverse/until-precsave.exp +++ b/gdb/testsuite/gdb.reverse/until-precsave.exp @@ -50,11 +50,11 @@ with_timeout_factor 20 { -wrap -re "Breakpoint .* set breakpoint 10a here .*" { pass $gdb_test_name } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } } # So can this, against gdbserver, for example. diff --git a/gdb/testsuite/gdb.reverse/until-reverse.exp b/gdb/testsuite/gdb.reverse/until-reverse.exp index 74703223c643..19ec2fee6b05 100644 --- a/gdb/testsuite/gdb.reverse/until-reverse.exp +++ b/gdb/testsuite/gdb.reverse/until-reverse.exp @@ -51,11 +51,11 @@ gdb_test_multiple "advance factorial" "" { -wrap -re "factorial .value=6..*$srcfile:$bp_location7.*" { pass $gdb_test_name } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } # At this point, 'until' should continue the inferior up to when all the # inner invocations of factorial() are completed and we are back at this