From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cZmnJq+O8mm9ZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:05:19 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Urtjr0he; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 97DFA1E0CA; Wed, 29 Apr 2026 19:05:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 64A2C1E093 for ; Wed, 29 Apr 2026 19:05:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A1CE94358A68 for ; Wed, 29 Apr 2026 23:05:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1CE94358A68 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Urtjr0he Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by sourceware.org (Postfix) with ESMTPS id 6FE7A4BB3BE4 for ; Wed, 29 Apr 2026 23:04:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FE7A4BB3BE4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FE7A4BB3BE4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503883; cv=none; b=Yc40Ab4uIXBUrf9iVYdZ50OTnf9b5mdOYsVC58zF2A1tudjnAiVfTQWX0snuZfJ5EmRUClt5of7ttjiHR4rzHFkL/oHc4IbjrbO/qLQuEuNUYht3DvGwKzb5cbxmLhzQaBeYO76Omiuyb0kJsEicdILMH3fjSUHrRLVL2lSiG3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503883; c=relaxed/simple; bh=4lRkJSCsBE2yJ7Tn+3xoWebL6Hh+GOW1jYSejhPLcoU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vKMRTmkyxkt4W6KWFeOTERP+ZFNSDCfjWaP+8YotjFWR542CDB/sm7sbxW3QVKpDvc0fUM+njAqkUd9cdj993e0VvCv4/gmS1hz0E2ezYVrGWete7Wh6Wi1jmjDhSTR2PBcmVaIpWn8BEKuDLqYVIoDNcKXVVuXanxpRb3GowTE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6FE7A4BB3BE4 Received: by mail-vk1-xa29.google.com with SMTP id 71dfb90a1353d-5675d609621so262508e0c.2 for ; Wed, 29 Apr 2026 16:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503883; x=1778108683; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lQ3Nh6ui+GH3cdPPCj7h7F9rr4qRwqsmIanpmgX7uG0=; b=Urtjr0he7cbK5MWmhMu0+NpKSXZIdzGSwAlpmlKx2vkgxNv/aM7Q0rezspltNdGCbb RArpKuGMkjo/dOikHdKnMhAhsGZMG7HMVvqBuJoL3ETMQyn7EeM7BJ32Qp/MdbN8chy0 nWFr6Mgb8X2PwvxOVRgdWek1XQIsVyp90UI3AqRhBba4kXuks8Xt6xWTcF18fcaxDNV6 LYgxbXyUerJrSyBzFQEJnWmp6NyL9esSfPPw67/wOHKeT42712f/iI+LuFg6XiXWf48x iTOvIGsD1mDF5EkL4Sim1MMaD99LjpL16kRwpstZGd+O1wWCXvF7DuVPmh8GTkoAm35N af7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503883; x=1778108683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lQ3Nh6ui+GH3cdPPCj7h7F9rr4qRwqsmIanpmgX7uG0=; b=HhuEEa/HHRMPL5I85SmiNf05hpupkre+wADaX+ZX780K8GgqcNIck07uFXbuF6nCBU CIn+dpJ4S+O846lgjqnpzYs3YbME8erQ9E4RAGGd60l3aV08wkZxeIGU+SZuPxm946qf AHu/wblJ8j9gAPJN0WdpoV03KTwB+NeI4CYRoMdTdCNYKudF/JopVdl0Mu5zXDCXrmmJ hM4oHM6zmlYugpmUzaasHnZfrnT7nus3Io71Nii5NNIMn1LtcN8xjpQ8fSZQ4mRvhVuS M54ccG4fRMYtlsX4KlSd62GaZMI7Ap0W0pPu9CatnA5TA0jVP36JCXc+tCqwHUOnDm7H Ketg== X-Gm-Message-State: AOJu0YyTAm9mIisTKARWHh+Dy/Y9ErO5j4jLOHVKP3prkfb+X1c1IwZc uyqFJAEryF8SCDj33kWYAbDZb5xlPhekb8Y0zlVZla/+6FFsQ8WTozQm2O26spFK+2F7j+YCHWV 8dyMG X-Gm-Gg: AeBDiesyZdThOPAEg+yZzGL6oP7PMTY1vnSn/UxkK9VbzH48bnckTv9MylnVqqam7nY UyejRSJWHHNcTLtx2GqsOXcEK5ifxAC8Whaq9b0jl/DjiE5/t5YZIVn8G+3tehRM+1MvomQQSoD detT7KYLKLUuzVfqSNYvjM03vqH3xgQXs5A5RqKDyAPdfoYNsZi4ebaMQqEwSuRNuqZLd6mJSoD ZA7w4KZuq7k6WBtQ1zk6UaitsPpf8qqxfNZjVjp3QioFikxugK4OiF6pGIl5zVlK+9QloJSf0KX 1iGyW09iMv3k/6jQwBORJmKFwByPW4s4Z+2VYgGy7b6GpyLEYFrGAspjXE4jtSu2L4Lns2u6cNX egpLYP2bBcEkI8uzFMcxdblYUXHeLivlHcZGDGSbzGte2XIhA77r5RWH7Gh4+dMRggj1IQHSINT rPx4BjGsAwNoYbOBWgO8WXlC6iKv66f0fclL0UBU3Wl8pE X-Received: by 2002:a05:6122:c82:b0:56c:ca03:b668 with SMTP id 71dfb90a1353d-573c9577ef4mr96286e0c.3.1777503882710; Wed, 29 Apr 2026 16:04:42 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-573b6b7d1f5sm2047650e0c.3.2026.04.29.16.04.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:04:41 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 02/37] GDB: testsuite: aarch64, arm: Don't return value from top-level (manual) Date: Wed, 29 Apr 2026 20:03:53 -0300 Message-ID: <20260429230432.60487-3-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch manually changes the "return -1" statements that weren't caught by the sed command. In aarch64-prologue.exp and arm-cmse-sgstubs.exp, this was caused by a misaligned line, which is now fixed. In aarch64-mte.exp, aarch64-non-address-bits.exp, arm-pthread_cond_timedwait-bt.exp and thumb2-it.exp this is because the return statements have extra indentation due to being inside with_test_prefix, save_vars or gdb_test_multiple blocks. --- gdb/testsuite/gdb.arch/aarch64-mte.exp | 6 +++--- gdb/testsuite/gdb.arch/aarch64-non-address-bits.exp | 2 +- gdb/testsuite/gdb.arch/aarch64-prologue.exp | 2 +- gdb/testsuite/gdb.arch/arm-cmse-sgstubs.exp | 2 +- gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp | 2 +- gdb/testsuite/gdb.arch/thumb2-it.exp | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.arch/aarch64-mte.exp b/gdb/testsuite/gdb.arch/aarch64-mte.exp index 4826041e330a..72d4bba72531 100644 --- a/gdb/testsuite/gdb.arch/aarch64-mte.exp +++ b/gdb/testsuite/gdb.arch/aarch64-mte.exp @@ -276,11 +276,11 @@ with_test_prefix "print command" { set ltag [get_ltag_from_ptr ${tagged_ptr_addr}] } if {$ltag == -1} { unresolved "unexpected tag value" - return -1 + return } set atag [expr {($ltag + 1) % 16}] set atag_hexnn [get_tag_nn $atag] @@ -333,18 +333,18 @@ gdb_test "continue" \ "display tag violation information" # Restart to execute the async tag fault test. with_test_prefix "async" { if {![runto_main]} { - return -1 + return } gdb_breakpoint "access_memory" if {[gdb_continue "access_memory"]} { fail "could not run to tagged memory test function" - return -1 + return } # Force a tag fault. gdb_test "memory-tag set-allocation-tag tagged_ptr 1 05" \ $atag_msg \ diff --git a/gdb/testsuite/gdb.arch/aarch64-non-address-bits.exp b/gdb/testsuite/gdb.arch/aarch64-non-address-bits.exp index 8066b2035e1b..595dcb4f2ce1 100644 --- a/gdb/testsuite/gdb.arch/aarch64-non-address-bits.exp +++ b/gdb/testsuite/gdb.arch/aarch64-non-address-bits.exp @@ -54,11 +54,11 @@ gdb_test_multiple "ptype \$pauth_cmask" "fetch PAC cmask" { } -re -wrap "type = void" { } -re ".*$gdb_prompt $" { fail $gdb_test_name - return 1 + return } } # Value of the cmask register. set cmask 0 diff --git a/gdb/testsuite/gdb.arch/aarch64-prologue.exp b/gdb/testsuite/gdb.arch/aarch64-prologue.exp index c6fe2e262a5e..509fd31e8b4f 100644 --- a/gdb/testsuite/gdb.arch/aarch64-prologue.exp +++ b/gdb/testsuite/gdb.arch/aarch64-prologue.exp @@ -21,11 +21,11 @@ standard_testfile if { [prepare_for_testing "failed to prepare" $testfile $srcfile {nodebug}]} { return } if {![runto_main]} { - return -1 + return } # Ensure gdb can break at excessiveprologue then continue. gdb_breakpoint "excessiveprologue" gdb_continue_to_breakpoint "excessiveprologue" diff --git a/gdb/testsuite/gdb.arch/arm-cmse-sgstubs.exp b/gdb/testsuite/gdb.arch/arm-cmse-sgstubs.exp index c2ecaffd1d2c..188ee1a913c4 100644 --- a/gdb/testsuite/gdb.arch/arm-cmse-sgstubs.exp +++ b/gdb/testsuite/gdb.arch/arm-cmse-sgstubs.exp @@ -21,11 +21,11 @@ standard_testfile if { [prepare_for_testing "failed to prepare" $testfile $srcfile ]} { return } if {![runto_main]} { - return -1 + return } gdb_test "si" "0x.*" "branch to func from main" gdb_test "ni" "0x.*" "next instruction in func" diff --git a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp index 85ca6e78210f..02ae70095170 100644 --- a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp +++ b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp @@ -32,11 +32,11 @@ if { [build_executable "failed to prepare" ${testfile} ${srcfile} \ } save_vars { GDBFLAGS } { append GDBFLAGS " --readnever" if { [clean_restart $testfile] == -1 } { - return -1 + return } } if { ![runto_main] } { return diff --git a/gdb/testsuite/gdb.arch/thumb2-it.exp b/gdb/testsuite/gdb.arch/thumb2-it.exp index 0c9246b2131e..9ffcc6e1e3b9 100644 --- a/gdb/testsuite/gdb.arch/thumb2-it.exp +++ b/gdb/testsuite/gdb.arch/thumb2-it.exp @@ -33,11 +33,11 @@ if {![runto_main]} { # Make sure that the compiler options allow Thumb-2. gdb_test_multiple "list" "list main" { -re ".*@ No Thumb-2.*$gdb_prompt $" { pass "list main" untested "skipping tests due to lack of Thumb-2" - return -1 + return } -re ".*@ Thumb-2 OK.*$gdb_prompt $" { pass "list main" } }