From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ge6QBPOO8mm9ZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:06:27 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sY8dl25l; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0C44B1E0BA; Wed, 29 Apr 2026 19:06:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8944D1E0B1 for ; Wed, 29 Apr 2026 19:06:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 274AF4BB3BD0 for ; Wed, 29 Apr 2026 23:06:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 274AF4BB3BD0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=sY8dl25l Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 9866B4358A5B for ; Wed, 29 Apr 2026 23:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9866B4358A5B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9866B4358A5B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::a30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503917; cv=none; b=VlzQQtekXS5oUmeWrOApiXNgXq92Jsg3SsGh2kRvCtvfcWT5eI1rdelpU/85VXu1ZN5xXDirw/CEclnySsEek2pi0UAiGj2795CFFoL2mCVdTUH10+qG9JWCAsDXN5kChGAXINxrSr83nidQ+SZi0mwOMRWAQCVQldryorWzeIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503917; c=relaxed/simple; bh=XFY7Bbbucvxagq4gQoQcRe9nCUlvsQYNlmMwzAPBxQc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JE9IQxUNsFPfMBB6DVgzMbLpAtm+j7QGyX1iWtu2+wbN5gLSb+e1XMYqSh+J3U/fO9voj6TDSGSYTPZG8yHIn67s8PWGLNARM7vTWGf5nBseQDAsucI8W9JDICGrtS6u8zT8hfHcTaxuI37SVZYqWiivPliIez/E/IfP7QR24v8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9866B4358A5B Received: by mail-vk1-xa30.google.com with SMTP id 71dfb90a1353d-56f3e6bbecdso115159e0c.2 for ; Wed, 29 Apr 2026 16:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503917; x=1778108717; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pdJUlCur7UqlIrvrFi6XN6hY4duIIahDuy9OP+BaKsY=; b=sY8dl25lLACCHWdGhk9+Wxf9QazOGjmo7mPdDIm7GlyI+VXIh5r+7/qyy1CzLESN7x 18th5R06dYdIX+SB3H0lOIo119T/9wYHCCNpe9WAWi68V/AtD+3Dfdzj6/csklPHpp8a mEiOL/JezH/Eraw1ngjdTuWHRDdmcbZlxcOFinzJ5XY5xPTWpMPsuJw1wOtKFYuwxuRQ GWganthIEpychHPnL6UA3Npbb9xw9pAEJZXrBL8HzKmhe69nUOh2ACOxZD/sXAxUt6Ue TM4oyG1iUpHqeEwRzV3WnNEc965dLAqTYJ06VXRn+x1HeOWJwVpOC5z7/bsMc3g2hRPC //Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503917; x=1778108717; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pdJUlCur7UqlIrvrFi6XN6hY4duIIahDuy9OP+BaKsY=; b=kgpHjbFfQMgioFeSk6uVezaudLkdpEEdaM+np7ev31NOFwJbcWcZrmI7u402vQYEtK ws+a1QEHkM2XQSLLquxfSBm7cFJKERGEVrffu8DRcRkklOOrDISpTS4zo7hdnefXMCe8 TWfVpr5sRq6RLf3vw3ophb1tuYqXgL7e1u1TJ3PcZKn9rvZoel3gO3LCihUIypk8wDvO MD/rqzFICJsix6Jj4LU9GvBHLdw4QNCrQmLoZsriOUkKN12R4+5hkHDeEIa5URU6fNtf agxhETLR00r3lbuvxVjIBRWhmJ+PvtNJzPsfWTanjTnUuc4HN5XcAo/SIzvx4bTDDKO+ e1wQ== X-Gm-Message-State: AOJu0YyqVq5DsYINPrS81egjGiB8/nel7Kdh94rinDZfFGRPUlrNiiAL LWrygeEquJ9wXihQ2TFlZOngGQs8NNs8V26ddwlwHY96uPDJYd1DmmgpLgD8t1XwbrTsNCz0HLj aBbfD X-Gm-Gg: AeBDievUfH9Mppe7w0OXqHFJQVp6fhqG/noj4xjKaxRpo8smQGnQqZSrqJ6+LrGo6sm AAoS8L7ho6/ZjzTCNVRGpNOBPMtD9UvfjVHgtCM/zIWf7GGiNqY6hnSmm5VMKluinSTFEmRjmH9 6XXH6xkl/KpPuv2byc++EZGYUPrJbupUOz7cjpPIOxuCw7EmNt3fwSoS7Cy451De2l4S8o5v/KR BaVI+Q1LVgJ8A+ZPV4GNmVMTlwRa6jui9rzPb/6B+JMFMinLA7fX244wI12h7+o7XHmLkQFiVQz zeT2QHUeaZR0h0hOwtEHMwtOFwv4g7HPHZ79zG6C2g19hTenx1CSr3N6FovsRRoSB02xjBlqDPO pIZ6mJDdZjcFDBKiifF439mXlOMXHnpxRfQHw/HPkcbZkqCPXXVselSUJl+hNU6ezS+z0G8o3tE mPoN9XcPOpKpty3ltTc4Ff+V9HXpdMXruOj0nEfGvKyNJa X-Received: by 2002:a05:6122:e266:b0:56b:5e7e:d3fa with SMTP id 71dfb90a1353d-573c9607b49mr89951e0c.7.1777503916948; Wed, 29 Apr 2026 16:05:16 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95cb717d119sm1911173241.0.2026.04.29.16.05.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:05:16 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 12/37] GDB: testsuite: Don't return value from top-level in multi-arch tests Date: Wed, 29 Apr 2026 20:04:03 -0300 Message-ID: <20260429230432.60487-13-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Oddly enough, there are multi-arch arch tests. This patch contains fixes for them. Some changes are the result of running: $ sed -i 's/^ return -1/ return/' *.exp inside gdb/testsuite/gdb.arch and the others are manual changes. --- gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp | 6 +++--- gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp | 14 +++++++------- gdb/testsuite/gdb.arch/skip-prologue.exp | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp b/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp index 7d26244129ce..87440a1b28e8 100644 --- a/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp +++ b/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp @@ -21,15 +21,15 @@ require support_displaced_stepping # Some targets have leading underscores on assembly symbols. set additional_flags [gdb_target_symbol_prefix_flags] if {[prepare_for_testing "failed to prepare" $executable $srcfile \ [list debug $additional_flags]]} { - return -1 + return } if {![runto_main]} { - return -1 + return } # Read function name from testcases[N]. proc read_testcase { n } { @@ -47,11 +47,11 @@ proc read_testcase { n } { } set n_testcases [get_integer_valueof "n_testcases" 0] if { ${n_testcases} == 0 } { untested "no instruction relocation to test" - return 1 + return } # Set a fast tracepoint on each set_point${i} symbol. There is one for # each testcase. for { set i 0 } { ${i} < ${n_testcases} } { incr i } { diff --git a/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp b/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp index 0846e0365d42..06eb5a691bdf 100644 --- a/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp +++ b/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp @@ -19,20 +19,20 @@ standard_testfile insn-reloc.c # Some targets have leading underscores on assembly symbols. set additional_flags [gdb_target_symbol_prefix_flags] if {[prepare_for_testing "failed to prepare" $testfile-no-ipa $srcfile \ [list debug $additional_flags]]} { - return -1 + return } if {![runto_main]} { - return -1 + return } if {![gdb_target_supports_trace]} { unsupported "target does not support trace" - return -1 + return } require allow_in_proc_agent set libipa [get_in_proc_agent] @@ -41,24 +41,24 @@ set libipa [get_in_proc_agent] # file unused because linking not done" when building the object. if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ executable [list debug $additional_flags shlib=$libipa] ] != "" } { untested "failed to compile" - return -1 + return } clean_restart $testfile set remote_libipa [gdb_load_shlib $libipa] if {![runto_main]} { - return 0 + return } gdb_reinitialize_dir $srcdir/$subdir if { [gdb_test "info sharedlibrary" ".*[file tail $libipa].*" "IPA loaded"] != 0 } { untested "could not find IPA lib loaded" - return 1 + return } # Read function name from testcases[N]. proc read_testcase { n } { @@ -77,11 +77,11 @@ proc read_testcase { n } { set n_testcases [gdb_readexpr "n_testcases"] if { ${n_testcases} == 0 } { untested "no instruction relocation to test" - return 1 + return } # Set a fast tracepoint on each set_point${i} symbol. There is one for # each testcase. for { set i 0 } { ${i} < ${n_testcases} } { incr i } { diff --git a/gdb/testsuite/gdb.arch/skip-prologue.exp b/gdb/testsuite/gdb.arch/skip-prologue.exp index c805356d8746..c53f86250c84 100644 --- a/gdb/testsuite/gdb.arch/skip-prologue.exp +++ b/gdb/testsuite/gdb.arch/skip-prologue.exp @@ -17,11 +17,11 @@ standard_testfile if { [prepare_for_testing "failed to prepare" $testfile $srcfile \ {nodebug}] } { - return -1 + return } proc do_test { f } { set bp_addr "" gdb_test_multiple "break $f" "" {