From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ATrwB9yO8mnTZgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 19:06:04 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=O00hrFIM; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1C7C01E0BA; Wed, 29 Apr 2026 19:06:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C59011E0B1 for ; Wed, 29 Apr 2026 19:06:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 946444358A5E for ; Wed, 29 Apr 2026 23:06:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 946444358A5E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=O00hrFIM Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id 7E7EC4358A66 for ; Wed, 29 Apr 2026 23:05:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E7EC4358A66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7E7EC4358A66 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::e29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503913; cv=none; b=Mpr7NXJUtkwmKUzJ4+8NKYtxTIrd7dgch13h9/U6FDp+hvZ4sU9A1gDMmEy4aLjoKYgLk3eA/yW5eA7fIqMEvo56UqzIlBL3iI0nBEl8Zz2OI1js3VRPthcvShXIf66fn++hjfJj+vRiHQQ/J1+FM3TFC2vyQsUUlOVPIq3aBNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777503913; c=relaxed/simple; bh=2/33fmdHq/LyFU7QZRpIq3HBdDuT9YeMlQlW4GYtZkw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iBNLfzd8aQdBBWnSB9ce5sakivssvPn4NuxaFh1Kd0xQl5t8Kcb5vfjkrcfM2WSvlf0XTb7ZDq7stu5jLeLHqBjJmZBBL6ss/OJYrjM6soOAryq1pclq8mfNUmfRnGSj+rdxLWOeQdV+j4y0SxFqqZetjjFvFXfsZmq6OVM8+TM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7E7EC4358A66 Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-6201fc9ac0eso111433137.0 for ; Wed, 29 Apr 2026 16:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777503913; x=1778108713; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Hi/hkKrCEXrIeTd/C2k2JXJsD4G+TxWpG+We4XAIuHo=; b=O00hrFIMvAIhRQdaISfqvrinSKY41bY77r79DmtBEdA0IdUS5cDeBr34vWcO0bgIas /QFtc+xKgSWJ+423cDW8CIo06lMTf+BErbSUwMXtcZshK3lTIx9bXt4D/U0H1gR2vD9V pEY4IGm5jYwk5FBp4DEc2tGUUqXm/uF9bvF/lIE9zNbUKxNoTnzo59IB7dAvF3CcChWU hs/LdPnqZd1TJenq5ASbcF/Vo0s/zyGMkxv6t9W2PF13X3WpXRj99pSl7byoCzi95/ZQ fsi764ZFLmU2EOcnICVo9F3WAymkwatEo69i6dABxkcyHS1YGnP3nFHOSs8so+jAEqLE zpqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777503913; x=1778108713; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Hi/hkKrCEXrIeTd/C2k2JXJsD4G+TxWpG+We4XAIuHo=; b=iVaUMwyuJljAKyUpYDC3lf9a/NRxx9vbsGmC4YfDrVL1wC74iyBxKbMTwLTHfs7ks9 8/6HH+u+/P+5KtpzeCjlAvkXXHQ20GOFwtOuQlhvEm5CH5PJE71ZMAOuD1unr1zhJW4m sroFc1x3IIuLkFIMO9l1is1Y0ATQC7NAsza+qlkpB3zkWZGNwuvZVlbRLBzF57wkE0CF WZKI3iXg+y6jSNY1slNAIz7VBdVp9VyYl5oL51g1fnQCZt8S7YurCCmiuaC9vM2g6zto AnK3YFJPy4KX8IpS+hrSViaAkHrOvothb0hBpr9a2t6hE5hJDSu/23FA6QwAbaWmh8kK G+kQ== X-Gm-Message-State: AOJu0YyzX4WshE/wQHNlZTLju25Cd/WqULzofZKGx5e1oaCp6YtCjucB 3Sr0RUCiK7pvyQGCv8DUokzoetuYGc3xKf1THIel5DkDmO5UpuvWQTQctoVXTBhBB4pl1LZnd5v JZ/Iy X-Gm-Gg: AeBDieu81fIWQMo78qAxGqhc+zTdVOlt/dKk6x88i8vRCHRKcYjVfk1M5iwDCIHPHEb LIuD5l9ApbNzHRjsCftsQT8J2VqG4m88Oxfv3MTX9ic0o5DdC/dluYxeHJORWei0+vWvRl9Ip9t exBITqFZTYV0Fe3ugKs7ln6/Mp5ab/oj2rFjHx9HQSx1u0x16OPJ6TRPPbDjGRUq29QZuEyKLSN rUYUY9aPYhYnyO7KKiR4yW1dXwob1ApKLNFVSDmLlXZhi2uNPoGcSmNgMWjPBI2LZN/oGskZ4r6 zFLcYsmgcpv8EH09WvRbDbrKGe2pHf9ohgsOLcE2Hy3Xu4azMCieIsfI0gSWtLWl3S/ZK174ejh SICHyGyiM4RrPbN26pxVNcSnKfjzSL3q2RDTJimXhlkm2GecsdtBbGf9WnNMCgeS+6BdbKRqbm/ XEEaq1sfhZdDpDTTmDwOsmwjUD/Tsm4dYOkbInKNtzrDfd X-Received: by 2002:a05:6102:f9b:b0:608:9a34:c8ea with SMTP id ada2fe7eead31-62ad2344c5amr307441137.10.1777503912833; Wed, 29 Apr 2026 16:05:12 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-62982736ba5sm2025724137.5.2026.04.29.16.05.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:05:12 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH v2 11/37] GDB: testsuite: Don't return value from top-level in tests of various arches Date: Wed, 29 Apr 2026 20:04:02 -0300 Message-ID: <20260429230432.60487-12-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260429230432.60487-1-thiago.bauermann@linaro.org> References: <20260429230432.60487-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch contains fixes for alpha, arc, avr, hppa and sh architectures. Some changes are the result of running: $ sed -i 's/^ return -1/ return/' *.exp and $ sed -i 's/^ return 0/ return/' *.exp inside gdb/testsuite/gdb.arch and some are manual changes. I didn't include changes made to return statements inside procedures. --- gdb/testsuite/gdb.arch/alpha-step.exp | 2 +- gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 4 ++-- gdb/testsuite/gdb.arch/arc-dbnz.exp | 4 ++-- gdb/testsuite/gdb.arch/arc-decode-insn.exp | 4 ++-- gdb/testsuite/gdb.arch/avr-flash-qualifier.exp | 10 +++++----- gdb/testsuite/gdb.arch/gdb1291.exp | 4 ++-- gdb/testsuite/gdb.arch/gdb1431.exp | 4 ++-- gdb/testsuite/gdb.arch/gdb1558.exp | 2 +- gdb/testsuite/gdb.arch/pa-nullify.exp | 8 ++++---- 9 files changed, 21 insertions(+), 21 deletions(-) diff --git a/gdb/testsuite/gdb.arch/alpha-step.exp b/gdb/testsuite/gdb.arch/alpha-step.exp index a15f86ea6567..d47b359c08d1 100644 --- a/gdb/testsuite/gdb.arch/alpha-step.exp +++ b/gdb/testsuite/gdb.arch/alpha-step.exp @@ -20,11 +20,11 @@ set testfile "alpha-step" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {}] != "" } { unsupported "failed to compile" - return -1 + return } clean_restart gdb_load $binfile diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp index 01699016dd67..693e5efe2260 100644 --- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp +++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp @@ -24,15 +24,15 @@ standard_testfile .S # debug information (which does not exist for .S code!) instead of analyzing # frames manually. set options {} if { [prepare_for_testing "failed to prepare" $testfile $srcfile $options] } { - return -1 + return } if {![runto_main]} { - return 0 + return } # Convert list of saved registers and their offsets to a GDB string. proc saved_regs_to_str { savedregs funcname } { set str "" diff --git a/gdb/testsuite/gdb.arch/arc-dbnz.exp b/gdb/testsuite/gdb.arch/arc-dbnz.exp index ce93a6202933..2c091e45ecf1 100644 --- a/gdb/testsuite/gdb.arch/arc-dbnz.exp +++ b/gdb/testsuite/gdb.arch/arc-dbnz.exp @@ -32,15 +32,15 @@ require {istarget "arc*-*-*"} standard_testfile .S if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { - return -1 + return } if {![runto_main]} { - return 0 + return } gdb_test "break dbnz1" \ "Breakpoint $decimal at .*" \ "set breakpoint on the 1st dbnz" diff --git a/gdb/testsuite/gdb.arch/arc-decode-insn.exp b/gdb/testsuite/gdb.arch/arc-decode-insn.exp index 0a7582d03a2a..4247c0215b82 100644 --- a/gdb/testsuite/gdb.arch/arc-decode-insn.exp +++ b/gdb/testsuite/gdb.arch/arc-decode-insn.exp @@ -34,15 +34,15 @@ require {istarget "arc*-*-*"} standard_testfile .S if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { - return -1 + return } if {![runto_main]} { - return 0 + return } # Helper function that reads properties of instruction from the ELF file via # its symbols and then confirms that decoder output aligns to the expected # values. diff --git a/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp b/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp index a62e629f9209..e9a523a5d05a 100644 --- a/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp +++ b/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp @@ -20,22 +20,22 @@ require {istarget "avr*"} # The __flash qualifier was added in GCC 4.7. if {[test_compiler_info {gcc-[0-4]-[0-6]}]} { - verbose "Skipping ${gdb_test_file_name}." - return + verbose "Skipping ${gdb_test_file_name}." + return } standard_testfile if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} { - return -1 + return } if {![runto [gdb_get_line_number "break here."]]} { - untested "could not run to \"break here.\"" - return -1 + untested "could not run to \"break here.\"" + return } gdb_test "print pointer_to_flash" \ " = $hex .*" diff --git a/gdb/testsuite/gdb.arch/gdb1291.exp b/gdb/testsuite/gdb.arch/gdb1291.exp index 82f9d52e08ba..ba4b88d75112 100644 --- a/gdb/testsuite/gdb.arch/gdb1291.exp +++ b/gdb/testsuite/gdb.arch/gdb1291.exp @@ -28,22 +28,22 @@ require {istarget "sh-*-*"} set testfile "gdb1291" set srcfile ${testfile}.s set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ""] != "" } { untested "failed to compile" - return -1 + return } clean_restart gdb_load $binfile # # Run to `main' where we begin our tests. # if {![runto_main]} { - return 0 + return } gdb_test "b sub1" "Breakpoint 2.*" "set breakpoint" gdb_test "c" "Breakpoint 2.* sub1 .*" "get to sub1" diff --git a/gdb/testsuite/gdb.arch/gdb1431.exp b/gdb/testsuite/gdb.arch/gdb1431.exp index 89952275d193..aedf66183186 100644 --- a/gdb/testsuite/gdb.arch/gdb1431.exp +++ b/gdb/testsuite/gdb.arch/gdb1431.exp @@ -30,22 +30,22 @@ require {istarget "sh-*-*"} set testfile "gdb1431" set srcfile ${testfile}.s set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ""] != "" } { untested "failed to compile" - return -1 + return } clean_restart gdb_load $binfile # # Run to `main' where we begin our tests. # if {![runto_main]} { - return 0 + return } gdb_test "advance sub1" "hello world\r\n$hex in sub1 \\(\\)" "get to sub1" gdb_test "advance sub2" "$hex in main \\(\\)" "advance returns from sub1 frame" gdb_test "advance sub2" "$hex in sub2 \\(\\)" "get to sub2" diff --git a/gdb/testsuite/gdb.arch/gdb1558.exp b/gdb/testsuite/gdb.arch/gdb1558.exp index 5fbf86f5889a..7a3f44756452 100644 --- a/gdb/testsuite/gdb.arch/gdb1558.exp +++ b/gdb/testsuite/gdb.arch/gdb1558.exp @@ -27,11 +27,11 @@ set testfile "gdb1558" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} # Note we have to compile WITH optimization and WITHOUT debugging information to expose the bug. if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {"additional_flags=-O2"}] != "" } { untested "failed to compile" - return -1 + return } clean_restart gdb_load $binfile diff --git a/gdb/testsuite/gdb.arch/pa-nullify.exp b/gdb/testsuite/gdb.arch/pa-nullify.exp index 1606d44afbf1..e527fe0955d8 100644 --- a/gdb/testsuite/gdb.arch/pa-nullify.exp +++ b/gdb/testsuite/gdb.arch/pa-nullify.exp @@ -35,11 +35,11 @@ set srcfile ${testfile}.s set binfile ${objdir}/${subdir}/${testfile} set gcorefile ${objdir}/${subdir}/${testfile}.gcore if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {}] != "" } { unsupported "failed to compile" - return -1 + return } clean_restart gdb_load $binfile @@ -85,11 +85,11 @@ proc get_addr_of_sym { sym } { return $addr } if {![runto_main]} { - return 0 + return } set foo [get_addr_of_sym "foo"] set bar [get_addr_of_sym "bar"] set foo_last "(bar - 4)" @@ -121,21 +121,21 @@ proc test_core_bt { test } { gdb_test "backtrace" ".*in foo.*in main.*" "$test: backtrace in gcore" } set test "core at last insn in foo" if {![runto_main]} { - return 0 + return } gdb_breakpoint "*$foo_last" gdb_test "continue" "Breakpoint \[0-9\]*,.* in foo.*" "$test: continue to breakpoint" if {[gen_core $test]} { test_core_bt $test } set test "core at nullified insn" if {![runto_main]} { - return 0 + return } gdb_breakpoint "*$foo_last" gdb_test "continue" "Breakpoint \[0-9\]*,.* in foo.*" "$test: continue to breakpoint" gdb_test "stepi" ".*in foo.*" "$test: step to nullified instruction" if {[gen_core $test]} {