From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SeRrJjVn8mmGNgQAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 16:16:53 -0400 Received: by simark.ca (Postfix, from userid 112) id 9A7501E0BA; Wed, 29 Apr 2026 16:16:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F8D31E093 for ; Wed, 29 Apr 2026 16:16:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C4A7A4B920DB for ; Wed, 29 Apr 2026 20:16:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4A7A4B920DB Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by sourceware.org (Postfix) with ESMTPS id 1DE0C4BBCDBD for ; Wed, 29 Apr 2026 20:15:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DE0C4BBCDBD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DE0C4BBCDBD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777493752; cv=none; b=MPDv4wDBKyN4cuTkHHkgdpfZPBeCP7bb5/OvMFkWmZHdkj+q4erQXLIFT1q4wXH7L52MxC9N1SMSPTJWNHVgbc6IxBTYmQltosQ1VXaBUyEgrksRL2E3vbuvu7ftOnE7iJiVjzYg+5cxVPy0TDPbWe3+dvCaWPbTMqW+uE2ETGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777493752; c=relaxed/simple; bh=qNXsrCA61FjwODXTV8/EdYme7Vmk9X8nf9fKqt9XBoQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=VpDT6WBmIyXLkuxJHGz1emDTJK3MedB3gyTdoSWIedpmyTP80mJ2cydMBRXf+sx17MkUCMvllDDUQj6MKUYBS7vXhRHxxr0yIB+1HwdGUIVEnpRnUqjxxoe3IONNuO2S620bJcAaEpCxs1PRVQnZKUX6wJkeTgeIA0MCu/Qhx3A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DE0C4BBCDBD Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43fe8bda8e9so124887f8f.1 for ; Wed, 29 Apr 2026 13:15:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777493751; x=1778098551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NRu0PdX12SmCqMJtmAR1f37eBq7r03k5gOnILbY/sVk=; b=aNaIsL/ayI744ps6h2SSRe7V0jlpWa9LwX98KoMJ6wg8glAFeo8pIqS2XG1CdgfDdq E5Qeu2DyyAzmJn9be/q+4DdadneAjPGJqH147pqDq6iqUh6heT283lE6GfK1uoUEe4yi CHgHSi6ccT9c6if2Y39bOBEy/cpKmJCU8FmeN2ioKSTiHQ2EDD3o1BXUBUtatvbeZRaQ 6kRSI9WHxGzYC7+FWUFOeO1hodw2BEukk28FJhYDeeepmI96+zX6F+olcANFV0fXeDLv P2oRdn0vEodqVt15WSp4bNVdkvFbjEhGEEHK3Krc3W3G30W1XhbBVahe3pT4iiIAVQ8o TVNQ== X-Gm-Message-State: AOJu0YyiGlUF4WCq9WxIZt+gvxO/w/IJsKarbMnJS/EfZ1xHIouLi/ec d+GQwmkQfVToUJXORcEJShn1MYUJBjMC66DhyC7g76CmYviukPIN2aC/0d4Xxw== X-Gm-Gg: AeBDievwwbmh4NYA+fiSzAD48V6zopoFaqj0ANt+x/29rjy6cNrJVjsKWxNa8d8ubWs 4k+fHDSxqXBj2dvCF2Ti0KGtIRlEa+a85PU8x99LcAO6pAt3lwrTdfzFZfn2/L0cTBuUe39DGuE 4ZAO06CUT7WORNSpND39HY5IILMsBac8tGXG6FrY06v1pdWFXHn98i0SUalhqIZ4tY5TX2rTYyQ 8raQ4ou6is+Fx2NMBBd2pJJVNylqobi3sEX3QeG3LQANLnUs4nuLEtVXcx12yJJARdxnBDOICQ4 neJx3FOli4Jjk+wsMdzMHprtShJeKnrd5XdENZA7YJgVGPnjnPX7zZZLzLWiNgJcwvVJP3P3jfY XNLKarfhknUeEEs8lfqhfC9eQcO6lpTSqwYHgCm8bcZBqEn1WRj8RZoZrY6gZOj+w2Nu0o7FqpM qGoQqBOgf3R8yQFITRMJ/8gdPgbW97WBM= X-Received: by 2002:a05:6000:2006:b0:441:1fa5:4577 with SMTP id ffacd0b85a97d-4464a4470b9mr15813489f8f.26.1777493750590; Wed, 29 Apr 2026 13:15:50 -0700 (PDT) Received: from localhost ([2001:8a0:facb:a800:f22f:591f:e700:e91]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-447b7217c56sm7857139f8f.20.2026.04.29.13.15.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 13:15:50 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v3 10/11] Windows gdb: Always non-stop (default to "maint set target-non-stop on") Date: Wed, 29 Apr 2026 21:15:06 +0100 Message-ID: <20260429201507.480870-11-pedro@palves.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260429201507.480870-1-pedro@palves.net> References: <20260429201507.480870-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Since having the target backend work in non-stop mode adds features compared to old all-stop mode (signal/exception passing/suppression is truly per-thread), this switches the backend to do all-stop-on-top-of-non-stop, by having windows_nat_target::always_non_stop_p return true if non-stop mode is possible. To be clear, this just changes how the backend works in coordination with infrun. The user-visible mode default mode is still all-stop. The difference is that infrun is responsible for stopping all threads when needed, instead of the backend (actually the kernel) always doing that before reporting an event to infrun. Approved-By: Tom Tromey Change-Id: I83d23dbb1edc7692d5d8b37f5b9e0264c74d4940 commit-id:6f7924dc --- gdb/windows-nat.c | 9 +++++++++ gdb/windows-nat.h | 1 + 2 files changed, 10 insertions(+) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 638e87f6f60..a9647e90bb8 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -3376,6 +3376,15 @@ windows_nat_target::supports_non_stop () return dbg_reply_later_available (); } +/* Implementation of the target_ops::always_non_stop_p method. */ + +bool +windows_nat_target::always_non_stop_p () +{ + /* If we can do non-stop, prefer it. */ + return supports_non_stop (); +} + INIT_GDB_FILE (windows_nat) { #ifdef __CYGWIN__ diff --git a/gdb/windows-nat.h b/gdb/windows-nat.h index 2d6981ada0b..1f7ecb07e4f 100644 --- a/gdb/windows-nat.h +++ b/gdb/windows-nat.h @@ -256,6 +256,7 @@ struct windows_nat_target : public inf_child_target } bool supports_non_stop () override; + bool always_non_stop_p () override; void async (bool enable) override; -- 2.53.0