From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Mp5bIW7r8WmFHgMAWB0awg (envelope-from ) for ; Wed, 29 Apr 2026 07:28:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ftbK99KK; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YKvNbk8s; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ftbK99KK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YKvNbk8s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 743AA1E067; Wed, 29 Apr 2026 07:28:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59A791E067 for ; Wed, 29 Apr 2026 07:28:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id C16F14BB24E1 for ; Wed, 29 Apr 2026 11:28:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C16F14BB24E1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ftbK99KK; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YKvNbk8s; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ftbK99KK; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=YKvNbk8s Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id DD39B4BB24E1 for ; Wed, 29 Apr 2026 11:28:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD39B4BB24E1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DD39B4BB24E1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777462100; cv=none; b=XW3bi0/98pz9XSUorLD/I8Yf2KOghMckU4OoGYj5+/nycWft/z+QPuX76zUTbcSXstkk64Z6fNwKB5dYXhlAHc4SeUk5Z7f78qVq8AH7kK91X3+Zs05mD34prFwKwJYovZ0LH6oCY+S12cE6EGFUWZo2vf22A3VaxDPYgTNNQZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777462100; c=relaxed/simple; bh=dxgrvC2GG+0vA5iCLtyDNwGhD1Qak/WoAFOtmEe8vpQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=MuVOpbDYJc2h5LOLdcRHg2HX+LvjjTFpgLv9DZyB4Ovxv1zJtD78fn+oPEek1q6X1bEhIZC/T8g3+8kvyNmr2EQVLJiAAxgY1kVX54BZ/lw7tXfQ/MovtEsU2JlzBigN/m5sPr38Eg3IoCIytPS2On+fsNdVwKEEckbnh6f1t74= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD39B4BB24E1 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D03426A874 for ; Wed, 29 Apr 2026 11:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777462098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Av44zgGwWsI96bYG1olx19vCyu05sYelHB7m1DregPY=; b=ftbK99KKI32swBHZGlLZ8LMuGJ3HRU1HNQv8IMmYTNAnPrC2u0lXyHAiR/92N2Fe42MEHw XxKiyNDJCvUJXc5JtWe4a11Jf1urtb593coUDAe7xOh11rWlQ0tHFG8P6kq5LBW/++YF6B qJo8BzrKstp7hjPsYL+pZEPx5dLf2bQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777462098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Av44zgGwWsI96bYG1olx19vCyu05sYelHB7m1DregPY=; b=YKvNbk8s6pF6eQ2FMIfwM2SiExl9D4a+unwmONLoVeFXG61LYoOKNWicsVS7w6iCSlU22e 9HBVJeZlii7AZuBA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777462098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Av44zgGwWsI96bYG1olx19vCyu05sYelHB7m1DregPY=; b=ftbK99KKI32swBHZGlLZ8LMuGJ3HRU1HNQv8IMmYTNAnPrC2u0lXyHAiR/92N2Fe42MEHw XxKiyNDJCvUJXc5JtWe4a11Jf1urtb593coUDAe7xOh11rWlQ0tHFG8P6kq5LBW/++YF6B qJo8BzrKstp7hjPsYL+pZEPx5dLf2bQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777462098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Av44zgGwWsI96bYG1olx19vCyu05sYelHB7m1DregPY=; b=YKvNbk8s6pF6eQ2FMIfwM2SiExl9D4a+unwmONLoVeFXG61LYoOKNWicsVS7w6iCSlU22e 9HBVJeZlii7AZuBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BCC60593B0 for ; Wed, 29 Apr 2026 11:28:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GZXtLFLr8WmULwAAD6G6ig (envelope-from ) for ; Wed, 29 Apr 2026 11:28:18 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/tui] Simplify tui_enable Date: Wed, 29 Apr 2026 13:28:18 +0200 Message-ID: <20260429112818.1610891-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org I noticed some code in tui_enable doing: ... if (...) error (...); else if (...) ... which is the "Don’t use else after a return" anti-pattern [1]. Fix this by using: ... if (...) error (...); if (...) ... [1] https://llvm.org/docs/CodingStandards.html#id41 --- gdb/tui/tui.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index ba4f6f68769..de2faa36af7 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -429,7 +429,8 @@ tui_enable (void) again. */ error (_("Cannot enable the TUI")); } - else if (tui_finish_init == TRIBOOL_TRUE) + + if (tui_finish_init == TRIBOOL_TRUE) { WINDOW *w; SCREEN *s; base-commit: 8a5e138e6276ce7644ab858751440cb59f35623b -- 2.51.0