Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/4] [gdb] Factor out filter_excluded out of update_files in copyright.py
Date: Wed, 29 Apr 2026 10:13:35 +0200	[thread overview]
Message-ID: <20260429081337.1563201-3-tdevries@suse.de> (raw)
In-Reply-To: <20260429081337.1563201-1-tdevries@suse.de>

Factor out function filter_excluded out of function update_files in
copyright.py.
---
 gdb/copyright.py | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/gdb/copyright.py b/gdb/copyright.py
index cf838453c45..16b11180047 100755
--- a/gdb/copyright.py
+++ b/gdb/copyright.py
@@ -42,6 +42,20 @@ import sys
 from typing import Iterable
 
 
+def filter_excluded(files: list[str]) -> list[str]:
+    full_exclude_list = EXCLUDE_LIST + BY_HAND
+
+    def include_file(filename: str):
+        path = pathlib.Path(filename)
+        for pattern in full_exclude_list:
+            if path.full_match(pattern):
+                return False
+
+        return True
+
+    return filter(include_file, files)
+
+
 def get_update_list():
     """Return the list of files to update.
 
@@ -49,7 +63,7 @@ def get_update_list():
     of the GDB source tree (NOT the gdb/ subdirectory!).  The names of
     the files are relative to that root directory.
     """
-    result = (
+    return (
         subprocess.check_output(
             [
                 "git",
@@ -69,18 +83,6 @@ def get_update_list():
         .split("\0")
     )
 
-    full_exclude_list = EXCLUDE_LIST + BY_HAND
-
-    def include_file(filename: str):
-        path = pathlib.Path(filename)
-        for pattern in full_exclude_list:
-            if path.full_match(pattern):
-                return False
-
-        return True
-
-    return filter(include_file, result)
-
 
 def update_files(update_list: Iterable[str]):
     """Update the copyright header of the files in the given list.
@@ -191,6 +193,7 @@ def main(argv: list[str]) -> int | None:
         sys.exit("Error: This script must be called from the top-level directory.")
 
     update_list = get_update_list()
+    update_list = filter_excluded(update_list)
     update_files(update_list)
 
     run_autoreconf()
-- 
2.51.0


  parent reply	other threads:[~2026-04-29  8:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  8:13 [PATCH 0/4] [pre-commit] Add copyright-years check Tom de Vries
2026-04-29  8:13 ` [PATCH 1/4] [gdb] Handle empty list in update_files in copyright.py Tom de Vries
2026-04-29  8:13 ` Tom de Vries [this message]
2026-04-29  8:13 ` [PATCH 3/4] [gdb] Require python >= 3.13 " Tom de Vries
2026-04-29  8:13 ` [PATCH 4/4] [pre-commit] Add copyright-years check Tom de Vries
2026-06-01 13:23   ` Tom de Vries
2026-06-01 13:10 ` [PING] [PATCH 0/4] " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429081337.1563201-3-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox