From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8UnQMR0E72n/4z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:37:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MOq8znHN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C363D1E0BA; Mon, 27 Apr 2026 02:37:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3CBAF1E0BA for ; Mon, 27 Apr 2026 02:37:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D2DF54B99F44 for ; Mon, 27 Apr 2026 06:37:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2DF54B99F44 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MOq8znHN Received: from mail-dl1-x1233.google.com (mail-dl1-x1233.google.com [IPv6:2607:f8b0:4864:20::1233]) by sourceware.org (Postfix) with ESMTPS id 841BF4BABF08 for ; Mon, 27 Apr 2026 06:35:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 841BF4BABF08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 841BF4BABF08 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1233 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271721; cv=none; b=tsVleuf3uvDxGfPCT5JtjGwnrKZL+g/1wIONv/GnVmB2fwf0uD8Qu+byDIqdKivizs7RyhQzPRTsZe0chSeDkPXYWp41E0k12rYpmY3dlbJiaMvPQzXVqx+BQxI7sBKbiyC4Y3jSXZWxAt3Mb50xZA44gTsyw4LDzBExKDdi1pM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271721; c=relaxed/simple; bh=sVib8GD+LxviNSCTpP3Rj1HoH4fhEsb9h5aQgd/Usi0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=AEhPAUs+1GAGtyr4PWkevZhhhiuW/S6ach96qP6rCcNw4enu7vbsIf67B2auJPNdt01g9AJKkUDHUJfNxyqKlgUOE2gIYGswslLbAXO0lDgD0/jBxdUuZtpTzU/5rzCQBkl67e79DHHJ84rOg6b3Sfu0dl/LeK/ORXHVpwUvauE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 841BF4BABF08 Received: by mail-dl1-x1233.google.com with SMTP id a92af1059eb24-12c19d23b19so12572021c88.0 for ; Sun, 26 Apr 2026 23:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271720; x=1777876520; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=jAvZBo6mT5MomhyJ8cHAljGJzpcZYST9Q3XRNjowHPw=; b=MOq8znHNs6BSH8KAgwQxcQ5on9D7TsuLv03YLGLxPj1soWdzgJmfqJp/t6V6C7AKXe hGnk586Da0wTWPLifb7lP/JZB6WPhzrgvKyPw0oMn8dqxsveM0y5C2jXV+ihMepkcW9G 4NskobxjX4mAXELMbsXZt6+UyQAD0j84+385+aHopr0rPa1JBjqvGjNL/F6nwhvG2YYS 19yr/QdkeO67In+nbjvIEiXc70gyCX9s+Mzommut/lpuQWWVqe7PqYMQtyF6PzyM9Cvr MmhxKJ8Mjg/LRgNWxP5D4NdN8OMSAohQHhuMVUNrIiFwKqUd6G0qpiVETOLAjX7TTkRn OEqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271720; x=1777876520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jAvZBo6mT5MomhyJ8cHAljGJzpcZYST9Q3XRNjowHPw=; b=q1N+BUPCjZ+CogRM62g8DtNX8KnMhStqcJGpHIhBeIldMZc0+oVKQQbwBNOLLeshnw XnguupmGaq0LbW7axj8GR0HPI5Jag2pcAzVWglnoyTCd+QX1csK0xJnsCHrcRFK1OQLA jvHBOTLZ4M5TANdc0d1beE2VXFlv4NsS6QBseiN/60IWsKu8Bs/IhZ8wzzZtRDdRg+cn 5+g5OIhFGx/NLyktBjYU1VPJ6mmeB3eQd0hOHaw0s+EYaGOckEquBm7PTVn5NLXdBAxg zLktUH0oamvUNPO86piDxLX9Y8eOvvQBiemxRBCE/cyIWDBaNegbxzar4CF2q24eaekA uwkg== X-Gm-Message-State: AOJu0Yw14NnH9fZ3Ts6hw5Z2Hvi9/f/U4hsMKJLZg0L8lEz9ulE1H8KW ITwzuTVbMp7zBRpKldNfRoTa1/a5x5Tjv3DLVoSHFMb0D6gkhoJqr2UujHKPQa8GNOIHTQac5QH bSaEW X-Gm-Gg: AeBDiesXSSdemG608hho8tWmPC3al8m3UxEEqi635vjqjufBAgkFSUB7k7/CNtxXOHT SXaUaKr4YnSB5Hi8X7Qj0caX0mYCVwnMdpn11fWiOTxAy+HI+5jcloN1nK1uMdBHLl2MMNB4mqo SBxtFUhabYOx2CSZApQs6dlaUGbk5pG6oyLKkg0VA+NmQEqwP+jN209vZtHLkdKLbA1GpDUXBRE 3y0bpEE4ieDVkXAxEkl7OWs5dGwFvwrGakW487vcTGtnPHcUJeLZI1KYcAbQguQkAVh9iE+2NxL QXpFg7EoXRsBAFaGWHEUZfbtOjhpotNOx7PiQLb/ILzRXhJJG1Pm4sfECZBBMRI9faxCoHcOoTK yWrcMMXTGgwt9sHaO2ozmI9+vmz+eIQzBgBxBDRWnaUOQpj480cd9g8ukh1q1vE5QleCZVCVZ8L 38cbICiCsvc09mjYNS5JJ+jSwES7RIA6Cx+EIlL4dFZdlx X-Received: by 2002:a05:7022:e22:b0:128:d494:a1ab with SMTP id a92af1059eb24-12c73f83681mr23450978c88.15.1777271720166; Sun, 26 Apr 2026 23:35:20 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12da8b8fbc4sm42557713c88.4.2026.04.26.23.35.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:35:19 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 04/36] GDB: testsuite: intel: Don't return -1 from top-level (manual) Date: Mon, 27 Apr 2026 03:34:28 -0300 Message-ID: <20260427063500.3847618-5-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch manually changes the "return -1" statements that weren't caught by the sed command. In i386-bp_permanent.exp this was caused by misaligned lines, which are now fixed. In the case of core-file-pid0.exp it's because the file didn't match the glob pattern of the sed command. In amd64-shadow-stack-cmds.exp there's a return statement in a procedure whose callers don't use the return value, and the others have extra indentation due to being inside a save_vars block. --- gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp | 10 +++++----- gdb/testsuite/gdb.arch/core-file-pid0.exp | 6 +++--- gdb/testsuite/gdb.arch/i386-bp_permanent.exp | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp b/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp index e4daecb590dd..266c658eae86 100644 --- a/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp +++ b/gdb/testsuite/gdb.arch/amd64-shadow-stack-cmds.exp @@ -29,7 +29,7 @@ proc restart_and_run_infcall_call2 {} { global binfile clean_restart ${::testfile} if { ![runto_main] } { - return -1 + return } set inside_infcall_str "The program being debugged stopped while in a function called from GDB" gdb_breakpoint [ gdb_get_line_number "break call2" ] @@ -44,12 +44,12 @@ save_vars { ::env(GLIBC_TUNABLES) } { if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ {debug additional_flags="-fcf-protection=return"}] } { - return -1 + return } clean_restart ${::testfile} if { ![runto_main] } { - return -1 + return } with_test_prefix "test inferior call and continue" { @@ -85,7 +85,7 @@ save_vars { ::env(GLIBC_TUNABLES) } { clean_restart ${::testfile} if { ![runto_main] } { - return -1 + return } set call1_line [ gdb_get_line_number "break call1" ] @@ -122,7 +122,7 @@ save_vars { ::env(GLIBC_TUNABLES) } { clean_restart ${::testfile} if { ![runto_main] } { - return -1 + return } with_test_prefix "test return from past frame" { diff --git a/gdb/testsuite/gdb.arch/core-file-pid0.exp b/gdb/testsuite/gdb.arch/core-file-pid0.exp index 8f4f88bcdb6a..3f389a705480 100644 --- a/gdb/testsuite/gdb.arch/core-file-pid0.exp +++ b/gdb/testsuite/gdb.arch/core-file-pid0.exp @@ -28,7 +28,7 @@ if {[istarget "x86_64-*-linux*"]} { set cf_size 8757248 } else { unsupported "no pre-generated core file for this target" - return -1 + return } # Decompress the core file. @@ -36,14 +36,14 @@ set corebz2file ${srcdir}/${subdir}/${cf_name} set corefile [decompress_bz2 $corebz2file] if { $corefile eq "" } { untested "failed to bunzip2 the core file" - return -1 + return } # Check the size of the decompressed core file. Just for sanity. file stat ${corefile} corestat if { $corestat(size) != ${cf_size} } { untested "uncompressed core file is the wrong size" - return -1 + return } # Copy over the corefile if we are remote testing. diff --git a/gdb/testsuite/gdb.arch/i386-bp_permanent.exp b/gdb/testsuite/gdb.arch/i386-bp_permanent.exp index ef4d0370de89..9805f5626348 100644 --- a/gdb/testsuite/gdb.arch/i386-bp_permanent.exp +++ b/gdb/testsuite/gdb.arch/i386-bp_permanent.exp @@ -40,7 +40,7 @@ clean_restart $::testfile # if {![runto_main]} { - return -1 + return } set function "standard" @@ -53,8 +53,8 @@ set retcode [gdb_test_multiple "disassemble $function" "disassemble function '$f }] if {$retcode != 0} { - fail "disassemble failed, skipping entire test." - return -1 + fail "disassemble failed, skipping entire test." + return } gdb_breakpoint "*$address_bp"