From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2VL4BM8E72n/4z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:40:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BqU/Dd7j; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 107931E093; Mon, 27 Apr 2026 02:40:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 72A9D1E093 for ; Mon, 27 Apr 2026 02:40:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2135A4BAE7FF for ; Mon, 27 Apr 2026 06:40:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2135A4BAE7FF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=BqU/Dd7j Received: from mail-dy1-x132e.google.com (mail-dy1-x132e.google.com [IPv6:2607:f8b0:4864:20::132e]) by sourceware.org (Postfix) with ESMTPS id 285C94B99F53 for ; Mon, 27 Apr 2026 06:36:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 285C94B99F53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 285C94B99F53 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::132e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271819; cv=none; b=XlXrUkrG23pVHdw9r02ksGH+biBBTPvXmIwVy0wK4Tn/fdR0JarvaVVqm81ac5mG/h614k6EVRZczmCDq7fnQiNCa3SAQk83/TNnwI8ZI86wI7jVuoXlhxPT/6zWlRd69iAJKEyKoq9TyWpOS0s5UMQXmDkQYFY1Swo54DG4+d0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271819; c=relaxed/simple; bh=3XUV/MwXwaIuqP3ZrFzDN85LgPYeaXGhzglcv0pXkBs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KZzdmz6zOFSdkQlm01NNHexRCG3hf+nMvEAXA+5QkwK3E+7yUlqtV+fW7zIA18666RFlGF5ZBFQQd4Jzu8V1dK80pDkK5/ovWn5U1iykgSzIkhLecIpxlSkpm1ULk7HSSPUzZxoOjwcX3KKrel8QOOCVheJusshyxqoUBOC66ZA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 285C94B99F53 Received: by mail-dy1-x132e.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso9923866eec.1 for ; Sun, 26 Apr 2026 23:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271818; x=1777876618; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=fo7LVhrsWkMA7FcG4LyqjVeFwUdqmZRZR97uKbA5+BI=; b=BqU/Dd7jJ/ANDDuD/5QvqqANbV1LEqDaaOHT5mAKtD3qqpyM15EQ9Tkqyahc9Bis2P diWP+auBY1O9SwOC1pmDYnoEtpPKCM4CIIylJgxu9V3435PkQtNNlKKaINLkpBAbtN+f WX2GoKXzsqh20NrZky6/fs1gmGDhhkLPvtm3iNB9JB3+FFq4x3NZpc1fob+iCuh7xyoL lBis6tdlela/S+K2kEDz8Z5lerhiI9o1kFZ6Ottw5r4xqTnK27jy9cBwkr6CM0tpZ8B6 pyqqDz8I6mMHUQnMoKuO3SzhgTlcNYXe0TigyUDPIOj895JbA6DY9qsfU2oD9clFSlOC XD2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271818; x=1777876618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fo7LVhrsWkMA7FcG4LyqjVeFwUdqmZRZR97uKbA5+BI=; b=E5nARRwe1uxygGlxJqhaYy6yL4RQnFqHWmzcJGycsnjLTpcCQV7IUspoYtX4ucSkcv 7K4NR1SemIqH6DFuRYGIKa0agFj6swpvR7ZmlKUi7irt8Sj4zqhmSbPJ3C6cteWmXtCt cFG5vRhnPj3tOOWKF5GWFDmnVX0RKazMRtB2BwfDOQMmNiiFi94BYvfdRJtf5ZMWR8kg uu50qWF9el6hdrPiO5k2TE4A4Zr9d5r2VfuHMRNr95ALDn3K0H57VxhSsC3xtopR6pK0 FRnJPNXZc7VtqxkoxHsaHJTJ7XQQPcj2Hys3hWnKnAdrEvgNcQZgH12ZobTubg3fmaWK hkfw== X-Gm-Message-State: AOJu0YwCj7/th4VnBuyq/DbJN5wN6eh/b1aVKO7tp2Hbzog+kKwLfs5p Sya6ImmWCB8dApvK3r7TpYmYVhBIDFzDtl0xK/8rFGaK4dNf/Mv7XLKmJMKIk6LkayMkJjlog1I 7OW8y X-Gm-Gg: AeBDiev5pigAhfUCvIt9eyhujhWHV34Mmi3BMs/Sb+kS4Jpnaw38FQj7HEJowU8dsUm EC8rE1ZlVZkti368OjBDCR/mmi0zKy23JJ07qxvu1C/VwEeBpDZ8rBV3cqAFIbbnrKzIPk3ipx3 I0++tY/YnVXh+y2512Q37Hw7eQh6mWN9CZhhvVBkhJHfbKrWFj6ANEjtzQUVQdkKtJKIy9Sjdz+ pVOtuk2hl145p8dyUazcuq9bSISOXE/mu+yNM6fDAictLryGwiMW18ZKM0pn4m/L2j2N8uZ6Qoj yQ1V92m/57ZmetZRzfsJJf/toaH+h+rAnodI27YojLB1a6WMsxaen9PSGT/TQ5yZlOwqsRXdqoa MeHUfs/EWUGFxahIBnoyVX6mM92hFsg2PerBa16xHVkSOQeA8WM459N4rAid68KyyLM724zNlI1 mK0t7y654xTERXAs8tjQMyjoVSmAk8Xu8i0bhiQzeCztrH X-Received: by 2002:a05:693c:8005:b0:2dd:144b:6c2 with SMTP id 5a478bee46e88-2e478e28c50mr16311230eec.27.1777271818004; Sun, 26 Apr 2026 23:36:58 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12dcbe079c3sm10371179c88.2.2026.04.26.23.36.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:36:57 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 30/36] GDB: testsuite: server: Don't return -1 from top-level (manual) Date: Mon, 27 Apr 2026 03:34:54 -0300 Message-ID: <20260427063500.3847618-31-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch manually changes most "return -1" statements that weren't caught by the sed command. These return statements fall into one of these criteria: - return at top level but inside block such as save_vars and with_test_prefix; - procedure whose callers don't use the return value; I also fixed some cases of top-level "return 0". --- gdb/testsuite/gdb.server/abspath.exp | 2 +- gdb/testsuite/gdb.server/attach-flag.exp | 2 +- gdb/testsuite/gdb.server/exit-multiple-threads.exp | 2 +- gdb/testsuite/gdb.server/ext-restart.exp | 2 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 2 +- gdb/testsuite/gdb.server/extended-remote-restart.exp | 4 ++-- gdb/testsuite/gdb.server/multi-ui-errors.exp | 2 +- gdb/testsuite/gdb.server/reconnect-ctrl-c.exp | 2 +- gdb/testsuite/gdb.server/target-exec-file.exp | 2 +- gdb/testsuite/gdb.server/wrapper.exp | 2 +- 10 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.server/abspath.exp b/gdb/testsuite/gdb.server/abspath.exp index 5bd7f7e842bb..7c4d43ff474d 100644 --- a/gdb/testsuite/gdb.server/abspath.exp +++ b/gdb/testsuite/gdb.server/abspath.exp @@ -38,7 +38,7 @@ save_vars { GDBFLAGS } { } if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } } diff --git a/gdb/testsuite/gdb.server/attach-flag.exp b/gdb/testsuite/gdb.server/attach-flag.exp index 29013074459e..f9432048c378 100644 --- a/gdb/testsuite/gdb.server/attach-flag.exp +++ b/gdb/testsuite/gdb.server/attach-flag.exp @@ -38,7 +38,7 @@ proc run_one_test { non-stop target-non-stop } { if { [prepare_for_testing "failed to prepare" $::testfile $::srcfile \ {debug pthreads additional_flags=-std=gnu99}] } { - return -1 + return } } diff --git a/gdb/testsuite/gdb.server/exit-multiple-threads.exp b/gdb/testsuite/gdb.server/exit-multiple-threads.exp index 1b0941eb3c78..c6e19f8dfb44 100644 --- a/gdb/testsuite/gdb.server/exit-multiple-threads.exp +++ b/gdb/testsuite/gdb.server/exit-multiple-threads.exp @@ -140,7 +140,7 @@ foreach_with_prefix test { exit signal } { set executable "$binfile-${test}" if {[build_executable "failed to prepare" $executable $srcfile \ [list debug pthreads additional_flags=-D${def}]]} { - return -1 + return } set target_executable [gdb_remote_download target $executable] diff --git a/gdb/testsuite/gdb.server/ext-restart.exp b/gdb/testsuite/gdb.server/ext-restart.exp index 39d42d7a4416..031aaeb5db85 100644 --- a/gdb/testsuite/gdb.server/ext-restart.exp +++ b/gdb/testsuite/gdb.server/ext-restart.exp @@ -31,7 +31,7 @@ save_vars { GDBFLAGS } { } if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } } diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp index 912a8ce37708..757127b15488 100644 --- a/gdb/testsuite/gdb.server/ext-wrapper.exp +++ b/gdb/testsuite/gdb.server/ext-wrapper.exp @@ -33,7 +33,7 @@ save_vars { GDBFLAGS } { } if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } } diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp index f10d2f374c09..ab0be669aeb1 100644 --- a/gdb/testsuite/gdb.server/extended-remote-restart.exp +++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp @@ -42,7 +42,7 @@ require {is_any_target "*-*-linux*" "*-*-openbsd*"} set gdbserver_reconnect_p 1 if { [info proc gdb_reconnect] == "" } { unsupported "requires gdbserver reconnect" - return 0 + return } standard_testfile @@ -61,7 +61,7 @@ proc test_reload { do_kill_p follow_child_p } { clean_restart ${::testfile} if {![runto_main]} { - return 0 + return } # Set detach-on-fork off diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/gdb.server/multi-ui-errors.exp index c17de8bf2e48..dde936c1a455 100644 --- a/gdb/testsuite/gdb.server/multi-ui-errors.exp +++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp @@ -37,7 +37,7 @@ save_vars { GDBFLAGS } { } if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} { - return -1 + return } } diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp index 63502887bf55..c0e129db76d5 100644 --- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp +++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp @@ -33,7 +33,7 @@ save_vars { GDBFLAGS } { } if {[prepare_for_testing "failed to prepare" $testfile $srcfile]} { - return -1 + return } } diff --git a/gdb/testsuite/gdb.server/target-exec-file.exp b/gdb/testsuite/gdb.server/target-exec-file.exp index a9e6f801165d..e3e2884aa727 100644 --- a/gdb/testsuite/gdb.server/target-exec-file.exp +++ b/gdb/testsuite/gdb.server/target-exec-file.exp @@ -156,7 +156,7 @@ proc start_inferior { testname expect_reread } { with_test_prefix $testname { if { [gdb_start_cmd] < 0 } { fail "start command" - return -1 + return } set saw_reread false diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp index 15643fb92a7c..40c29c441fab 100644 --- a/gdb/testsuite/gdb.server/wrapper.exp +++ b/gdb/testsuite/gdb.server/wrapper.exp @@ -37,7 +37,7 @@ save_vars { GDBFLAGS } { } if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } }