From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YbbqEpQF72ky5z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:43:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=tzYio67g; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 486051E093; Mon, 27 Apr 2026 02:43:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D19E81E093 for ; Mon, 27 Apr 2026 02:43:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 76AA94BA23C0 for ; Mon, 27 Apr 2026 06:43:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76AA94BA23C0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=tzYio67g Received: from mail-dy1-x1333.google.com (mail-dy1-x1333.google.com [IPv6:2607:f8b0:4864:20::1333]) by sourceware.org (Postfix) with ESMTPS id 0401A4BB1C2A for ; Mon, 27 Apr 2026 06:36:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0401A4BB1C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0401A4BB1C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271816; cv=none; b=eha3G0dbV4NugvjBUNyr1SAqmM+VA7J0FPjwrbHnD94AKz88oILXT9FATSIMZ40+9kYH93R4QBj8Vq5ZvrfxtTFzfTeXGPaeLkH/COZpNCPBAtnsW6OXUgIk6Hmukp4S6Ro7RANs50orUDgnrTPd4XfVfWEk2eSTtyKQ58zmIjo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271816; c=relaxed/simple; bh=6IOk0hlaecEuY2lpMyDqfCDAthwPI4Dqyhb4ghjjuFY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WscRZC+6iNyvLzP4bQK2IZ9Nw3KvJtEedvL37FLr6b52R9ZJMNnFOkA6ol9F3IpVPenSjAeXX2a2ettJYFbe4ANOYNpqBBbgNW3omnZYcy11wLljwgC7QbU1/AZzyrtP2Mvg4TZ8tgNelHbctw1lbJ/fQfvsHsoNEvbVrL05aoQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0401A4BB1C2A Received: by mail-dy1-x1333.google.com with SMTP id 5a478bee46e88-2ba9c484e5eso9923797eec.1 for ; Sun, 26 Apr 2026 23:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271815; x=1777876615; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=t8JJTosMI1Y388404/dVN37uZ3XiCRoqS3vqrieLNc4=; b=tzYio67gZR0p07xmLAtb5zg9lUckh07T6UmNKmTN2vlMmQ4QJJTkxlnJLL4wPkzUkM yG5PXmsWiKxGsIJaEDHZFCVne3gzPP6RC918WqKCCmQW3yMvesIfkkRjypdDWwL4v8qv PvJVi/08tIX3GGTUKizXiQ08EXh8fSu6JEAHwpuwPNBhf8rIy2npvYOj79TM8zVwXCTB iayrKBWBmZGdjMgxagGlK3gHY96eG3mVoWpTTGz0tN8KqVmjniDEhHAxwBC+UkcuchCC L6dF+XNMSlP4zyrkeRiyfQ6kvgyjq1DiKqAxrE5wzP/z9s4jCE8n4FeCnYf4MAfGnq9E qCHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271815; x=1777876615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=t8JJTosMI1Y388404/dVN37uZ3XiCRoqS3vqrieLNc4=; b=dCf4WeZ+aR+Nqss3IHU/b8x0g+mFHTd2/CXjdcjLuN+U5rvjHapwln4wxmXlC8+1Lt V6osgXGdJCwVHuPFvh5yh6mXLB60BOJOysISiGe/ildsbpTBfloSaN4w2xkMaGUi3Q1w OzoFhDnwCUFWzSyXcqpblkTk3pQkwwQ3IWc+up3g8nono0+oz2V4ZzDVjCE72x2tUgDG JdW5ZSAx9TDy6REXwNL4157RMHDTHEOtNKeIC9eD+tq08acRbeW0uaqe4vupwchQTssA Le1jRtB4cZj8x0aYMfS3z2nnd8A6d1mBJZtl32m/+Y5EIY0Jv3bKdhku6P7u+lYbT71w 2tWw== X-Gm-Message-State: AOJu0YyY5kLoqN1daKp1Jaz+5adl+rMRyP/BckKZ2heUNsKu+BX8P9ft ZAEJiOAKn4/auSjT+mlweXX9BVPgCbe/rFqH5eDX1B+BohLRwHvDx/l0Ns6mAwfnt7XmX08sGqy cfvxO X-Gm-Gg: AeBDiesyRq1+NaCvIzaI1vuKV1M6z3ir9EB+ShExbHS5CvvH8DNBDWa8qfc6udJgE0h AhY1WatcelEtO6OyZmFTREbzHCaz/wEpzDR6Mn5o8nZ9HJNCHyIX+BkeELWBQg/oW2nUYx3Hqwo 3iyhlnu8d14M8q02pf32VxhyHLsxUaXotTuIzmlr5x2KvTA4CNxtxxzdfp68P9b7pDjku2oUjG4 Ur3QwPkriTcr3BGtqsZgTdDBqTuxpCFHkss1ntP2lryDVdthRFX3WHwrawOA840cHSTuyE/Hn2h z5Li+A4b4ZSpHau5HOiqh0hUjPXKWHGdaMfhvSEF8RNIH2rxe7XGL3j6l6g2Vm952fCdtkqCFhL aHfLNzxeSXoC3r+h2fpeoZpQhyckrPYgF32/M7hjVsS3vWsFvS7Ja55tCl+earynfHXRBmO9P+N DEqNZp+j/UmEqE6kFARQHU8MS8lMgxz48mLWvMxZCFuU0y X-Received: by 2002:a05:7300:3252:b0:2c4:ec89:bc7 with SMTP id 5a478bee46e88-2e464dacc71mr22659021eec.10.1777271814731; Sun, 26 Apr 2026 23:36:54 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e539fa5c86sm50544942eec.1.2026.04.26.23.36.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:36:54 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 29/36] GDB: testsuite: server: Don't return -1 from top-level (sed) Date: Mon, 27 Apr 2026 03:34:53 -0300 Message-ID: <20260427063500.3847618-30-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch is purely the result of running: $ sed -i 's/^ return -1/ return/' *.exp* inside gdb/testsuite/gdb.server. --- gdb/testsuite/gdb.server/build-id-seqno.exp | 4 ++-- gdb/testsuite/gdb.server/connect-stopped-target.exp | 2 +- gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp | 2 +- gdb/testsuite/gdb.server/connect-without-multi-process.exp | 2 +- gdb/testsuite/gdb.server/ext-attach.exp | 2 +- gdb/testsuite/gdb.server/ext-run.exp | 2 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 2 +- gdb/testsuite/gdb.server/extended-remote-restart.exp | 2 +- gdb/testsuite/gdb.server/file-transfer.exp | 2 +- gdb/testsuite/gdb.server/inferior-args.exp | 2 +- gdb/testsuite/gdb.server/monitor-exit-quit.exp | 2 +- gdb/testsuite/gdb.server/no-thread-db.exp | 2 +- gdb/testsuite/gdb.server/pread-offset-size.exp | 2 +- gdb/testsuite/gdb.server/remote-read-msgs.exp | 4 ++-- gdb/testsuite/gdb.server/run-without-local-binary.exp | 2 +- gdb/testsuite/gdb.server/server-connect.exp | 2 +- gdb/testsuite/gdb.server/server-exec-info.exp | 2 +- gdb/testsuite/gdb.server/server-kill-python.exp | 2 +- gdb/testsuite/gdb.server/server-kill.exp | 2 +- gdb/testsuite/gdb.server/server-mon.exp | 2 +- gdb/testsuite/gdb.server/server-pipe.exp | 2 +- gdb/testsuite/gdb.server/server-run.exp | 2 +- gdb/testsuite/gdb.server/solib-list.exp | 2 +- gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp | 2 +- gdb/testsuite/gdb.server/stop-reply-no-thread.exp | 2 +- gdb/testsuite/gdb.server/sysroot.exp | 2 +- gdb/testsuite/gdb.server/target-exec-file.exp | 4 ++-- gdb/testsuite/gdb.server/twice-connect.exp | 2 +- gdb/testsuite/gdb.server/wrapper.exp | 2 +- 29 files changed, 32 insertions(+), 32 deletions(-) diff --git a/gdb/testsuite/gdb.server/build-id-seqno.exp b/gdb/testsuite/gdb.server/build-id-seqno.exp index 44bdb09b60ad..1fa27e80aa0f 100644 --- a/gdb/testsuite/gdb.server/build-id-seqno.exp +++ b/gdb/testsuite/gdb.server/build-id-seqno.exp @@ -36,12 +36,12 @@ require allow_gdbserver_tests standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile] == -1} { - return -1 + return } # Split out BINFILE.debug. Remove debug from BINFILE. if {[gdb_gnu_strip_debug $binfile] != 0} { - return -1 + return } # Get the '.build-id/xx/xxx...xxx' part of the filename. diff --git a/gdb/testsuite/gdb.server/connect-stopped-target.exp b/gdb/testsuite/gdb.server/connect-stopped-target.exp index cfe38fcbfc6a..74ccd774561e 100644 --- a/gdb/testsuite/gdb.server/connect-stopped-target.exp +++ b/gdb/testsuite/gdb.server/connect-stopped-target.exp @@ -26,7 +26,7 @@ standard_testfile set executable ${testfile} if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } proc do_test {nonstop} { diff --git a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp index fcdc6978d618..7e2b33e09a98 100644 --- a/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp +++ b/gdb/testsuite/gdb.server/connect-with-no-symbol-file.exp @@ -28,7 +28,7 @@ standard_testfile require allow_gdbserver_tests if { [build_executable "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } # Test connecting GDB to GDBserver without loading a symbol file. diff --git a/gdb/testsuite/gdb.server/connect-without-multi-process.exp b/gdb/testsuite/gdb.server/connect-without-multi-process.exp index 4b41f461a79d..33787acded51 100644 --- a/gdb/testsuite/gdb.server/connect-without-multi-process.exp +++ b/gdb/testsuite/gdb.server/connect-without-multi-process.exp @@ -23,7 +23,7 @@ require allow_gdbserver_tests standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Test spawning gdbserver with a program, connect to it and run to diff --git a/gdb/testsuite/gdb.server/ext-attach.exp b/gdb/testsuite/gdb.server/ext-attach.exp index 0dd02c145ac4..cb4c12772289 100644 --- a/gdb/testsuite/gdb.server/ext-attach.exp +++ b/gdb/testsuite/gdb.server/ext-attach.exp @@ -27,7 +27,7 @@ require allow_gdbserver_tests require can_spawn_for_attach if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Run the test. TARGET_NON_STOP and TARGET_ASYNC should be 'on' diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp index 83de771902b4..4fb2fe004f26 100644 --- a/gdb/testsuite/gdb.server/ext-run.exp +++ b/gdb/testsuite/gdb.server/ext-run.exp @@ -24,7 +24,7 @@ standard_testfile server.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } # allow_xml_test must be called while gdb is not running. diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp index 836c32a75745..912a8ce37708 100644 --- a/gdb/testsuite/gdb.server/ext-wrapper.exp +++ b/gdb/testsuite/gdb.server/ext-wrapper.exp @@ -22,7 +22,7 @@ standard_testfile wrapper.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } save_vars { GDBFLAGS } { diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp index 5fe4ebd57297..f10d2f374c09 100644 --- a/gdb/testsuite/gdb.server/extended-remote-restart.exp +++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp @@ -48,7 +48,7 @@ if { [info proc gdb_reconnect] == "" } { standard_testfile if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Core of the test. DO_KILL_P controls whether we kill one of the diff --git a/gdb/testsuite/gdb.server/file-transfer.exp b/gdb/testsuite/gdb.server/file-transfer.exp index f33c589c961e..a4517582b257 100644 --- a/gdb/testsuite/gdb.server/file-transfer.exp +++ b/gdb/testsuite/gdb.server/file-transfer.exp @@ -23,7 +23,7 @@ standard_testfile server.c require allow_gdbserver_tests if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Make sure we're disconnected, in case we're testing with an diff --git a/gdb/testsuite/gdb.server/inferior-args.exp b/gdb/testsuite/gdb.server/inferior-args.exp index 312e756f0d80..f6ad3e69b407 100644 --- a/gdb/testsuite/gdb.server/inferior-args.exp +++ b/gdb/testsuite/gdb.server/inferior-args.exp @@ -35,7 +35,7 @@ if { $gdbserver == "" } { standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile]} { - return -1 + return } # EXTENDED_P is a boolean, when true gdbserver is started with --multi, and diff --git a/gdb/testsuite/gdb.server/monitor-exit-quit.exp b/gdb/testsuite/gdb.server/monitor-exit-quit.exp index c5f8426cb5de..cb90169ef0cc 100644 --- a/gdb/testsuite/gdb.server/monitor-exit-quit.exp +++ b/gdb/testsuite/gdb.server/monitor-exit-quit.exp @@ -24,7 +24,7 @@ standard_testfile server.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } save_vars { GDBFLAGS } { diff --git a/gdb/testsuite/gdb.server/no-thread-db.exp b/gdb/testsuite/gdb.server/no-thread-db.exp index e04e43c78a3c..9cbe962bc3c0 100644 --- a/gdb/testsuite/gdb.server/no-thread-db.exp +++ b/gdb/testsuite/gdb.server/no-thread-db.exp @@ -28,7 +28,7 @@ set unresolvable_thread_db_path "/foo/bar" require allow_gdbserver_tests if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { - return -1 + return } save_vars { GDBFLAGS } { diff --git a/gdb/testsuite/gdb.server/pread-offset-size.exp b/gdb/testsuite/gdb.server/pread-offset-size.exp index 4362878c8e6e..68f938d42c67 100644 --- a/gdb/testsuite/gdb.server/pread-offset-size.exp +++ b/gdb/testsuite/gdb.server/pread-offset-size.exp @@ -24,7 +24,7 @@ standard_testfile .S if { [prepare_for_testing ${testfile}.exp $testfile \ $srcfile {debug additional_flags=-nostdlib} ] } { - return -1 + return } clean_restart diff --git a/gdb/testsuite/gdb.server/remote-read-msgs.exp b/gdb/testsuite/gdb.server/remote-read-msgs.exp index 86c2d610c00b..e9d03388e398 100644 --- a/gdb/testsuite/gdb.server/remote-read-msgs.exp +++ b/gdb/testsuite/gdb.server/remote-read-msgs.exp @@ -32,12 +32,12 @@ standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile \ {debug build-id}] == -1} { - return -1 + return } # Split out BINFILE.debug. Remove debug from BINFILE. if {[gdb_gnu_strip_debug $binfile] != 0} { - return -1 + return } # Get the '.build-id/xx/xxx...xxx' part of the filename. diff --git a/gdb/testsuite/gdb.server/run-without-local-binary.exp b/gdb/testsuite/gdb.server/run-without-local-binary.exp index 3aa9eba2d05d..24521f21b0f9 100644 --- a/gdb/testsuite/gdb.server/run-without-local-binary.exp +++ b/gdb/testsuite/gdb.server/run-without-local-binary.exp @@ -20,7 +20,7 @@ require allow_gdbserver_tests standard_testfile normal.c if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] diff --git a/gdb/testsuite/gdb.server/server-connect.exp b/gdb/testsuite/gdb.server/server-connect.exp index bb6a5758d359..3c8dd114166a 100644 --- a/gdb/testsuite/gdb.server/server-connect.exp +++ b/gdb/testsuite/gdb.server/server-connect.exp @@ -28,7 +28,7 @@ require allow_gdbserver_tests require {!is_remote target} if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } # Make sure we're disconnected, in case we're testing with an diff --git a/gdb/testsuite/gdb.server/server-exec-info.exp b/gdb/testsuite/gdb.server/server-exec-info.exp index 7163785348d9..4ef9ede9cec0 100644 --- a/gdb/testsuite/gdb.server/server-exec-info.exp +++ b/gdb/testsuite/gdb.server/server-exec-info.exp @@ -22,7 +22,7 @@ require allow_gdbserver_tests allow_shlib_tests standard_testfile server.c if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { - return -1 + return } # Make sure we're disconnected, in case we're testing with an diff --git a/gdb/testsuite/gdb.server/server-kill-python.exp b/gdb/testsuite/gdb.server/server-kill-python.exp index 09e4d561bee9..7c08090c1656 100644 --- a/gdb/testsuite/gdb.server/server-kill-python.exp +++ b/gdb/testsuite/gdb.server/server-kill-python.exp @@ -27,7 +27,7 @@ require allow_gdbserver_tests allow_python_tests if {[build_executable "failed to prepare" ${testfile} \ ${srcfile}] == -1} { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 9a92ef2a6c75..d4bbb466f04c 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -25,7 +25,7 @@ standard_testfile require allow_gdbserver_tests if { [build_executable "failed to prepare" ${testfile}] } { - return -1 + return } # Spawn GDBserver, run to main, extract GDBserver's PID and save it in diff --git a/gdb/testsuite/gdb.server/server-mon.exp b/gdb/testsuite/gdb.server/server-mon.exp index 8811a0c8afa7..ef054059faf8 100644 --- a/gdb/testsuite/gdb.server/server-mon.exp +++ b/gdb/testsuite/gdb.server/server-mon.exp @@ -24,7 +24,7 @@ standard_testfile server.c require allow_gdbserver_tests if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Make sure we're disconnected, in case we're testing with an diff --git a/gdb/testsuite/gdb.server/server-pipe.exp b/gdb/testsuite/gdb.server/server-pipe.exp index ca9d9cab8b67..724e5a047b1e 100644 --- a/gdb/testsuite/gdb.server/server-pipe.exp +++ b/gdb/testsuite/gdb.server/server-pipe.exp @@ -42,7 +42,7 @@ standard_testfile normal.c set executable ${testfile} if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # Start GDB using remote type TARGET, which should be either "remote" diff --git a/gdb/testsuite/gdb.server/server-run.exp b/gdb/testsuite/gdb.server/server-run.exp index 776851b36955..a20ef0a5a1fc 100644 --- a/gdb/testsuite/gdb.server/server-run.exp +++ b/gdb/testsuite/gdb.server/server-run.exp @@ -24,7 +24,7 @@ standard_testfile server.c require allow_gdbserver_tests if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } save_vars { GDBFLAGS } { diff --git a/gdb/testsuite/gdb.server/solib-list.exp b/gdb/testsuite/gdb.server/solib-list.exp index ab0fd1586cb1..c529bb6edd06 100644 --- a/gdb/testsuite/gdb.server/solib-list.exp +++ b/gdb/testsuite/gdb.server/solib-list.exp @@ -32,7 +32,7 @@ set binlibfile [standard_output_file ${testfile}.so] if { [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfile}" "${binlibfile}" {debug}] != "" || [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "shlib=${binlibfile} build-id"] != "" } { untested "failed to compile" - return -1 + return } set interp_system [section_get ${binfile} .interp] diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp index 01bf3ef67dca..a7eda3f76f06 100644 --- a/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp +++ b/gdb/testsuite/gdb.server/stop-reply-no-thread-multi.exp @@ -34,7 +34,7 @@ require allow_gdbserver_tests standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile {debug pthreads}] == -1 } { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] diff --git a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp index fec2246b4791..700b70224151 100644 --- a/gdb/testsuite/gdb.server/stop-reply-no-thread.exp +++ b/gdb/testsuite/gdb.server/stop-reply-no-thread.exp @@ -26,7 +26,7 @@ require allow_gdbserver_tests standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile] == -1 } { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] diff --git a/gdb/testsuite/gdb.server/sysroot.exp b/gdb/testsuite/gdb.server/sysroot.exp index 634168db4693..7e4a796e8791 100644 --- a/gdb/testsuite/gdb.server/sysroot.exp +++ b/gdb/testsuite/gdb.server/sysroot.exp @@ -24,7 +24,7 @@ require allow_gdbserver_tests standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile "additional_flags=--no-builtin"] == -1} { - return -1 + return } set target_binfile [gdb_remote_download target $binfile] diff --git a/gdb/testsuite/gdb.server/target-exec-file.exp b/gdb/testsuite/gdb.server/target-exec-file.exp index 7c204cc9abde..a9e6f801165d 100644 --- a/gdb/testsuite/gdb.server/target-exec-file.exp +++ b/gdb/testsuite/gdb.server/target-exec-file.exp @@ -26,7 +26,7 @@ require allow_gdbserver_tests !use_gdb_stub standard_testfile if { [build_executable "failed to prepare" $testfile $srcfile debug] } { - return -1 + return } clean_restart @@ -223,7 +223,7 @@ set res [remote_exec target "touch $target_exec"] set status [lindex $res 0] if { $status != 0 } { fail "touching executable on target" - return -1 + return } # Start the inferior again, we expect to see the symbols being re-read diff --git a/gdb/testsuite/gdb.server/twice-connect.exp b/gdb/testsuite/gdb.server/twice-connect.exp index eaf910179f7f..45f2eb5aa596 100644 --- a/gdb/testsuite/gdb.server/twice-connect.exp +++ b/gdb/testsuite/gdb.server/twice-connect.exp @@ -23,7 +23,7 @@ require allow_gdbserver_tests if { [build_executable "failed to prepare" $::testfile $::srcfile \ {debug}] } { - return -1 + return } # Don't use $binfile arg, to make sure we use the remote file target:$binfile. diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp index 9478640c40e2..15643fb92a7c 100644 --- a/gdb/testsuite/gdb.server/wrapper.exp +++ b/gdb/testsuite/gdb.server/wrapper.exp @@ -26,7 +26,7 @@ require allow_gdbserver_tests if { [istarget *-*-mingw*] || [istarget *-*-cygwin*] } { unsupported "gdbserver does not support --wrapper on this target (PR server/15967)" - return -1 + return } save_vars { GDBFLAGS } {