From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6SZbHR8F72ky5z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:41:35 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=t7G+td7v; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 72E5F1E0BA; Mon, 27 Apr 2026 02:41:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 978171E093 for ; Mon, 27 Apr 2026 02:41:34 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 470184BB5935 for ; Mon, 27 Apr 2026 06:41:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 470184BB5935 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=t7G+td7v Received: from mail-dy1-x1334.google.com (mail-dy1-x1334.google.com [IPv6:2607:f8b0:4864:20::1334]) by sourceware.org (Postfix) with ESMTPS id 0A0F04B99F7F for ; Mon, 27 Apr 2026 06:36:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A0F04B99F7F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0A0F04B99F7F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271812; cv=none; b=GnnfoGnds2p9VKVsnaCv8v8AeLVLnnYrT4lRI/7ih5PJCzN0Gb0Yjn8OOx4fyRlqIidMnM5Y1R80DvVQVBY8as8ZyYR9M+EOy3aRsTPNXCYSh3TOAEPttvJxIN3eHQx2t7tkoz8pinCjrweDmjcktdoddr9P16to9J7ISvwE0tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271812; c=relaxed/simple; bh=88YBD9LrWBDIGjt/swxU3vW2Jx5FTb09bHX+482uJh4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=O1Li1SW5c5GWiB+Tpqoe/FMPkLn6FSVy6/BY2fjPekZYonpaGcWtdWL6rkueSSgQx9pmlHiNixHXF4I7JpYKowP8UpnhoTYF5M6VqHV1chLS7mIh2x/2hToUO0qB+bKsilJ3YZLOYWCsNXoGzqV8LYD6/v6/ZBAyoWnjrnu6u1I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A0F04B99F7F Received: by mail-dy1-x1334.google.com with SMTP id 5a478bee46e88-2de831d2b20so3031177eec.1 for ; Sun, 26 Apr 2026 23:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271811; x=1777876611; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nensdobtXhQLUnZluWsr/JZbBXRGnZ+IeadJjfVHS90=; b=t7G+td7v5qS6cpo+AVmLyN4C0EVPHN8LQKdexFQs+CC0Jp1+0IM2cm+v+URwWAvnsO nTlg4BFzM4Nlk0BAqhwuE0NDwk9XqJBmEj6xC5ja0ihI2oaA05W0HoMKWeUwE9EkzZHt mlfP9tB7l1hb32tLBJuBVC14slOE7q2gkDaX5Qmm1JG78jkXWPjVMXn4ONAGXcmkGFng NtSYGIMti2562J+fSrXhVZImyQN0lnoTD35F174MXkpG8aJ9WkbV3q0za51YzMd7HapG GHKiqDgN03KtGH2lMS+FL21KfkcqlNYQ2a6IMgwaTThsV6pNsIMAGyE28FUAfzGUgvvL IutQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271811; x=1777876611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nensdobtXhQLUnZluWsr/JZbBXRGnZ+IeadJjfVHS90=; b=YsNU33EqiiG1CQBxSUhmQJNRvwwYcduOIlE1Le/DzKCisUTrJMyUV1wC+W9uquCpzY OPTFH0lr9f/vMjL6U0U1YSxj0WRcQ/dINaMqtgQ7QbXh1wE3urqjM3Bs/qwlJ4IS3pCR ifQFOyHwAkQ/lgAB92AaDdSasJa5mMx/1TqpJGnIinTxBZMeJswbqfRl6JCv1+up7oNW MHaZIWAbrL2SIHfvHh4Kdfnn85UPeVpL6la20/j8YhgDBm5gSwIG5ikyFdNB1AYkDEcJ P2cOD1ke6/ePuPK/2EmfdsPKb8EI8xwZeMxlRaQkXc9TzBCVRLZwHTmIAqFkM1hREyss rLzA== X-Gm-Message-State: AOJu0YyDiGzmNBRrTWZ8q3AJWK403g8T8nrPZnjiG34oQjifU/DYD7ty Lm/mAd9314gqpl6f4BLsH7If69yB50KTVxOW+5CplHnizo6ZI+JSgCo3vgTi43RmQtGtSya+F6z R/aOX X-Gm-Gg: AeBDievTDGACpPFAj873LOBJVvQy2wFTVW+vt7vpfvM6Y56e3VNXSaLY1u0encCDsJt otp3VPVF+CXmLUit6AenbD7ec211Wuol8GC/WkED9OQ0wQEciIq8J7HBp31pDL/gzUapORCwRMg FYAnM7nmAIqmDZFVN9gNwvt1Y+J/+7OCRfV2ZYR4BXp/JhGfnW+GzO3v6acUP7Dcoj3IvMiKwEO hL8q2BPvE/4f9dkHFzdQFc90R44uRsa1HPGwaGZMGoGKiFBnPml9sMwBeGd9TmVXo41eo7RRpRe njb+jBjNDxxwiF8DQTY7fO1q+j7vaBIANuS08+Ur6UFWO1dZ/ArcK2BMRSCJtJrprbMcRJzAQs1 aebSgPBl/CARsMjszMdnA8rRGr8yi0dKSEK7cUWg/Z175QseQxUfBJNLQS+s1RK3RO12eg/oWNQ MkXBHOv6kb3zbKqmsITsYY/8HjyZHJ5TtnVW++iATHLr0K X-Received: by 2002:a05:693c:3007:b0:2be:2cfe:68b7 with SMTP id 5a478bee46e88-2e465293e13mr21528735eec.11.1777271810839; Sun, 26 Apr 2026 23:36:50 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccce0f5sm42059747eec.17.2026.04.26.23.36.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:36:50 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 28/36] GDB: testsuite: reverse: Don't return -1 from top-level (manual) Date: Mon, 27 Apr 2026 03:34:52 -0300 Message-ID: <20260427063500.3847618-29-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch manually changes most "return -1" statements that weren't caught by the sed command. These return statements fall into one of these criteria: - misaligned line, which is then fixed by this patch; - return at top level but inside block such as with_test_prefix, foreach_with_prefix, with_timeout_factor, gdb_test_multiple. --- gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp | 2 +- gdb/testsuite/gdb.reverse/func-map-to-same-line.exp | 2 +- gdb/testsuite/gdb.reverse/i386-sse-reverse.exp | 6 +++--- gdb/testsuite/gdb.reverse/maint-print-instruction.exp | 2 +- gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp | 2 +- gdb/testsuite/gdb.reverse/sigall-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/sigall-reverse.exp | 2 +- gdb/testsuite/gdb.reverse/singlejmp-reverse.exp | 4 ++-- gdb/testsuite/gdb.reverse/solib-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/solib-reverse.exp | 2 +- gdb/testsuite/gdb.reverse/until-precsave.exp | 2 +- gdb/testsuite/gdb.reverse/until-reverse.exp | 2 +- 12 files changed, 15 insertions(+), 15 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp index 19ebebf6a126..0432dd47cc08 100644 --- a/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp +++ b/gdb/testsuite/gdb.reverse/finish-reverse-bkpt.exp @@ -49,7 +49,7 @@ if { [prepare_for_testing "failed to prepare" "$testfile" $srcfile] } { } if {![runto_main]} { - return 0 + return } if {[supports_process_record]} { diff --git a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp index dd36528eb3ef..76febe312f58 100644 --- a/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp +++ b/gdb/testsuite/gdb.reverse/func-map-to-same-line.exp @@ -133,7 +133,7 @@ foreach_with_prefix column_info_flag {column-info no-column-info} { if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \ $options]} { - return -1 + return } run_tests diff --git a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp index dc1308861e2c..3ed1d7e6fae2 100644 --- a/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp +++ b/gdb/testsuite/gdb.reverse/i386-sse-reverse.exp @@ -64,7 +64,7 @@ gdb_test_multiple "continue" $test { } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-sse-reverse - return -1 + return } } @@ -590,7 +590,7 @@ gdb_test_multiple "continue" $test { } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-ssse3-reverse - return -1 + return } } @@ -666,7 +666,7 @@ gdb_test_multiple "continue" $test { } -re " Illegal instruction.*\r\n$gdb_prompt $" { untested i386-sse4-reverse - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp index ad8009b415a9..edf6ec081cdf 100644 --- a/gdb/testsuite/gdb.reverse/maint-print-instruction.exp +++ b/gdb/testsuite/gdb.reverse/maint-print-instruction.exp @@ -46,7 +46,7 @@ proc test_print { has_history level test_name } { } if { ![runto_main] } { - return 0 + return } #confirm that GDB doesn't go crazy if recording isn't enabled diff --git a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp index d34fe130e8e5..b175774aee4f 100644 --- a/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp +++ b/gdb/testsuite/gdb.reverse/next-reverse-bkpt-over-sr.exp @@ -49,7 +49,7 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { } if {![runto_main]} { - return 0 + return } if {[supports_process_record]} { diff --git a/gdb/testsuite/gdb.reverse/sigall-precsave.exp b/gdb/testsuite/gdb.reverse/sigall-precsave.exp index d8bc6dfaccfa..5ce7de0ea1fe 100644 --- a/gdb/testsuite/gdb.reverse/sigall-precsave.exp +++ b/gdb/testsuite/gdb.reverse/sigall-precsave.exp @@ -258,7 +258,7 @@ gdb_test_multiple "continue" "run to end of main" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/sigall-reverse.exp b/gdb/testsuite/gdb.reverse/sigall-reverse.exp index 2dae1933d818..45bb49ecfebe 100644 --- a/gdb/testsuite/gdb.reverse/sigall-reverse.exp +++ b/gdb/testsuite/gdb.reverse/sigall-reverse.exp @@ -239,7 +239,7 @@ with_test_prefix "sig-test-1" { foreach sig [lrange $signals 1 end] { test_one_sig $sig if { $record_instruction_kfail } { - return -1 + return } } } diff --git a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp index 830292cd6669..dfa8ac179f07 100644 --- a/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp +++ b/gdb/testsuite/gdb.reverse/singlejmp-reverse.exp @@ -24,13 +24,13 @@ if {[info exists COMPILE]} { ${testfile}.c {debug optimize=-O2} \ ${testfile}-nodebug.c {optimize=-O2} \ ] == -1 } { - return -1 + return } } else { require is_x86_64_m64_target if { [build_executable ${testfile}.exp ${testfile} \ [list ${srcfile} ${srcfile2}] {}] == -1 } { - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/solib-precsave.exp b/gdb/testsuite/gdb.reverse/solib-precsave.exp index ef3229c74927..cad30320048b 100644 --- a/gdb/testsuite/gdb.reverse/solib-precsave.exp +++ b/gdb/testsuite/gdb.reverse/solib-precsave.exp @@ -80,7 +80,7 @@ gdb_test_multiple "continue" "run to end of main" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/solib-reverse.exp b/gdb/testsuite/gdb.reverse/solib-reverse.exp index c5a610fcb391..b5f49fb72994 100644 --- a/gdb/testsuite/gdb.reverse/solib-reverse.exp +++ b/gdb/testsuite/gdb.reverse/solib-reverse.exp @@ -77,7 +77,7 @@ gdb_test_multiple "until $end_part_one" "run until end part one" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } diff --git a/gdb/testsuite/gdb.reverse/until-precsave.exp b/gdb/testsuite/gdb.reverse/until-precsave.exp index 411fc14fed27..075a87dc2d87 100644 --- a/gdb/testsuite/gdb.reverse/until-precsave.exp +++ b/gdb/testsuite/gdb.reverse/until-precsave.exp @@ -52,7 +52,7 @@ with_timeout_factor 20 { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } } } diff --git a/gdb/testsuite/gdb.reverse/until-reverse.exp b/gdb/testsuite/gdb.reverse/until-reverse.exp index 74703223c643..19ec2fee6b05 100644 --- a/gdb/testsuite/gdb.reverse/until-reverse.exp +++ b/gdb/testsuite/gdb.reverse/until-reverse.exp @@ -53,7 +53,7 @@ gdb_test_multiple "advance factorial" "" { } -wrap -re "Process record does not support instruction 0xfae64 at.*" { kfail "gdb/25038" $gdb_test_name - return -1 + return } }