From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id g98iNr0E72ky5z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:39:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=l2GuP4Lr; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A9E771E093; Mon, 27 Apr 2026 02:39:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F24961E093 for ; Mon, 27 Apr 2026 02:39:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0F04A4BB3BAD for ; Mon, 27 Apr 2026 06:39:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F04A4BB3BAD Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=l2GuP4Lr Received: from mail-dl1-x122b.google.com (mail-dl1-x122b.google.com [IPv6:2607:f8b0:4864:20::122b]) by sourceware.org (Postfix) with ESMTPS id 47A4C4BAE7F8 for ; Mon, 27 Apr 2026 06:36:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47A4C4BAE7F8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47A4C4BAE7F8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::122b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271787; cv=none; b=TsxEaT4sBa+0hiCZcaa7AIUMDOw2SUShRxpC5Hvzz2uJjsPXc8KdzA+/3ktbEVGRIELyHNEK1YhkZJcYU0vKN+nsOfCuXEFZY0j3dc31HBHrh3Xw0FhQYWPEKKf/FPwmjQQd436zsywVycpNDWp6J3EX/yxv/pddfDMVnj6DV7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271787; c=relaxed/simple; bh=NyUuLz5s3neM+pfxPqsO6xS3tGZBGQY3jOX2hkYwoiQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x4gfLsyxpP55Ys3/oQ9WTe0uiDNw53wNtmg3lgOHaSZ15uetDcuIs6yqSSu9tCgLe34G+uC2TdzmDha132epxkWI9LGlWYuROI4wx9gr5gru3CRTNw+/0v/ECKuDqtlUmZonC+1Src8O2CGf8FN8yO4h23Y5nffTn2xTAGjNNIw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47A4C4BAE7F8 Received: by mail-dl1-x122b.google.com with SMTP id a92af1059eb24-12db7bf1541so6732632c88.0 for ; Sun, 26 Apr 2026 23:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271786; x=1777876586; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8oIMlWKIHW3ZSdiM81+gqzKLc/hLO6mBPy/enwX26IQ=; b=l2GuP4LrzyLsAB76u9n6Zj/qLZklEfiB0HijzrwuALyYWblqQi1tqBWRApN3vyMKyO TwWS/XGoyx/kTExe/Xsd4z49ynGSAXXY7dnuIT094tCRTjC+o+szdHwOnQAvKK8AmM/5 HRMmGXsD1szW+0myXHySZPlZsY29t/cR545DGBAzRgdWiBz15xqhC+qKOd5ciAPScLyz Z0K6n52GbLMyEchikcx7pXbMLd8cR7Cu1dI/UuJy+dsuvNBI6yLDGso9SujKei7pK9iC 7G18k6MH8+CECcqM4vouX2F1YtZfbxw2AeAhOGQL9Sr5QRSxOg8+jUD2xgtyXAl0vZib Iv4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271786; x=1777876586; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8oIMlWKIHW3ZSdiM81+gqzKLc/hLO6mBPy/enwX26IQ=; b=rPVJk/oDarKQ36FVU4HaPDXuAati5rePt8Tp5hlYRm2JV7wQhEksa8dbaNIsN3Patz CnNhewmN6vavn6ENneqzmZdeBB1zlbzOkH3o7YSExxRCfZPw3OBL+pkdiERlac3DHclv ms2iypQacyk0n+Z+g9+nRmKFS8ACX/YVEqNJHOMTJ20OEO9EA3xS10adnHK2Xx3/IWJj LMwm42oexCmtKDCr4QHJVvPVbS9TVGujrZ3NuKa5ctP8OsNbdr8CN8LBaluXcRPmpZj8 4wrzwbqUHU0II8I8s0/0Di5+xwlFOYp7StEzMJEf2U0Qi9nGtkNNQkTMAtCe6sEJQk50 JqlA== X-Gm-Message-State: AOJu0Yx+t/+4yBB88YeOPmL/BB6YisN2oYBDaa3wOvRBFZkM4FbwjOdR OBNX4PkO1ol6gT9CNOROGrichlUIU+AI9wXuP/INFjLS6/2NFDjt8sLyxTdXlCGEtYCXmmF6xaT 3Ul9T X-Gm-Gg: AeBDieufP5FodzjoTSEF9RsMxEeo9FC9yM8bImZA7u1qWL9HlRc6/V4hhsvrIaKJC1y acq4BQC2fwwOjU/wqu/YxbxRtDFVAbvJBfNutdOD+m98CopK35pTECL6EP7ftJlhUPRjmMQ6dk+ KJUuhNUMpi68ormqKqMVewrDtzftcO6duq2vs9E29h8tgUsXln6+0r6rqPkXMfnNZxT+MHXZ5hY THgCGK5K0K//lgmGXxVGY3C4t/qfFOFEvohlky1GLS3TxjLrAUfB7p6no94V1n6bQYpPqEUpNf9 YzhVdY93jvD0Sh+PDfF/YIH8vs6bsM6EOXw9wOkxANwaBquj83iXxJDpWIy0lgI2xHGB/y7D2Pe 3Ett+y3caClUAUf6yJQbIgPXab+fuBnNTerDRT2+/6s3cM7ovVB67G7pth8tuPisUmOARb4rkEK mgyIS/FoXwLxv6gypUVLpXnoDSAe8yeP3Hwf05xr0Ihkak X-Received: by 2002:a05:7022:6627:b0:11b:f056:a19b with SMTP id a92af1059eb24-12c73f930c1mr24061162c88.18.1777271786084; Sun, 26 Apr 2026 23:36:26 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c74a20eb5sm55715934c88.14.2026.04.26.23.36.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:36:25 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 21/36] GDB: testsuite: Guile: Don't return -1 from top-level Date: Mon, 27 Apr 2026 03:34:45 -0300 Message-ID: <20260427063500.3847618-22-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Most changes are the result of running: $ sed -i 's/^ return -1/ return/' *.exp inside gdb/testsuite/gdb.guile. The exceptions are in scm-breakpoint.exp, and are inside procedures whose callers don't use the return value; --- gdb/testsuite/gdb.guile/scm-block.exp | 2 +- gdb/testsuite/gdb.guile/scm-breakpoint.exp | 8 ++++---- gdb/testsuite/gdb.guile/scm-frame.exp | 2 +- gdb/testsuite/gdb.guile/scm-iterator.exp | 2 +- gdb/testsuite/gdb.guile/scm-progspace.exp | 2 +- gdb/testsuite/gdb.guile/scm-symbol.exp | 4 ++-- gdb/testsuite/gdb.guile/types-module.exp | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.guile/scm-block.exp b/gdb/testsuite/gdb.guile/scm-block.exp index 8027dc0ce193..c5e2fd4403bc 100644 --- a/gdb/testsuite/gdb.guile/scm-block.exp +++ b/gdb/testsuite/gdb.guile/scm-block.exp @@ -23,7 +23,7 @@ require allow_guile_tests standard_testfile if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { - return -1 + return } if {![gdb_guile_runto_main]} { diff --git a/gdb/testsuite/gdb.guile/scm-breakpoint.exp b/gdb/testsuite/gdb.guile/scm-breakpoint.exp index 68744bb87f7f..c0f6f56ff449 100644 --- a/gdb/testsuite/gdb.guile/scm-breakpoint.exp +++ b/gdb/testsuite/gdb.guile/scm-breakpoint.exp @@ -23,7 +23,7 @@ require allow_guile_tests standard_testfile if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { - return -1 + return } proc_with_prefix test_bkpt_basic { } { @@ -491,7 +491,7 @@ proc_with_prefix test_bkpt_temporary { } { clean_restart ${testfile} if {![gdb_guile_runto_main]} { - return 0 + return } delete_breakpoints @@ -532,7 +532,7 @@ proc_with_prefix test_bkpt_probe {} { if { [prepare_for_testing "failed to prepare" ${testfile}-probes \ ${srcfile} {additional_flags=-DUSE_PROBES}] } { - return -1 + return } if {![gdb_guile_runto_main]} { @@ -571,7 +571,7 @@ proc_with_prefix test_catchpoints {} { gdb_test_multiple "catch syscall" "" { -re "The feature \'catch syscall\' is not supported.*\r\n$gdb_prompt $" { unsupported "catch syscall isn't supported" - return -1 + return } -re "Catchpoint ($decimal) \\(any syscall\\)\r\n$gdb_prompt $" { set num $expect_out(1,string) diff --git a/gdb/testsuite/gdb.guile/scm-frame.exp b/gdb/testsuite/gdb.guile/scm-frame.exp index 8c86b7a8249b..7db24f6e4e9a 100644 --- a/gdb/testsuite/gdb.guile/scm-frame.exp +++ b/gdb/testsuite/gdb.guile/scm-frame.exp @@ -23,7 +23,7 @@ require allow_guile_tests standard_testfile if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { - return -1 + return } # The following tests require execution. diff --git a/gdb/testsuite/gdb.guile/scm-iterator.exp b/gdb/testsuite/gdb.guile/scm-iterator.exp index 6907ec2d8699..cdbaf20d6995 100644 --- a/gdb/testsuite/gdb.guile/scm-iterator.exp +++ b/gdb/testsuite/gdb.guile/scm-iterator.exp @@ -23,7 +23,7 @@ require allow_guile_tests standard_testfile if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { - return -1 + return } if {![gdb_guile_runto_main]} { diff --git a/gdb/testsuite/gdb.guile/scm-progspace.exp b/gdb/testsuite/gdb.guile/scm-progspace.exp index 306d08769e8d..3b73ecb82330 100644 --- a/gdb/testsuite/gdb.guile/scm-progspace.exp +++ b/gdb/testsuite/gdb.guile/scm-progspace.exp @@ -23,7 +23,7 @@ require allow_guile_tests standard_testfile if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} { - return -1 + return } clean_restart diff --git a/gdb/testsuite/gdb.guile/scm-symbol.exp b/gdb/testsuite/gdb.guile/scm-symbol.exp index bed817edcc02..6cd1199e9b28 100644 --- a/gdb/testsuite/gdb.guile/scm-symbol.exp +++ b/gdb/testsuite/gdb.guile/scm-symbol.exp @@ -23,7 +23,7 @@ require allow_guile_tests standard_testfile if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } # These tests are done before we call gdb_guile_runto_main so we have to @@ -138,7 +138,7 @@ gdb_test "guile (print (symbol-symtab t))" "= #" # Recompile binary. if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}-cxx" executable "debug c++"] != "" } { untested "failed to compile in C++ mode" - return -1 + return } clean_restart ${::testfile}-cxx diff --git a/gdb/testsuite/gdb.guile/types-module.exp b/gdb/testsuite/gdb.guile/types-module.exp index 9693d4b36559..b48a24742ebf 100644 --- a/gdb/testsuite/gdb.guile/types-module.exp +++ b/gdb/testsuite/gdb.guile/types-module.exp @@ -27,7 +27,7 @@ lappend flags debug lappend flags c++ if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} $flags] } { - return -1 + return } if {![gdb_guile_runto_main]} {