From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8X1YDEME72n/4z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:37:55 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=kMx+xKGy; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2E2B01E0BA; Mon, 27 Apr 2026 02:37:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 79D361E093 for ; Mon, 27 Apr 2026 02:37:54 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id F117F4BB1C34 for ; Mon, 27 Apr 2026 06:37:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F117F4BB1C34 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=kMx+xKGy Received: from mail-dy1-x132b.google.com (mail-dy1-x132b.google.com [IPv6:2607:f8b0:4864:20::132b]) by sourceware.org (Postfix) with ESMTPS id 5DADE4BB1C1F for ; Mon, 27 Apr 2026 06:36:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DADE4BB1C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5DADE4BB1C1F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::132b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271783; cv=none; b=VJqM7l/NVYckGrJJ97Fj5U6vrCsEb1Z0rtidmXIOhR4Jels0gHPC+eSmYxBVZvAjSj5g3yMaw/rSoUwyfX/d4vaYWa1ajTCNZ2h9Mysp+A2lKo3FXxoZ+DmK1XaBxcPTlbL/qeIq8YA+M/YT5CS1BtOcNpb5M/i5Q4kPCWbblDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271783; c=relaxed/simple; bh=XsgnpjFQaeKArt8elFyLRhe4WDn9bvTxDZrTgFlYCE0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uMTaB0dfNC9++bm14I40M38XUN6wA2AKXAJkS0osQ3C6OCwt8YC0ISx6japwileYnGgx5ADoQPFzXVjZULVUVrae2Yq1s1Rmzivj0C0T249OAd/TScPuoY594Jh1TyeXLxmB8z2XyNZ4REQFpgudCYBfynL4T0iskM6LX5yNDAo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DADE4BB1C1F Received: by mail-dy1-x132b.google.com with SMTP id 5a478bee46e88-2ba895adfeaso10393078eec.0 for ; Sun, 26 Apr 2026 23:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271782; x=1777876582; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9E340XqtIllYnioa4Nx6BPv0gkNeH85l3NGDGQ97Uxo=; b=kMx+xKGyoDEZS/fmdoB6v/UxE/SRWnboaHpRmevaZevBonfZLORhWJhTLUwYPqNmkK vyfZuiZV3AAI+VxCDuALodcWtq8EdecdX0SizU5XHHRdH5+B2+3qqfpYf0s1z06yBJz7 9q4I6SDwh9Mt4xKpBxHiBpvgt8iA+SeHmBpe8KGIQhT+H71asqs99JumTj1/RWMOhnh/ C8S30nGu1HtSva9hHo/353r7bGCWA9X2MzKaLHMXDyJpZHuyLhgnv9Yc00jZl4eRq8l+ N3h18RVGQffj243vBeLBJ1d7EPxxCLul/3cnxeoX6cFgXejW/e+AqGWXGgxn2SNSgMUg ojSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271782; x=1777876582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9E340XqtIllYnioa4Nx6BPv0gkNeH85l3NGDGQ97Uxo=; b=E34W+g4HsMFidQy5oHSsnxx+a3CsI3MrrG559cuF+xED3SZg1+mcl7HiVuxvRhyIfv sglHTNc3BDUoaDK+lvDhEYlhNzH3gykMxCcf95BD9XYxluZiCcOFHeYjYo/B/P0IQbUE 9vC0wZt2V+a/fTj8GjZL3ft8m5NCt3sQq6xP1SNCv/isWtfCDIFRvVw17nv8Lx/UEyJ9 /glbHczp5kQh/AagSYAnlI9NUSKRmAtRwmtqFByFozXmxGeDhafH+XKSlJF66qV7RyUa CigAGTXJYIFbJIZ3D1jpfQTvt9KwZ6wywVVyH7DruvhD/fNIdWjkFky5rzwAhGdk9paN 7zwQ== X-Gm-Message-State: AOJu0YwLwWCFtn5no0s+LCRMWq1d4ojDHmUJbWm2ER7nkIHRwHzDkQAU s2BHOV/mivoF/Q1GMOBf7JFCm7u4H2/32G/Xr1L8gxSHnwDXPf2gM5lcDBcDinvhn94oDxMfDBH y9PPF X-Gm-Gg: AeBDiesQjlriF3loebCp7c2v9N+7PLDCRfNy0WpN4RRhBkwwOvSNaS7iAluxwh2+osS IJ5wZyIuwpFs1PCandzlMYSTiezk3/4JDYCIqPtj3zHlWgX+Mq3rMF5b1nNQsEqw5AIocuiTGjK hb5gT8QpPet6Ko7I5eiQP+gmJLFA8jFJXtOxuVBk0xHmuHOUf6sg8q1VwJrDaFsZGff3mvehxI0 1YQl8UO2sHzUO3C9QdcFjEw6840V4kcPvazGmGVz8nJZXAG81Zn67FSXZyTgxcAEhqp0ZAbDSfk D+TIPWqcFORrDDpqIrLpPvfTSnHlNqXyplH9Rwfj7Tt/WRO5GcxjvzRTCKs0ghc6flENF3m1CgA vfws9jbKWlRWMfgQIDdOEdVG2wSRYLxDpon4x6Wyo7g277C9nNUsCClLIdtCCMN24ovZFmnlofS RogE9fQMX5o47N89q0dV7aTBxCR7SAAs/J0DzUGO6+HZDk X-Received: by 2002:a05:7301:6793:b0:2ca:7eb4:3e0f with SMTP id 5a478bee46e88-2e464dafc32mr21021752eec.5.1777271782221; Sun, 26 Apr 2026 23:36:22 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53d2cfef3sm41164779eec.24.2026.04.26.23.36.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:36:21 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 20/36] GDB: testsuite: GDB: Don't return -1 from top-level Date: Mon, 27 Apr 2026 03:34:44 -0300 Message-ID: <20260427063500.3847618-21-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org All changes except for one are the result of running: $ sed -i 's/^ return -1/ return/' *.exp inside gdb/testsuite/gdb.gdb. The exception is a return statement in index-file.exp, which is inside a with_timeout_factor block. --- gdb/testsuite/gdb.gdb/index-file.exp | 8 ++++---- gdb/testsuite/gdb.gdb/python-helper.exp | 2 +- gdb/testsuite/gdb.gdb/unittest.exp | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gdb/testsuite/gdb.gdb/index-file.exp b/gdb/testsuite/gdb.gdb/index-file.exp index 162ba28bfde1..d0c845302fc2 100644 --- a/gdb/testsuite/gdb.gdb/index-file.exp +++ b/gdb/testsuite/gdb.gdb/index-file.exp @@ -27,14 +27,14 @@ set timeout_factor 20 set filename [selftest_prepare] if { $filename eq "" } { unsupported "${gdb_test_file_name}.exp" - return -1 + return } # If FILENAME is a libtool wrapper, then we need to get the path of the real # executable. set filename [selftest_libtool_get_real_gdb_executable $filename] if { $filename eq "" } { - return -1 + return } with_timeout_factor $timeout_factor { @@ -48,7 +48,7 @@ set worker_threads [gdb_get_worker_threads] if { $worker_threads eq "UNKNOWN" } { unresolved "unable to get worker thread count" - return -1 + return } # Generate an index file. @@ -66,7 +66,7 @@ with_timeout_factor $timeout_factor { } } if { ! $ok } { - return -1 + return } gdb_test_no_output "save gdb-index -dwarf-5 $dir1" \ diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp index b39f51de44fe..8f00ce920af3 100644 --- a/gdb/testsuite/gdb.gdb/python-helper.exp +++ b/gdb/testsuite/gdb.gdb/python-helper.exp @@ -26,7 +26,7 @@ require allow_python_tests standard_testfile .cc if { [build_executable "failed to build" $testfile $srcfile {debug c++}] } { - return -1 + return } # Find the helper script in the GDB build directory. diff --git a/gdb/testsuite/gdb.gdb/unittest.exp b/gdb/testsuite/gdb.gdb/unittest.exp index 29e4206cb309..26870a7a0b7a 100644 --- a/gdb/testsuite/gdb.gdb/unittest.exp +++ b/gdb/testsuite/gdb.gdb/unittest.exp @@ -24,7 +24,7 @@ set do_xml_test [allow_xml_test] standard_testfile if {[build_executable "failed to prepare" $testfile $srcfile debug]} { - return -1 + return } proc run_selftests_1 {} {