From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0Y02FucD72n/4z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:36:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YcBbg/cb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4E2B81E0BA; Mon, 27 Apr 2026 02:36:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9B5D41E093 for ; Mon, 27 Apr 2026 02:36:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6C5414BB1C1F for ; Mon, 27 Apr 2026 06:36:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C5414BB1C1F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=YcBbg/cb Received: from mail-dl1-x1235.google.com (mail-dl1-x1235.google.com [IPv6:2607:f8b0:4864:20::1235]) by sourceware.org (Postfix) with ESMTPS id 3F5694BB1C2D for ; Mon, 27 Apr 2026 06:35:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F5694BB1C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F5694BB1C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271752; cv=none; b=bPFYLPs9UBeIjB/raIzffkcPbVFwqduDO6SFfkV+/D2F4S7E+jgctsAedMeX6y9439661x2tZN+Y+Ge4jD2eBrYV6wC7a2fJiboXz+UG+U4qAMPkiiF/lJeHjwt8T0vD9qpHQ4bBOs76UwAbsISwOHRnqVMZSNC2KMawu4Qrd3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271752; c=relaxed/simple; bh=zCDE9QXJYWZYfNPjJkGEK5vmkWF9VyH0kSD9ZRSj1r8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=B1+oveEd+dCqCsQJE/w5qLYoYZ6NBTso1vRv5KbAnhCnKNacMnrabBaOBk7mkDpRxnbzJfV853k9s5+m7q5X92PQySdwEeuzy0eLsvb7O13nsN25V784XA5CKOAMqt6eDcGwHZsjYOw5qsZrG9Kwhz9yKAF1zDL6aqGuaiDdXSc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3F5694BB1C2D Received: by mail-dl1-x1235.google.com with SMTP id a92af1059eb24-12c88e5f4aeso4115498c88.0 for ; Sun, 26 Apr 2026 23:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271751; x=1777876551; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WGKd9KesrQ7/UYakmNsJJ1JwFZb/0+st+gEBv5T6GMw=; b=YcBbg/cbBCB889LaQboeVN7I3w054iFLWpQImcgvv85qV0yx4z/Y38B9vDi1ALOjDq zTT6K73H7S13x0tF9POFbSSQ9sAJV4j1laQQAY7e34EdKrBocSBIXPwWfkJQMe6ZDPqR 3Sp0Me9CCqfnf3eIxlXuY8pXehxU7650d+sU9n1YtT/T7+3TPcHZdT4DDYmr97HS7Zrz SZe5Nad3FqJn/S5yEl+2OMuVmuXO3jk6JCRc31MXOAJOf4tjuFT5r49qRxBIrKTYNhwY ziEZWUNBDeiJ14q7TdGCRt5CF/W3YxC6xadmySuhgriHnNcV22TJUhXSN/I9xbmT7mQP UtGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271751; x=1777876551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WGKd9KesrQ7/UYakmNsJJ1JwFZb/0+st+gEBv5T6GMw=; b=V9NCbOfDYdeuH2E3dN1rmeYb0EMddLOlpyPVZxi3brhAyK4QFaDvwXGslZ8s2Ri8rT /6OoSabjh1YmcriEqdQ6QaNbft5jQ3ioHo87zMNQpXvtsYUPcHtOq/vhw16A6pHIXC2X 0BPC6qy+EWkAd4AnPPt3x9pmb/SRs8XgLs4CD6YMZKIuEts2zN6+6nVu5LMoWGYpAvr3 5Zbhjcq2mXIQZYMS2WWAncfb5Mr7nidMK7gI+ccr/pFe6z+1alC7pzN7/ecoNnPK53hJ 7AUCZu1kXm7TTGhusj7hgWkw9CfZZqVH42lRZ+3XQSZliKEW0aJva4+2ys4nIJqSqtT0 o0Tg== X-Gm-Message-State: AOJu0YwiJQ++OHx2xIPzk0LUu1BvQy6c7LrYNg0BM729AXrzHNH1Fahy vuqp7wMjx9a2/Z4b7JnI05i8FVpAo0SL0fHSHBA1BDYKAFKxgq+wMmQXR9WOquv6Dy/hD577VXN VCtz8 X-Gm-Gg: AeBDiesDd9IAUhUsDp0l9ZLk8jbMvLoKDMwdgr0gcDgM15WV+hiGwV1iLKDTn4M6Qvd G5fN143DVjmzJ1t0vM+66dB5SC8qypAleOes+18SWdV+fYIB6X1bs87Me16tf6iQpgDw+Oyx/1h 2FHrf96qYtwI1C5/+M5KJct4Hwkm8hQhjAi7aEXL1VO3wAZlTJ/ijaUQpnFhYhCZphWUoLLLoBp 2fx6bz+WpJC98DPV2LRDevDczRmX14hmJRqswc9+nHo61sgJzuk2L3YxiHzfZh9OznRd/Isx+DC y/+MtaUsyulUsbwV/FisLMQjmN0Dew7cZQdA4IpvZ7BKuhqInOMhkr6uoXEDY+kN9XaYUq9AeJz kgufYMHV9mw1jfp5rE+UHw3Tu+ScAbrh9IjSJlIijJRPzNWoLPzcjvV3O2ZpscdLOROiAGU0/G/ apDJs1OUuTW71lNUv+yhXaYbx5oAM6q6MghyAfrj3fTHE1z6uqEvpi5TI= X-Received: by 2002:a05:7022:1281:b0:11c:883d:1ef0 with SMTP id a92af1059eb24-12c73b2c248mr16497503c88.15.1777271751080; Sun, 26 Apr 2026 23:35:51 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12dc9657d22sm16096985c88.9.2026.04.26.23.35.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:35:50 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 12/36] GDB: testsuite: Don't return -1 from top-level in multi-arch tests Date: Mon, 27 Apr 2026 03:34:36 -0300 Message-ID: <20260427063500.3847618-13-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Oddly enough, there are multi-arch arch tests. This patch contains fixes for them. Some changes are the result of running: $ sed -i 's/^ return -1/ return/' *.exp inside gdb/testsuite/gdb.arch and some are manual changes. --- gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp | 6 +++--- gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp | 14 +++++++------- gdb/testsuite/gdb.arch/skip-prologue.exp | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp b/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp index 7d26244129ce..87440a1b28e8 100644 --- a/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp +++ b/gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp @@ -23,11 +23,11 @@ set additional_flags [gdb_target_symbol_prefix_flags] if {[prepare_for_testing "failed to prepare" $executable $srcfile \ [list debug $additional_flags]]} { - return -1 + return } if {![runto_main]} { - return -1 + return } # Read function name from testcases[N]. @@ -49,7 +49,7 @@ proc read_testcase { n } { set n_testcases [get_integer_valueof "n_testcases" 0] if { ${n_testcases} == 0 } { untested "no instruction relocation to test" - return 1 + return } # Set a fast tracepoint on each set_point${i} symbol. There is one for diff --git a/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp b/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp index 0846e0365d42..06eb5a691bdf 100644 --- a/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp +++ b/gdb/testsuite/gdb.arch/ftrace-insn-reloc.exp @@ -21,16 +21,16 @@ set additional_flags [gdb_target_symbol_prefix_flags] if {[prepare_for_testing "failed to prepare" $testfile-no-ipa $srcfile \ [list debug $additional_flags]]} { - return -1 + return } if {![runto_main]} { - return -1 + return } if {![gdb_target_supports_trace]} { unsupported "target does not support trace" - return -1 + return } require allow_in_proc_agent @@ -43,20 +43,20 @@ set libipa [get_in_proc_agent] if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \ executable [list debug $additional_flags shlib=$libipa] ] != "" } { untested "failed to compile" - return -1 + return } clean_restart $testfile set remote_libipa [gdb_load_shlib $libipa] if {![runto_main]} { - return 0 + return } gdb_reinitialize_dir $srcdir/$subdir if { [gdb_test "info sharedlibrary" ".*[file tail $libipa].*" "IPA loaded"] != 0 } { untested "could not find IPA lib loaded" - return 1 + return } # Read function name from testcases[N]. @@ -79,7 +79,7 @@ set n_testcases [gdb_readexpr "n_testcases"] if { ${n_testcases} == 0 } { untested "no instruction relocation to test" - return 1 + return } # Set a fast tracepoint on each set_point${i} symbol. There is one for diff --git a/gdb/testsuite/gdb.arch/skip-prologue.exp b/gdb/testsuite/gdb.arch/skip-prologue.exp index c805356d8746..c53f86250c84 100644 --- a/gdb/testsuite/gdb.arch/skip-prologue.exp +++ b/gdb/testsuite/gdb.arch/skip-prologue.exp @@ -19,7 +19,7 @@ standard_testfile if { [prepare_for_testing "failed to prepare" $testfile $srcfile \ {nodebug}] } { - return -1 + return } proc do_test { f } {