From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2ekVNwUF72ky5z0AWB0awg (envelope-from ) for ; Mon, 27 Apr 2026 02:41:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CGxz/tv4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DC9991E093; Mon, 27 Apr 2026 02:41:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 460241E093 for ; Mon, 27 Apr 2026 02:41:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E492F4BB3BDA for ; Mon, 27 Apr 2026 06:41:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E492F4BB3BDA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=CGxz/tv4 Received: from mail-dl1-x1232.google.com (mail-dl1-x1232.google.com [IPv6:2607:f8b0:4864:20::1232]) by sourceware.org (Postfix) with ESMTPS id BF9DB4BAE7CC for ; Mon, 27 Apr 2026 06:35:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF9DB4BAE7CC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF9DB4BAE7CC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271748; cv=none; b=FRHFsat81lB9L6puhyKtVbeY0obDxRNFTHeK6edRYd+e4VFCXdTzhdm387Av1Kwty5u5TdzCKD3KwtFlphnemsTrgrQwBQ9C7luASwMF9Ibv+IYHm9dFQZSg856VfC8DdZKr8SBELMs1yWbRz178rEh6tpTto71k0yyM6xY6Aog= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777271748; c=relaxed/simple; bh=10qKV78nrra28LYOruhuBK8ab6YClJz5MpP6ELozuzQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oUiOtslMbhLs2mI17ANMA8h+1Mn7qS5zqISSrAxzdOUaEeeZ7fcyF2lthh5cSZ1A5sLdAaHp7cdpB9/efaYKmwWOrpKs7vXqlDry4miFhsng8sysh/mxJkOkRbmfqjqxLxEf4eK9j/PpcGVabVR0j7etWfGcB7lMupQWQWhTFp4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF9DB4BAE7CC Received: by mail-dl1-x1232.google.com with SMTP id a92af1059eb24-12c8f9846c8so9617408c88.0 for ; Sun, 26 Apr 2026 23:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777271748; x=1777876548; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dnvisne1IAf7DXsI6zcndN6tjYnysBdWIn0MmAtI6gU=; b=CGxz/tv4KIWhDWDSp49oJRIp36mxKwSMou2vdgTO1qN69uQUwcaX5WVlnuyGra3Aia RjAAjFCcLDbx4UtSx6Gye+ZsutTEr2PJnkzD2SzfMzfz4xpfqSlMpJMhd3e2Ck18kgfs Veno3xMN3C+uJ7t3kZMcA8hK+1AHw/dkmfiSZME/iwBX+0eVdF6z3Z6Y+KXE2T688F8K xsvwBNxH/F+tsA2giXzB64MGAKsNUyXfVPXW1Fimm6FfQbYCesoA2QFEXVtRjAB1EkRW rs6gd9UtmEYEC4wJjubBvJpWLpl7MOnLowX3QauHQQqSDCSuXNIdY52ZSJLPIX207S3U tbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777271748; x=1777876548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dnvisne1IAf7DXsI6zcndN6tjYnysBdWIn0MmAtI6gU=; b=bmxfQy2zR4vTaXhPNgL6dG6eWXtgi//h8OpaQVLyIcz+pz8mkg/+5ssaOCWe8uQEy9 UUCnS38lyNwHcAzLe9ccT8/+C/axkOihasNpNqROuPEC4ruDSOIFSRUg2qq1pbe3WK6y Ary0q22I6mjIWAq0bhUdbWT0pzVmRD6g+RDgVMJzLlN7TEqizyfLDhJUUjgkiftidliJ 4hR42D80uHrZg0UA/pwGqHpALW43uPUMvVR9JHxFIMeueo5rsNvJmMYq0HQsGl9glvi1 NQMelTQ10kOfsqOuGmXl+/8NfAeAy+4n0wiuUEymc40qFdJmbxTFxdDk93T3Y+oybcSK FsZw== X-Gm-Message-State: AOJu0Yz2gCenHpeOhl3zin9gMeZm6WS88xiZPiwvs/TSwFQ83lTSnlTT KNX3V82kBahGt3pJlPUxI+UPm+pDBQ4YxO65FwX905SpZigE7xMk2xwl7MISAwR0xUDmf5Riu5F ndZUK X-Gm-Gg: AeBDiet2ghPQw8zsBg542xOD7X253/3k61838Cfe68sz+8OvK3hvTlFucwjlVM7x52X q485c5LPCZlYjPo/MNdaerI9ES4QV/6ZjWBoqlUIErbZ4A9Uu+vKWAG6gkN2f0OgRIom1x7sFB2 2UjaPZjMMnBGMB4vWZkLJOEQs0KIncZRWjtM0MgiHDdFkN2Qar3ewP+9euBRDLpb3AX088Xne2Z 69osnuara+s4eruQZcIYxqrVKJtVm3U6jOR2Cxcl6fLZYY7NZIwTQH0/t6Bjj0AF7KKLETDsECQ 6Bqa1ZrTU3wF6NdSwLAtn4K7g1Vnus7iHuXkXvv/eg0vaqCqLxEDeX4irxgyfSMUHqtAu51+9mJ DXBvakopWQZfBbtTQCqoKD7L91xzbT8/PP/YKCFgUDdzsEjXHi76DEFQNf0yN6rNG8IOJ85kkBn E0vVs8+IlJmBHqwdOUDuNVL4XujBdmyI2qhUgoE8qWH9RF X-Received: by 2002:a05:7022:eac1:b0:12c:8d32:9378 with SMTP id a92af1059eb24-12c8d32953bmr17388453c88.32.1777271747609; Sun, 26 Apr 2026 23:35:47 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:33bc:f32e:9aa5:b915]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c74a20eb5sm55713953c88.14.2026.04.26.23.35.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2026 23:35:47 -0700 (PDT) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Subject: [PATCH 11/36] GDB: testsuite: Don't return -1 from top-level in tests of various arches Date: Mon, 27 Apr 2026 03:34:35 -0300 Message-ID: <20260427063500.3847618-12-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260427063500.3847618-1-thiago.bauermann@linaro.org> References: <20260427063500.3847618-1-thiago.bauermann@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch contains fixes for alpha, arc, avr, hppa and sh architectures. Some changes are the result of running: $ sed -i 's/^ return -1/ return/' *.exp inside gdb/testsuite/gdb.arch and some are manual changes. --- gdb/testsuite/gdb.arch/alpha-step.exp | 4 ++-- gdb/testsuite/gdb.arch/arc-analyze-prologue.exp | 2 +- gdb/testsuite/gdb.arch/arc-dbnz.exp | 2 +- gdb/testsuite/gdb.arch/arc-decode-insn.exp | 2 +- gdb/testsuite/gdb.arch/avr-flash-qualifier.exp | 10 +++++----- gdb/testsuite/gdb.arch/gdb1291.exp | 4 ++-- gdb/testsuite/gdb.arch/gdb1431.exp | 4 ++-- gdb/testsuite/gdb.arch/gdb1558.exp | 2 +- gdb/testsuite/gdb.arch/pa-nullify.exp | 8 ++++---- 9 files changed, 19 insertions(+), 19 deletions(-) diff --git a/gdb/testsuite/gdb.arch/alpha-step.exp b/gdb/testsuite/gdb.arch/alpha-step.exp index a15f86ea6567..9d94daa0e64b 100644 --- a/gdb/testsuite/gdb.arch/alpha-step.exp +++ b/gdb/testsuite/gdb.arch/alpha-step.exp @@ -22,7 +22,7 @@ set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {}] != "" } { unsupported "failed to compile" - return -1 + return } clean_restart @@ -33,7 +33,7 @@ proc test_stepi {function } { # of the previous tests, this makes sure that it doesn't affect # this series of tests. if {![runto_main]} { - return 0 + return } # Insert a breakpoint on the FP branch instruction inside FUNCTION. diff --git a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp index 01699016dd67..fe6db11472cc 100644 --- a/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp +++ b/gdb/testsuite/gdb.arch/arc-analyze-prologue.exp @@ -26,7 +26,7 @@ standard_testfile .S set options {} if { [prepare_for_testing "failed to prepare" $testfile $srcfile $options] } { - return -1 + return } if {![runto_main]} { diff --git a/gdb/testsuite/gdb.arch/arc-dbnz.exp b/gdb/testsuite/gdb.arch/arc-dbnz.exp index ce93a6202933..e50bf7a4b187 100644 --- a/gdb/testsuite/gdb.arch/arc-dbnz.exp +++ b/gdb/testsuite/gdb.arch/arc-dbnz.exp @@ -34,7 +34,7 @@ require {istarget "arc*-*-*"} standard_testfile .S if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { - return -1 + return } if {![runto_main]} { diff --git a/gdb/testsuite/gdb.arch/arc-decode-insn.exp b/gdb/testsuite/gdb.arch/arc-decode-insn.exp index 0a7582d03a2a..c23204aa1660 100644 --- a/gdb/testsuite/gdb.arch/arc-decode-insn.exp +++ b/gdb/testsuite/gdb.arch/arc-decode-insn.exp @@ -36,7 +36,7 @@ require {istarget "arc*-*-*"} standard_testfile .S if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { - return -1 + return } if {![runto_main]} { diff --git a/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp b/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp index a62e629f9209..e9a523a5d05a 100644 --- a/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp +++ b/gdb/testsuite/gdb.arch/avr-flash-qualifier.exp @@ -22,18 +22,18 @@ require {istarget "avr*"} # The __flash qualifier was added in GCC 4.7. if {[test_compiler_info {gcc-[0-4]-[0-6]}]} { - verbose "Skipping ${gdb_test_file_name}." - return + verbose "Skipping ${gdb_test_file_name}." + return } standard_testfile if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} { - return -1 + return } if {![runto [gdb_get_line_number "break here."]]} { - untested "could not run to \"break here.\"" - return -1 + untested "could not run to \"break here.\"" + return } gdb_test "print pointer_to_flash" \ diff --git a/gdb/testsuite/gdb.arch/gdb1291.exp b/gdb/testsuite/gdb.arch/gdb1291.exp index 82f9d52e08ba..ba4b88d75112 100644 --- a/gdb/testsuite/gdb.arch/gdb1291.exp +++ b/gdb/testsuite/gdb.arch/gdb1291.exp @@ -30,7 +30,7 @@ set srcfile ${testfile}.s set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ""] != "" } { untested "failed to compile" - return -1 + return } clean_restart @@ -41,7 +41,7 @@ gdb_load $binfile # if {![runto_main]} { - return 0 + return } gdb_test "b sub1" "Breakpoint 2.*" "set breakpoint" diff --git a/gdb/testsuite/gdb.arch/gdb1431.exp b/gdb/testsuite/gdb.arch/gdb1431.exp index 89952275d193..aedf66183186 100644 --- a/gdb/testsuite/gdb.arch/gdb1431.exp +++ b/gdb/testsuite/gdb.arch/gdb1431.exp @@ -32,7 +32,7 @@ set srcfile ${testfile}.s set binfile ${objdir}/${subdir}/${testfile} if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ""] != "" } { untested "failed to compile" - return -1 + return } clean_restart @@ -43,7 +43,7 @@ gdb_load $binfile # if {![runto_main]} { - return 0 + return } gdb_test "advance sub1" "hello world\r\n$hex in sub1 \\(\\)" "get to sub1" diff --git a/gdb/testsuite/gdb.arch/gdb1558.exp b/gdb/testsuite/gdb.arch/gdb1558.exp index 5fbf86f5889a..7a3f44756452 100644 --- a/gdb/testsuite/gdb.arch/gdb1558.exp +++ b/gdb/testsuite/gdb.arch/gdb1558.exp @@ -29,7 +29,7 @@ set binfile ${objdir}/${subdir}/${testfile} # Note we have to compile WITH optimization and WITHOUT debugging information to expose the bug. if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {"additional_flags=-O2"}] != "" } { untested "failed to compile" - return -1 + return } clean_restart diff --git a/gdb/testsuite/gdb.arch/pa-nullify.exp b/gdb/testsuite/gdb.arch/pa-nullify.exp index 1606d44afbf1..e527fe0955d8 100644 --- a/gdb/testsuite/gdb.arch/pa-nullify.exp +++ b/gdb/testsuite/gdb.arch/pa-nullify.exp @@ -37,7 +37,7 @@ set gcorefile ${objdir}/${subdir}/${testfile}.gcore if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {}] != "" } { unsupported "failed to compile" - return -1 + return } clean_restart @@ -87,7 +87,7 @@ proc get_addr_of_sym { sym } { } if {![runto_main]} { - return 0 + return } set foo [get_addr_of_sym "foo"] @@ -123,7 +123,7 @@ proc test_core_bt { test } { set test "core at last insn in foo" if {![runto_main]} { - return 0 + return } gdb_breakpoint "*$foo_last" gdb_test "continue" "Breakpoint \[0-9\]*,.* in foo.*" "$test: continue to breakpoint" @@ -133,7 +133,7 @@ if {[gen_core $test]} { set test "core at nullified insn" if {![runto_main]} { - return 0 + return } gdb_breakpoint "*$foo_last" gdb_test "continue" "Breakpoint \[0-9\]*,.* in foo.*" "$test: continue to breakpoint"