From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eXL6HxTX62m5UzkAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 16:48:20 -0400 Received: by simark.ca (Postfix, from userid 112) id 792DD1E0BA; Fri, 24 Apr 2026 16:48:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D185B1E093 for ; Fri, 24 Apr 2026 16:48:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 744214BB8F58 for ; Fri, 24 Apr 2026 20:48:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 744214BB8F58 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by sourceware.org (Postfix) with ESMTPS id B23AE4BB593C for ; Fri, 24 Apr 2026 20:45:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B23AE4BB593C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B23AE4BB593C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063534; cv=none; b=RxU5sEmoXeRpP4FOc8AO1/sS0Xu5KHolsmIVQJP7PAtvgTYAya17kjYJgGMHq8sgzL7OLAaKM+NrNC8RR/lp8CYtyWJR8ejVZ8I4ctk+nQT2vNdoPJ08Hk5akL449q3eQTMqlg1p9GOJdJ7zqy18jVXTDNQr2l8HYYigpUhVi4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063534; c=relaxed/simple; bh=ZJo4oVjwotawmitkrHVkKxeBwDLy1BZ2Vpw0C0fH40g=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=XxgHzoUPgLCcdsrQel778Jnhz1UgvdKGS+/NwHxyceOkzXPHQvfRqgDWSLTUbpV8i5U9dYOUKgU4ODOUEkAkbN4BCP2RlMb1H4MgbamSgVdImqnHfZO6T+orrFHMrwT+W4VvJ+GVN4HNfUEl4BqSNskdT3UdM362a7u145ZfhiM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B23AE4BB593C Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso113490745e9.3 for ; Fri, 24 Apr 2026 13:45:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777063533; x=1777668333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OF06pHe0c0PuJDZETC/kBXIm/YDsJwun/r714iQgQXo=; b=RHVDBGNjNJQh1Y7eCeLTonyisg0p9VrWFV4o5PLDM8HW2xbUMZQyVnaeG2rHVsH4d6 QiC+XUq1rimdmn3pwZZbR+stkKTw2JvBKxJpCBtMVdHhQofho3NaxcpEpBVvn7YPwTrh gUUZpI8+BbpGSKsjlau46fdy+0TjSRY5ByWPF3UyrHs7gjwI5gdVUnB+dDicZOOsnfbv aNfPeAPjJBAexBn+NA8++oylckUkbv/5ug6owxwOhwToslejeqwOaoAi2WkYx+xkonoy LMiW7hmiFnCheQ+f5Bgx6AH6qHO0Bw7F+5wcQ2lmJpI+pQp4TsE6eyLYYcTerNIixD8V e5gQ== X-Gm-Message-State: AOJu0Yx36l38M/NJBOiDlcxBe9f3u6JX6cYkZvCkg8adfkCHcJ8ptPzE iiXxDog432nCi7rrHKb221/YiEI+gKTOS51rizk50Q4cv9emEMiACD5+Te+usnim X-Gm-Gg: AeBDieuIKM/DKkLWms4H5WyTKGxxzvoF6HQcoBZ0rtBzh/JhK1eQbkAYkNUS1IF/CwT hgDC/5UUsKAnh+L2OY+yq464+jL60swXWjDG+6hZzazTVkg7KLCW0Uo+j/VuTF+xD2FWXV6SSof oiqN+wvG+U29vKJivCa2Pnz8eCPkoAo6XqzDB2XXDj7rq6MEYRP5+MofIkpY6eMWVgJEQdUnSX2 PgmH2/rljjihhledjDK50ru1YWNr9GJDAJeR128f+26MbA4nPsnOukMFoV/q6BoADEvki0vJaWi c7lVOrPN+J9vWegVkk0/10yOCPBunWa+YrLby/Ed8Q+QkCXtTfZt99wFzRYgQY9q6ei2QenOPtS aM5HRSYQWHcgQO3v8f8X/QbSgg8mPucsNsaVo0WKXCq/i3b86dInnLPvJgd3J39ugie9uywEUTw It7wE/kCqYGyFmJgUl9r7mcCS7Vel0M+S5 X-Received: by 2002:a05:600c:c4a1:b0:488:c014:34da with SMTP id 5b1f17b1804b1-488fb77ed1bmr455966025e9.26.1777063533254; Fri, 24 Apr 2026 13:45:33 -0700 (PDT) Received: from localhost ([2001:8a0:facb:a800:7315:8865:c664:fc06]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a5aa3ae83sm419238565e9.12.2026.04.24.13.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 13:45:32 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed 06/28] Windows gdb+gdbserver: Eliminate windows_process_info::thread_rec Date: Fri, 24 Apr 2026 21:44:46 +0100 Message-ID: <20260424204508.1343973-7-pedro@palves.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424204508.1343973-1-pedro@palves.net> References: <20260424204508.1343973-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org After the previous patches, thread_rec is no longer called anywhere. Delete it. Approved-By: Tom Tromey Change-Id: Ib14e5807fc427e1c3c4a393a9ea7b36b6047a2d7 --- gdb/nat/windows-nat.h | 13 ------------- gdb/windows-nat.c | 8 -------- gdb/windows-nat.h | 3 --- gdbserver/win32-low.cc | 15 --------------- gdbserver/win32-low.h | 3 --- 5 files changed, 42 deletions(-) diff --git a/gdb/nat/windows-nat.h b/gdb/nat/windows-nat.h index 2cc665fb53c..8920d445838 100644 --- a/gdb/nat/windows-nat.h +++ b/gdb/nat/windows-nat.h @@ -104,11 +104,6 @@ struct windows_thread_info }; -/* Possible values to pass to 'thread_rec'. */ -enum thread_disposition_type -{ -}; - /* A single pending stop. See "pending_stops" for more information. */ struct pending_stop @@ -178,14 +173,6 @@ struct windows_process_info This function must be supplied by the embedding application. */ virtual windows_thread_info *find_thread (ptid_t ptid) = 0; - /* Find a thread record given a thread id. THREAD_DISPOSITION - controls whether the thread is suspended, and whether the context - is invalidated. - - This function must be supplied by the embedding application. */ - virtual windows_thread_info *thread_rec (ptid_t ptid, - thread_disposition_type disposition) = 0; - /* Handle OUTPUT_DEBUG_STRING_EVENT from child process. Updates OURSTATUS and returns the thread id if this represents a thread change (this is specific to Cygwin), otherwise 0. diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index aae4de42a73..2dd372ae7b2 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -274,14 +274,6 @@ windows_per_inferior::find_thread (ptid_t ptid) /* See nat/windows-nat.h. */ -windows_thread_info * -windows_per_inferior::thread_rec (ptid_t ptid, - thread_disposition_type disposition) -{ - windows_thread_info *th = find_thread (ptid); - return th; -} - /* Add a thread to the thread list. PTID is the ptid of the thread to be added. diff --git a/gdb/windows-nat.h b/gdb/windows-nat.h index aa90dfd37d3..2907d97d655 100644 --- a/gdb/windows-nat.h +++ b/gdb/windows-nat.h @@ -27,7 +27,6 @@ #include "ser-event.h" using windows_nat::windows_thread_info; -using windows_nat::thread_disposition_type; /* A pointer to a function that should return non-zero iff REGNUM corresponds to one of the segment registers. */ @@ -48,8 +47,6 @@ struct windows_solib struct windows_per_inferior : public windows_nat::windows_process_info { windows_thread_info *find_thread (ptid_t ptid) override; - windows_thread_info *thread_rec (ptid_t ptid, - thread_disposition_type disposition) override; DWORD handle_output_debug_string (struct target_waitstatus *ourstatus) override; void handle_load_dll (const char *dll_name, LPVOID base) override; void handle_unload_dll () override; diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 180fabe0df9..bf55183f705 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -127,21 +127,6 @@ gdbserver_windows_process::find_thread (ptid_t ptid) return static_cast (thread->target_data ()); } -/* See nat/windows-nat.h. */ - -windows_thread_info * -gdbserver_windows_process::thread_rec - (ptid_t ptid, thread_disposition_type disposition) -{ - thread_info *thread = find_thread_ptid (ptid); - if (thread == NULL) - return NULL; - - auto th = static_cast (thread->target_data ()); - win32_require_context (th); - return th; -} - /* Add a thread to the thread list. */ static windows_thread_info * child_add_thread (DWORD pid, DWORD tid, HANDLE h, void *tlb) diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h index 48ad111ad1a..402254fdad5 100644 --- a/gdbserver/win32-low.h +++ b/gdbserver/win32-low.h @@ -179,9 +179,6 @@ class win32_process_target : public process_stratum_target struct gdbserver_windows_process : public windows_nat::windows_process_info { windows_nat::windows_thread_info *find_thread (ptid_t ptid) override; - windows_nat::windows_thread_info *thread_rec - (ptid_t ptid, - windows_nat::thread_disposition_type disposition) override; DWORD handle_output_debug_string (struct target_waitstatus *ourstatus) override; void handle_load_dll (const char *dll_name, LPVOID base) override; void handle_unload_dll () override; -- 2.53.0