From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gc7OLWnX62m5UzkAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 16:49:45 -0400 Received: by simark.ca (Postfix, from userid 112) id B85E31E0BA; Fri, 24 Apr 2026 16:49:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FEE71E093 for ; Fri, 24 Apr 2026 16:49:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id F122B4B920FE for ; Fri, 24 Apr 2026 20:49:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F122B4B920FE Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id 977D84B9209B for ; Fri, 24 Apr 2026 20:46:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 977D84B9209B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 977D84B9209B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063587; cv=none; b=lIlNk6KFAKN9PqkIlSgNCXdbZkJPD8kq5NaJGrNfvsaQl/yJjKSMxeu366IMGWPLykI70AejsOjmXxRBC7DZhmI+nmkatr+WEc2UZvyzBZTQKzWCVoPbyovLEac/xRRIfFvqJlpwsXJijtp1iGE39WZbC6uHh1gKh3sMCmzEvB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063587; c=relaxed/simple; bh=qWz55WKEhmjyrOKiZ4EDQnzzpnKTD1Bi/gAuaYiYPQk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=mUb1PkL6dS9ONo8KntI+YyHgwUNZn1DkVvhQoYeBa+pJ3ODJMc/4nWnppzAkji5xSRWfOW6wzmzL9WhKACniobIFUlrbyFNYWOncwrkNXt3DBNyquDELJw5S53hbwrtzPKOxt3mCX9iHSIiH4h8mwkMXiEmxFGi6XUGLGR8lXjk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 977D84B9209B Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-43fe8bda8e9so4565725f8f.1 for ; Fri, 24 Apr 2026 13:46:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777063586; x=1777668386; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sj+xiHhevvvuXpvFwNcMRVdVohrqN8WY22urx649gns=; b=q49yaf25g5P1/GD6UrewUgNijRTdqmXM3CtKiHRfwHb0rupB96wWFrmrXa4rsmdKMK jFwtERGVUcQcVW6393B/VULQCpkumbUF/2Ip8ERTyZWNXtJ4UgpyA6Msq4PJST8chQcc bL9f8+NPLAwswfn2orVqrXmi5SM1pJl0FhE0oXGWIu8Q6jHGtXSgiB8XDLKO0jVYvzS/ cQEPoKinm0DjB/VQeEYiT934+hKisJmzDQTD+96/ejphg7N/4ZkpL2dHafCIVkNlcUdI gM9lafBtSmvMp3sX1pQwAVdyf0Nf0LrJKhy90S0PPPa9Fh/sIeLDvXX35R77AgrNhU2e pvkw== X-Gm-Message-State: AOJu0Yy1hKWMJopMcqxVFGg/14R6AcXw0PMpC3UgvlywtoDU547507xc mdfcuHFkqq9ZCqH+Bf23gjRBdtDZXqFp9XGRGJrgj3Wk5QBotfOZYsHbVwKYavxm X-Gm-Gg: AeBDies3ayY5GzX9jd/fXNGtLKBYrLUPaGUNBkfdIeOqgnS4RqFr5fTKf9rtZBi0cX7 rCJgEVEIrd/DoL73Rn8MmsHNG/cqMN05Q60ZcOj3jrz2M+hjR56EyA88BvwwXOFbcePejjFNwNI LS4ARxIK6EBxNX4cez20O3/xtT/Jt4kx/GCS0DG/e1d5ryotxmBx3RnegOEMI7B3TFfJOnlt+hm dT08yC4FJjOF3xwKJ7mwH5pNFDLJ4uNDDWhVkzEQHROptqYDQnVx8qAxIbyXuuYPkrZhX3FdH6J yNnnpYvsU11VPt+FciTepWefy7l9XTl5n16Ck8ND/MTACOtq8t/E946Wb7Ftnc6X5BI4CZB6HN7 WxgIA7Np237dJIkABq5JNBdP0UOmxdT3N/uPuZnB9FoMQdShWkqKw6JMbF5llXtDLGXN004rKQO VwuEpBm0eanFXkyEVoM7hQ9CW1XH6VEYYSktJnPZwX/yc= X-Received: by 2002:a05:6000:290b:b0:441:1fa5:4577 with SMTP id ffacd0b85a97d-4411fa54a6amr28506557f8f.26.1777063586150; Fri, 24 Apr 2026 13:46:26 -0700 (PDT) Received: from localhost ([2001:8a0:facb:a800:7315:8865:c664:fc06]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-4411c9f4f03sm32432376f8f.1.2026.04.24.13.46.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 13:46:25 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed 26/28] Windows gdb: cygwin_set_dr => windows_set_dr, etc. Date: Fri, 24 Apr 2026 21:45:06 +0100 Message-ID: <20260424204508.1343973-27-pedro@palves.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424204508.1343973-1-pedro@palves.net> References: <20260424204508.1343973-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The Windows backend functions that manipulate the x86 debug registers are called "cygwin_foo", which is outdated, because native MinGW gdb also uses those functions, they are not Cygwin-specific. Rename them to "windows_foo" to avoid confusion. Approved-By: Tom Tromey Change-Id: I46df3b44f5272adadf960da398342a3cbdb98533 commit-id:896523e0 --- gdb/x86-windows-nat.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/gdb/x86-windows-nat.c b/gdb/x86-windows-nat.c index baa6b969e99..5c09efce32f 100644 --- a/gdb/x86-windows-nat.c +++ b/gdb/x86-windows-nat.c @@ -299,10 +299,10 @@ x86_windows_nat_target::is_sw_breakpoint (const EXCEPTION_RECORD *er) const Here we just store the address in dr array, the registers will be actually set up when windows_continue is called. */ static void -cygwin_set_dr (int i, CORE_ADDR addr) +windows_set_dr (int i, CORE_ADDR addr) { if (i < 0 || i > 3) - internal_error (_("Invalid register %d in cygwin_set_dr.\n"), i); + internal_error (_("Invalid register %d in windows_set_dr.\n"), i); for (auto &th : x86_windows_process.thread_list) th->debug_registers_changed = true; @@ -312,7 +312,7 @@ cygwin_set_dr (int i, CORE_ADDR addr) register. Here we just store the address in D_REGS, the watchpoint will be actually set up in windows_wait. */ static void -cygwin_set_dr7 (unsigned long val) +windows_set_dr7 (unsigned long val) { for (auto &th : x86_windows_process.thread_list) th->debug_registers_changed = true; @@ -321,7 +321,7 @@ cygwin_set_dr7 (unsigned long val) /* Get the value of debug register I from the inferior. */ static CORE_ADDR -cygwin_get_dr (int i) +windows_get_dr (int i) { windows_thread_info *th = windows_process->find_thread (inferior_ptid); @@ -352,18 +352,18 @@ cygwin_get_dr (int i) inferior. */ static unsigned long -cygwin_get_dr6 (void) +windows_get_dr6 (void) { - return cygwin_get_dr (6); + return windows_get_dr (6); } /* Get the value of the DR7 debug status register from the inferior. */ static unsigned long -cygwin_get_dr7 (void) +windows_get_dr7 (void) { - return cygwin_get_dr (7); + return windows_get_dr (7); } static int @@ -489,11 +489,11 @@ display_selectors (const char * args, int from_tty) INIT_GDB_FILE (x86_windows_nat) { - x86_dr_low.set_control = cygwin_set_dr7; - x86_dr_low.set_addr = cygwin_set_dr; - x86_dr_low.get_addr = cygwin_get_dr; - x86_dr_low.get_status = cygwin_get_dr6; - x86_dr_low.get_control = cygwin_get_dr7; + x86_dr_low.set_control = windows_set_dr7; + x86_dr_low.set_addr = windows_set_dr; + x86_dr_low.get_addr = windows_get_dr; + x86_dr_low.get_status = windows_get_dr6; + x86_dr_low.get_control = windows_get_dr7; /* x86_dr_low.debug_register_length field is set by calling x86_set_debug_register_length function -- 2.53.0