From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OdLPNKrX62m5UzkAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 16:50:50 -0400 Received: by simark.ca (Postfix, from userid 112) id D39DF1E0BA; Fri, 24 Apr 2026 16:50:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4BF7E1E093 for ; Fri, 24 Apr 2026 16:50:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D878C4BAD16F for ; Fri, 24 Apr 2026 20:50:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D878C4BAD16F Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id B84634BB8F48 for ; Fri, 24 Apr 2026 20:46:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B84634BB8F48 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B84634BB8F48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063585; cv=none; b=SlYdxGkJeOjY9p898iu1J3NGW3+E8L5H17RVc2tSGYguLboLpwQNiC100wg2HgnrrGw+H36LtVrIB0I9ggJb7Z+bWQbx5fQ5N+wy4qjfkDAUN6TW2A+UWg1+VUGfOG59Rz4vZUEPrdwBu3NFP316qdQo0R1UwNxSdAabO+kCiF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063585; c=relaxed/simple; bh=7ikZQqa828CE2So/hXKvEE3BDPtKYzjFApX4OK9HRuY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=o8FtY8BuCUvfaBK6r7+VQwPd7s9HV4Qpo1cW2lH0GB98SRflikJPO2hjSxac/Ob9HGTuVc4GWk0NW0iUO3BQJeunIy/qIQClG2UDrbyo5Eajdph8mX2LqYWt2BM0j0yyUgqzj+QbpHG6aMSD1gLei7wvKFG2J24dCeHZuyJ/Wrw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B84634BB8F48 Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4891f625344so69945815e9.0 for ; Fri, 24 Apr 2026 13:46:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777063584; x=1777668384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6LUHaMWVZfdY+xKe95rhHAdeuJUeXTMAf0RxMIBLzKo=; b=VtnEestDQlpDWYFmwB/JmyBUxfgKM2rQ/XTLhp5x7Bn0W6w0qY1nO4mXhhy/x5nh0E gW+mXA2GVRJ3oc/oyGOjSipdJU5KDMQzhmo0gIQH1gaE8pXqngGqu4/fme5clMeCN6tr B56owfLyjkIWHLZL834kUdTvgTmSKc2pQZpz/sncEnLqXqP6+711mkrgX+ASe8CjYj4z VLZxd8oDj+9ivVuTbar7WPWk93wQjzDejGWq/EZXwiGMhBSwUuvUqYN2TM32fPTMN+PJ Ny5NADJ9IwOvvPHvJw3Fpvi/L0qaQbyz4iJW+szB4R6EJWUGyZkpS5XjtnJKTZhFnrVt muLA== X-Gm-Message-State: AOJu0YzIky+KNXAqfBwnK7ZRJCqeBwojNXCuURadPg/eeN7vpFhWM7NI 1yS3FflgUDlfFp/wO7xCJv5ecIxy0wNaFLGPDmK/2iCJSTa0BKMcefmAmKider24 X-Gm-Gg: AeBDieutRDfKWQOKClh/jlo0sJmQbhK6UfVfjrO4GedmqLUE+jsL3jlEZV2i9R0ihah BixX6bJmVlO1w6khr5vmroPHjMYB7EYeLuQnBec+yLMjQObZXY7xXSrzPkRRVUVEBGK2XBcY22l vv/nrKpXrsUOBRIKLp0XYW/lcm3sFr8fNu+epw/vwVdmpRlclfnrDwRJHKxX3rrHkg5ONVjUfHe hkHfeXT2YvXymhOF1knzZnagZz7TdeL1tqiDLLzorqZfQ2Kg7tVytc3ySMIV5UuO6Ssks8tte8/ cj7gxXEUy3TR5/fcl2NwhU/39HQ6/+CMiferE6xN6wkgp96wufAlX+XD8ijwz9iV9BmbgNbHSkI bkbdmtZ9TQjiySNlHBEip43xJQQfGapxnWOC03xkkx4KLj7PiRp3ItvDoDTSEM+Wk6kZGUhEFFE ZvkUvJQ5I3aftFXzolMaXqLe7LbxLlfkqw X-Received: by 2002:a05:600d:4:b0:48a:65ab:8059 with SMTP id 5b1f17b1804b1-48a65ab8180mr46412015e9.13.1777063584297; Fri, 24 Apr 2026 13:46:24 -0700 (PDT) Received: from localhost ([2001:8a0:facb:a800:7315:8865:c664:fc06]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-43fe4cb1249sm59320399f8f.5.2026.04.24.13.46.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 13:46:23 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed 25/28] Windows gdb: Change serial_event management Date: Fri, 24 Apr 2026 21:45:05 +0100 Message-ID: <20260424204508.1343973-26-pedro@palves.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424204508.1343973-1-pedro@palves.net> References: <20260424204508.1343973-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org windows_nat_target::windows_continue, when it finds a resumed thread that has a pending event, does: /* There's no need to really continue, because there's already another event pending. However, we do need to inform the event loop of this. */ serial_event_set (m_wait_event); return TRUE; If we have more than one pending event ready to be consumed, and, windows_nat_target::wait returns without calling windows_nat_target::windows_continue, which it will with the non-stop support in a later patch, then we will miss waking up the event loop. This patch makes windows-nat.c manage the serial_event similarly to how linux-nat.c does it. Clear it on entry to windows_nat_target::wait, and set it if there may be more events to process. With this, there's no need to set it from windows_nat_target::wait_for_debug_event_main_thread, so the patch also makes us not do it. Approved-By: Tom Tromey Change-Id: I44e1682721aa4866f1dbb052b3cfb4870fb13579 commit-id:669a42f6 --- gdb/windows-nat.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index e0589c4de97..b2142469474 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -251,7 +251,6 @@ windows_nat_target::wait_for_debug_event_main_thread (DEBUG_EVENT *event) { *event = m_last_debug_event; m_debug_event_pending = false; - serial_event_clear (m_wait_event); } else wait_for_debug_event (event, INFINITE); @@ -1190,6 +1189,11 @@ windows_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, { int pid = -1; + /* serial_event is a manual-reset event. Clear it first. We'll set + it again if we may need to wake up the event loop to get here + again. */ + serial_event_clear (m_wait_event); + /* We loop when we get a non-standard exception rather than return with a SPURIOUS because resume can try and step or modify things, which needs a current_thread->h. But some of these exceptions mark @@ -1238,6 +1242,10 @@ windows_nat_target::wait (ptid_t ptid, struct target_waitstatus *ourstatus, thr->suspend (); } + /* If something came out, assume there may be more. This is + needed because there may be pending events ready to + consume. */ + serial_event_set (m_wait_event); return result; } else -- 2.53.0