From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cShjMfnW62kyVDkAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 16:47:53 -0400 Received: by simark.ca (Postfix, from userid 112) id C48541E093; Fri, 24 Apr 2026 16:47:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 471731E093 for ; Fri, 24 Apr 2026 16:47:53 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E96344BABF03 for ; Fri, 24 Apr 2026 20:47:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E96344BABF03 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id ECE6E4B920F5 for ; Fri, 24 Apr 2026 20:46:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECE6E4B920F5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ECE6E4B920F5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063561; cv=none; b=BPmhuK473+h2eeD5G8b1dM1SZPjlPHT/9e41JxPcf2faAec3mPt/ExubbOlnM1+nwRQytjW3M+9+V36Ii76UuKuTRDYYu4m2/40Jh0aJDQGktQnpr91Mwm8yA53gbhGHxeVElqWkKL5AfIv7O6zdrrOAguCCiKb/82OnhNwRHno= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777063561; c=relaxed/simple; bh=5qrqahM8s8Fv8vBMR+c6VWilCii+SQ4qz1yBajhMDsY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=O1qXh9R3ttd3u1UJT6cLgytAM1Rt0YeeMKjcPb/ofqZP/wXArE+ijDT7ZriwF/hqqbUt5D9jSZwHbWc7Ln4e21Hw3HywzE5a9XrF04jcvjDSaGtqTfB4ppX/IH10c/2D26/gSWwzSurHEB5O5kNaMNy9N1Mi8EosE+zof+2wX1Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECE6E4B920F5 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-483487335c2so80799445e9.2 for ; Fri, 24 Apr 2026 13:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777063560; x=1777668360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=il7P/AEX9YgXnwZo75+8oh5uk85HLbJpszRlV5OSUMM=; b=AgSWqw22JGVFmtkAG7Pj4cM2+eM3BNJgGID2cH//GH5pYxH5LSluOXOVVZpHL5xhxj zFS06JM9cJZoqVWfMsJgaNTel/4ubG+LgybntodB9eNzv5qo1Q8MbQV5f/8TZH34kRBh BxeDXrY+jxsKBW+Uga6vJ/yYU/LNehV1Hg3CAdCBW953fuT/4FPgwz2QMSGuvf1yOrTu aiW/XlMrzG7O0k/eEZScvCH04crNmdUS0xJZ4xh9eomFtEH/sRv9tMJygXOg2sEg1sfV z8X5W7K+Vdc1fh2xAC/uZt1UQ7z3Ic+gZ3Ml8aCnlrJ3QuGlUIUvdg+FgIQmhU4Zn36y G4ew== X-Gm-Message-State: AOJu0YyuYdCcFv+uuZF5GIrFCDGic3kQfWShfbqIpwX+amuicSzthGkZ lOI+sbQbyZkvUBlxxysHtFlua5LFAEALj9Ytjg/aPr5jMrJ+d7i6h+qnIUDo0TDl X-Gm-Gg: AeBDievnIpDoHJ7ht421/SFNTXYoFXgJQ2MOYDQCzfMO6Hoo1EP4m98JAt/q1L9KQRj jjj0BNLkZvXlxZOh/7YgEcg6kIeJKokHulgA+3fufhbOabaXPmDtJ2i5Vg2s2WObBUTSgU+p2Gk hwqhCxeZIa4SSE2/MeTbFhLWW0ankIJsUfSL/RKXZNRYEx6AWu5YdG17aYRFaec17g8pem1h7dH APWFFn1A1kUoXkDzpN4dQnvMy182qmO9wz+DzA1NJtkbD0o+Jvr1SwIACn2/v/2CKeBitmrZipV vENoLGKCZ393GhC6Sf18JoMfVhoBPOs4cn3FnRFuqLbhlNlj9pickUQYDD+s+/w95XhkWDaWGlG 6CLKk2EaFOrFaPw6Syh6BoWk6U++H2aj6dafOO3BKL97g1cr/UMPFRx8OoSdDMPTDm/scDmU31G pGRQKCDdirCaIwTEwV+CO+1t9HkXPjAN2s X-Received: by 2002:a05:600c:3b9b:b0:489:fec9:a17e with SMTP id 5b1f17b1804b1-489fec9a322mr301606735e9.12.1777063559536; Fri, 24 Apr 2026 13:45:59 -0700 (PDT) Received: from localhost ([2001:8a0:facb:a800:7315:8865:c664:fc06]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a4b329542sm583605255e9.3.2026.04.24.13.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 13:45:59 -0700 (PDT) From: Pedro Alves To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed 15/28] Windows gdb: Can't pass signal to thread other than last stopped thread Date: Fri, 24 Apr 2026 21:44:55 +0100 Message-ID: <20260424204508.1343973-16-pedro@palves.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260424204508.1343973-1-pedro@palves.net> References: <20260424204508.1343973-1-pedro@palves.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Passing a signal to a thread other than the one that last reported an event will be later possible with DBG_REPLY_LATER and the Windows backend working in non-stop mode. With an all-stop backend that isn't possible, so at least don't incorrectly consider passing DBG_EXCEPTION_NOT_HANDLED if the thread that we're going to call ContinueDebugEvent for is not the one that the user issued "signal SIG" on. Approved-By: Tom Tromey Change-Id: I27092ecfbf0904ebce02dff07d9104d22f3d8f0e commit-id:30c8d0ce --- gdb/windows-nat.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 2a61953f439..614d85ac8f7 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -790,10 +790,21 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig) if (sig != GDB_SIGNAL_0) { - if (windows_process->current_event.dwDebugEventCode + /* Note it is OK to call get_last_debug_event_ptid() from the + main thread here, because we know the process_thread thread + isn't waiting for an event at this point, so there's no data + race. */ + if (inferior_ptid != get_last_debug_event_ptid ()) + { + /* ContinueDebugEvent will be for a different thread. */ + DEBUG_EXCEPT ("Cannot continue with signal %d here. " + "Not last-event thread", sig); + } + else if (windows_process->current_event.dwDebugEventCode != EXCEPTION_DEBUG_EVENT) { - DEBUG_EXCEPT ("Cannot continue with signal %d here.", sig); + DEBUG_EXCEPT ("Cannot continue with signal %d here. " + "Not stopped for EXCEPTION_DEBUG_EVENT", sig); } else if (sig == windows_process->last_sig) continue_status = DBG_EXCEPTION_NOT_HANDLED; -- 2.53.0