From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2c3CFLuD62nn2zgAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 10:52:43 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=aYdKkpKo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 501D01E0BA; Fri, 24 Apr 2026 10:52:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DC1D21E067 for ; Fri, 24 Apr 2026 10:52:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AC0B34BB5938 for ; Fri, 24 Apr 2026 14:52:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC0B34BB5938 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=aYdKkpKo Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id D4EA24BB3BCF for ; Fri, 24 Apr 2026 14:50:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4EA24BB3BCF Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D4EA24BB3BCF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::233 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777042230; cv=none; b=MXoUS0zj1IhR866opyI+EeDDRbMjmpAU1ek9CCbPxt/rK9VazvAgc3qXHjWqcHbM1LcqpBK+GSuYa4TaBfiHC5MzDHjJ84Z5qSleye3xMQbJrCuGTgy03Q5io4W9qfna69PjnCsEC/QnHwIE8a0l0pd0lefZhwj+jvxJtPmYn6A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777042230; c=relaxed/simple; bh=SR/9prnq6D3lWY9b/oT1xB0kRja7l5XKUmzTEL6RM30=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=dEXbVCuIkA3+I9mKLVChwpUuDUurHRw3weM+9y5kNmorA489R75mklIikLAhV9ft2NOUfCnELvtZ6LrEis7bNLJsobQlOCHAL64I7CHHaM36p/viYOzXB0swb95mlhLOWfJGcxFCR/+qku+Uw/tYeKTWzY+C0ddTcin/SZy/0UM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4EA24BB3BCF Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-479e4835e26so2992280b6e.3 for ; Fri, 24 Apr 2026 07:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1777042230; x=1777647030; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UGT23oUr1d9xUiaBxoWNR+yMQ56kPU7z28ZvjOFUtOM=; b=aYdKkpKo0B6IQ/d1hNWih1NXiKJ3E1p1wDFKpmn4vzAwx6/uA4u68IiQ9wbhxIb8uX EDTIfVToyUQk4t7vtXcTsrY88fuHOmaWu8I0Z+JEHhZAAXH4XwmKur9WFKi4Ox+QuiYz Ry3PF4+QrrCTh8hQAJtpgTvAdtDUUZa551dJv84HsYBLc79L4IJxD6YAFuKmdPoS6zne 7GUeyTu1bHzGIbPAdYlfS5ksmCM2lPv/gJGY9My3lo5GbM6SfDGjeYLH3tV1ZFlXYTG1 5+8zNGdlFUUnqBQNcV3wnYJBjRE5bBg6MZJaggpJD8j4KCu8YO1mwyDJmzkhWlUlBOY7 nNYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777042230; x=1777647030; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UGT23oUr1d9xUiaBxoWNR+yMQ56kPU7z28ZvjOFUtOM=; b=VXrkvbSg6H6c4gxGsy7/eltOmZ0Oca9l/O3+6QntgzSb9Ydu52jyBEztOiSCp1WevN i7dbiSzVoS0YlAHUlaIXFpiBOur5+kaRRkiopJKu8kzjAYxBNqLJBMr8Vl53FFBCyTer BU/2hXe2bO0mr0j0r1TlZ+x1nIaJBF1CxevJvvvh4rb68K2AMdlmuNb440Ni/3zcbLAg L+WudB0NEZhJg/XNoFumzE7tiIaS/tafjPCxrLpe5bJj57TJ3k3wpB9vt3l2cRhgkgs1 wsNVhna6soev5pzL48lU2FkQjjWX9ihiWMgxcCI66tPZl94bNzHCjijl8BFqMD+wUNKM fS1w== X-Gm-Message-State: AOJu0Yz+dp+07mdMgyTGTuURS3DiAzzqcyjeX4MI7s/wKAb84RN8pP1G zhrykWH/xnmv0jNW+SAOC4Thai/gEeuIFDEDn/p+IQ0uR4cav7EgZAbyh2GWR3fpMM7dxs3vHY5 RFg0= X-Gm-Gg: AeBDies9eH+xjF9Pl1KjKmfyyZ+Swh2xeleQUeAs+affcx5e6grMUR2q9E22Yim0kAE dWPFGvrBVqqrpwGTq9g7mVIWJJaahpkTjJX7VikMxs+ntQ6gOXa9RNrSstp0jB0oWnAeDdDVFBN kBHKopv5KZmRB/anlVyKsusdLg9pUTp7f6ICBIhEdwZnrhRC6oA5y1imDbmAxzzop3ceM74Kdp+ IHAwRzZy7v1HHbTLuthba5nG3BSIYwd5Ib54hx1Tf8jni2ujYOsVuO4FS637gK/6vTjGAdUpxDk PbzrhcvXIFI+XJE6pDiWFgWOvnIJl3GV4T3YWVB7qhGc21lumDWhfo2zcUwaOsdpfm5rpqK/iwe NM7ZZ0iK7+69OvZhAWLSY2TfDtqjvznd1rv9tpV6zIMqv3XzEwW1nNXVtFtwvLntWcODZDspkOQ uDCwwxPsg18+niyyL75TCll7MMQwg4J/hr+a2EksvAOMbo8cDSrXd/9XXQjGPEEUa+rmy+NU8l2 pM= X-Received: by 2002:a05:6808:2444:b0:467:1880:ffc6 with SMTP id 5614622812f47-4799cabaeb2mr17017425b6e.32.1777042230038; Fri, 24 Apr 2026 07:50:30 -0700 (PDT) Received: from [192.168.0.26] (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42fe61449bcsm5147552fac.11.2026.04.24.07.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 07:50:29 -0700 (PDT) From: Tom Tromey Date: Fri, 24 Apr 2026 08:50:27 -0600 Subject: [PATCH 2/2] Use bool in map_matching_symbols MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260424-ada-bool-again-v1-2-cb63db324fff@adacore.com> References: <20260424-ada-bool-again-v1-0-cb63db324fff@adacore.com> In-Reply-To: <20260424-ada-bool-again-v1-0-cb63db324fff@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This changes ada-lang.c:map_matching_symbols to take a bool parameter, then fixes up the callers. --- gdb/ada-lang.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index afdd59965fd..47433ccf6b7 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -5551,7 +5551,7 @@ static void map_matching_symbols (struct objfile *objfile, const lookup_name_info &lookup_name, domain_search_flags domain, - int global, + bool global, match_data &data) { data.objfile = objfile; @@ -5579,7 +5579,7 @@ map_matching_symbols (struct objfile *objfile, static void add_nonlocal_symbols (std::vector &result, const lookup_name_info &lookup_name, - domain_search_flags domain, int global) + domain_search_flags domain, bool global) { struct match_data data (&result); @@ -5684,13 +5684,13 @@ ada_add_all_symbols (std::vector &result, /* Search symbols from all global blocks. */ - add_nonlocal_symbols (result, lookup_name, domain, 1); + add_nonlocal_symbols (result, lookup_name, domain, true); /* Now add symbols from all per-file blocks if we've gotten no hits (not strictly correct, but perhaps better than an error). */ if (result.empty ()) - add_nonlocal_symbols (result, lookup_name, domain, 0); + add_nonlocal_symbols (result, lookup_name, domain, false); } /* Find symbols in DOMAIN matching LOOKUP_NAME, in BLOCK and, if FULL_SEARCH -- 2.53.0