From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ycfpF5Js6mmjMjcAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 15:01:38 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gwppABlh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5602F1E0BA; Thu, 23 Apr 2026 15:01:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 847861E093 for ; Thu, 23 Apr 2026 15:01:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0DF674BAE7F6 for ; Thu, 23 Apr 2026 19:01:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DF674BAE7F6 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=gwppABlh Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id 0B87F4BAE7E1 for ; Thu, 23 Apr 2026 19:01:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B87F4BAE7E1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0B87F4BAE7E1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776970873; cv=none; b=NO8i+ZrJIr8AJHuC7+EaWEkMsKIQ5x1ra04qMKFf9ryOL1LqyVjQ5SM54X5X4tPMuyU3T6XybweXWhzZxgOcPSmJuqtd7RzNKb76gI+7PuTkXr/O6uCsxuYNqOnOPwww3nILbu5ApJsrV6tojXQ0J1dth4ybnd9x+8FQmNfOMxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776970873; c=relaxed/simple; bh=HZmuE309Qsp1IVxD+/t2Yv2jka/E19aQReco8j3Z6Cw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WplFEudVg5SLwI7Jcay92bwnyWFQZFaNG4DY11M/rTunV07Zie+wht8W6zXaHUekd92c7ruMQ4r4Thz2h0tWD4EYEb6fAWka81+kFX931cGMNsyGkQ6cog3jmldky02XOg4Xk6ZPyTE1CVt6cYnqV6pJFBb/T0MPRhWKrBV297M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B87F4BAE7E1 Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-40ea36b56b7so5379759fac.3 for ; Thu, 23 Apr 2026 12:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1776970872; x=1777575672; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zwjvI+laR0J7ukSSJGBewtf9twaPRdHiokNfvVw557A=; b=gwppABlhpm53x3XrWIHRdSt28XYwLf0XKiLfCWi/1VtYlkDqez7MK7QIm7NDEwVOQ+ ozxZnFMuG/j0e6bxbkVZCa0+zlV95BLiRlnFGi4asJJQGM9/wSbb3I17mcaxSMf9lbVg ptEUQoZ3jFxzRcXUL0ADUntd3+kp5KDcpTmlzrbUn3khj5WjU0dj+eN+85oxGFQYWhLa +tFnIgPKQ3AM+LrRK56hhEYe2oljcOB0nTtHrpzbLk7HR1xSbiouL3SsvISvSi/dxHGq LW7jjD4GW54TigJ1IfHmmvBewIJKW+YRqjns7pGbPCDEU6j+hOBlynAafcyHKuG1g8iB /eew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776970872; x=1777575672; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zwjvI+laR0J7ukSSJGBewtf9twaPRdHiokNfvVw557A=; b=hClBwPmmdbFIADyONw1EaPrfDg5G/QlIjVbWgkq618xSU2mGLXy/88Q9J0felb/FmU 5YJmsi67Zxcr6LOmYuAhV/jjPF4e2HBKfVHfZZr91RHtyhG7Z7Nwj6fBw4+Hrt0kZLvB PGZInEE9UZbZvV1wxLiy8IRm5Q7XLW4kQeOrUC89MIBW7gVT31/UcJnQclFmP64m9xMZ On5J5kY6yIBkTl6sVonMTvjAUrTA6w49M2eEIFz+yFPmheftmsScoxohdNas/E3S3+RE a0cv9CTMwIKxDvfqSafXIYW4yCLRQwtPG+PQBOGxj5tGEGiRXPMif3G4NGl0QgB9WWgF 3i6w== X-Gm-Message-State: AOJu0YxwsLXQzO8Z1c/yab5kv9TWOQg8e5ndDEL/KzLSI5McTeGYVtBM JrT8V7uLMGC5CO7a4tLfvCdOhFrHg0tcvu3jmmgJYrta7iVX8fF3LaYhYtUP+ihmy8uAcMtjP/9 wKfc= X-Gm-Gg: AeBDietoOuasqSoHvy9uDTKYQzRgKg0WxKHaoOyXyx1aRbP7wOCjRu44ldFj62lDLrN 7VgUh+zmh3UvwEJHT/8LVx4c2bZb1cFu7+3/UDj2Lyri3eu4zEkYVzmwYO2eTLllF3TreWElEmk oynwgUdgOCerCEIKj6IbsLAb4umK5kPKLYmhvsgs7SoPj7XNyItSoG1Obw5+FI7bfYieI2xJYdb rlIQdSaI5rZOQ7/TvTx3EKj+/jSMVnm8Cj3gN0PtG9jh6Tx7os/fLQd2lFK6nxXozzMhBXcNL8X JKMj5KnMkAjsM0hs7AMdvznzBJ1HzTl4qUgwrCojqAeXaO3WNAxdRfulKMKTJSTtktc6Zz7/fxt wKWvIQLHV7r0fU9lMdeVGntHy8uXTBXJQYW98GifjNHYtMmzfopZ4nPJdILg9ln57C/BGwY+dsx jvDdFpQxkTwZ2TSjrA8AEmnm+XNjE7myyYxasdpHbJror3wT11bEhklEU7EChofYA7 X-Received: by 2002:a05:6820:300d:b0:694:a44e:9e7d with SMTP id 006d021491bc7-694a44ea493mr3555117eaf.52.1776970872087; Thu, 23 Apr 2026 12:01:12 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-696148cd37dsm2431952eaf.8.2026.04.23.12.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 12:01:11 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Use fully-qualified name in var_decl_name Date: Thu, 23 Apr 2026 13:01:09 -0600 Message-ID: <20260423190109.1274057-1-tromey@adacore.com> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org While testing gdb against a version of gnat-llvm that emits unqualified names (in a hierarchical structure), I found that gdb.ada/array_of_symbolic_length.exp would fail. The DWARF in question looks like this: <1><11a1>: Abbrev Number: 2 (DW_TAG_module) <11a2> DW_AT_name : (indirect string, offset: 0xe65): pck <2><11a6>: Abbrev Number: 3 (DW_TAG_variable) <11a7> DW_AT_name : (indirect string, offset: 0xe69): my_length_LAST [...] <3><11df>: Abbrev Number: 5 (DW_TAG_subrange_type) <11e0> DW_AT_type : <0x12ab> <11e4> DW_AT_upper_bound : <0x11a6> That is, an array's upper bound refers to my_length_LAST. gdb represents this as a PROP_VARIABLE_NAME -- but only the local name of the variable was used in this case. This patch changes var_decl_name to use the correct full name for the variable. --- gdb/dwarf2/read.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index bc7b8b46d87..9fa8b704182 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -13397,10 +13397,7 @@ var_decl_name (struct die_info *die, struct dwarf2_cu *cu) if (attr == nullptr || !attr->as_boolean ()) return nullptr; - attr = dwarf2_attr (die, DW_AT_name, cu); - if (attr == nullptr) - return nullptr; - return attr->as_string (); + return dwarf2_full_name (nullptr, die, cu); } /* Parse dwarf attribute if it's a block, reference or constant and put the base-commit: f797b25fdc7ca4a48c09802082426b71e56898aa -- 2.53.0