From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qf5rEKw66mkc5zYAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 11:28:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i7e0ELac; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3D8981E0BA; Thu, 23 Apr 2026 11:28:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 697C81E067 for ; Thu, 23 Apr 2026 11:28:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id E8C604B87BAD for ; Thu, 23 Apr 2026 15:28:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8C604B87BAD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=i7e0ELac Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 28C0E4B87BB2 for ; Thu, 23 Apr 2026 15:27:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28C0E4B87BB2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 28C0E4B87BB2 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776958024; cv=none; b=lzyKURfutfoSu1oHXfvBSyG50eWc8IzmYlp6sK6r/DPiOIF7rotjYrGHhf7QJoqJLFhzBjhm9fO0/w8FUh1IKMpsb79RTMWB//NMoZDRdRcnNFDdiMi4N2kEG2Vf3F293BAs5buwTdE2nXCc+U/XpWj9Z/Z5rvbqXPdysW8jk4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776958024; c=relaxed/simple; bh=o7Atx6IUCyh9xHqMjaI8OC52B4hqhQpuAA1Qo1bke28=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FLbNPb0KkeDrJWxyfKE89dJn31DgJzyIVRz6iGU2EfGSioTTSY7qHe6fXczhi7Y7QL7VMpRIZsNKFR/mAlAzVc6z5f5omhvsFk2mp+SGFJF30Bp0zEutUfdQXclwdGwvKpNgC/I2Lk8HmcUYl5TQ1mJLAFKXthKYnUtOBoyD0Dc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28C0E4B87BB2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776958023; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iColheR2G8+SYPC/zOuG9HX0inCF0uYzAWO/meIpzI=; b=i7e0ELaclfX5IlGFK5vf9w5CUGa1WxmTuqDANP1mtqXW3gmJvVmcgbGK/xA9rlXOAn2cMD 6/5fLIdsq2wPSKMBVMk+enB8gCvOwb72KwCYRFOVNu5Q86Y1AzBDvGqsCPsrgvnpszurmB PHKLIwKO7Wfrus+0ywL/xhVB54i0TYk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-Q7-TDSRFMIm8DwyscOawYA-1; Thu, 23 Apr 2026 11:27:02 -0400 X-MC-Unique: Q7-TDSRFMIm8DwyscOawYA-1 X-Mimecast-MFC-AGG-ID: Q7-TDSRFMIm8DwyscOawYA_1776958019 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CBB481800348; Thu, 23 Apr 2026 15:26:59 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.96.134.14]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED45219560B6; Thu, 23 Apr 2026 15:26:57 +0000 (UTC) From: Guinevere Larsen To: gdb-patches@sourceware.org Cc: Guinevere Larsen , Thiago Jung Bauermann Subject: [PATCH v2 6/6] gdb/record: Define new version of the record-save section Date: Thu, 23 Apr 2026 12:26:04 -0300 Message-ID: <20260423152604.171356-7-guinevere@redhat.com> In-Reply-To: <20260423152604.171356-1-guinevere@redhat.com> References: <20260423152604.171356-1-guinevere@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pZbxDie3O38HoWM7uInoFC1g3Oop-hT49OpIxvndj0U_1776958019 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With the changes to the internal representation of the history, we can no longer support the previous record save format. This commit makes it official, documenting the new format and changing the magic number. Reviewed-by: Thiago Jung Bauermann --- gdb/NEWS | 4 ++++ gdb/record-full.c | 35 +++++++++++++++++++++++++++++++---- 2 files changed, 35 insertions(+), 4 deletions(-) diff --git a/gdb/NEWS b/gdb/NEWS index 4cf91053c95..1dfd8c8e6ca 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -42,6 +42,10 @@ * Support for the binary file format dbx has been removed. +* The format for a saved execution record, created when the command + 'record save' is used, has been updated, and previous formats are + no longer supported. + * When connected to an extended-remote target GDB can now automatically set the 'remote exec-file' in some cases. GDB will auto set the remote exec-file only if the remote wasn't started with diff --git a/gdb/record-full.c b/gdb/record-full.c index 05d515f5295..8970774a0c5 100644 --- a/gdb/record-full.c +++ b/gdb/record-full.c @@ -76,7 +76,8 @@ ( (record_full_next_insn != record_full_list.size ()) \ || ::execution_direction == EXEC_REVERSE) -#define RECORD_FULL_FILE_MAGIC netorder32(0x20091016) +#define RECORD_FULL_FILE_MAGIC_OLD netorder32(0x20091016) +#define RECORD_FULL_FILE_MAGIC netorder32(0x20260415) /* These are the core structs of the process record functionality. @@ -2179,6 +2180,27 @@ record_full_core_target::has_execution (inferior *inf) 8 bytes: memory address (network byte order). n bytes: memory value (n == memory length). + Version 3 (all numbers are in network order). + 4 bytes: Magic number (0x20260415). + NOTE: be sure to change whenever this file format changes! + + Records: + record_full_instruction: + 1 byte: signal. + 4 bytes: number of reg and mem entries for this instruction. + 4 bytes: instruction sequence number. + 4 bytes: PC register ID. + N bytes: PC address of instruction (N == size of PC). + Effects: + record_full_reg: + 1 byte: record_type (record_full_reg, see enum record_full_type). + 4 bytes: Register ID. + n bytes: register value (n == actual register size). + record_full_mem: + 1 byte: record_type (record_full_mem, see enum record_full_type). + 4 bytes: memory length. + 8 bytes: memory address. + n bytes: memory value (n = memory length). */ /* bfdcore_read -- read bytes from a core file section. */ @@ -2372,9 +2394,14 @@ record_full_restore (struct bfd &cbfd) /* Check the magic code. */ bfdcore_read (&cbfd, osec, &magic, sizeof (magic), &bfd_offset); if (magic != RECORD_FULL_FILE_MAGIC) - error (_("Version mismatch or file format error in core file %ps."), - styled_string (file_name_style.style (), - bfd_get_filename (&cbfd))); + { + if (magic == RECORD_FULL_FILE_MAGIC_OLD) + error (_("This old recording format is no longer supported.")); + else + error (_("Version mismatch or file format error in core file %ps."), + styled_string (file_name_style.style (), + bfd_get_filename (&cbfd))); + } if (record_debug) gdb_printf (gdb_stdlog, " Reading 4-byte magic cookie " -- 2.53.0