From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ufbDFGTz4mkg7iIAWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 22:58:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=JBUlax8t; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4FE281E0B1; Fri, 17 Apr 2026 22:58:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8EE71E04F for ; Fri, 17 Apr 2026 22:58:43 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2804F4D108ED for ; Sat, 18 Apr 2026 02:58:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2804F4D108ED Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=JBUlax8t Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0F2D34CCCA00 for ; Sat, 18 Apr 2026 02:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F2D34CCCA00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F2D34CCCA00 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776481100; cv=none; b=MvmTnGRpLxJNL2slXuS2/rcyFiAjZsecwykzNo1NDE8iIuH70b0vXhDJU7Yb7B4zcMggGHxb4m3pECZDpC+YlZwRl7kEHl4paUVTZlE+rDOCCCmWGQDcUBSV5QimDcib4YOC+kTQIl+FVcjO7Wy+ZzLt8tWwXkBuLK5U6DK5A/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776481100; c=relaxed/simple; bh=ts94dXtB/fuqnc/Anvb+JLIziS5+wLAFlTqPAhlq9dk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=w5HPZZ60gPKSPjZ9gGkNorTlnJTsR9AESAHIdKjBXSNlbjpRjzKhOZAejlBNrl2lPSLeeBWgyPk5n0wOx/OTGO8MzNy8Y2vk/A4L7zKJmP9hvhXnKXNTx2i36qyp3r7Ut4ZSxC75T0O+wYdrQFf9lFil/dBuUMImBy+F7tSWXeo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F2D34CCCA00 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 63I2wEAN124543 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Apr 2026 22:58:18 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 63I2wEAN124543 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1776481099; bh=DbnY6uHKEAFdfLa91I33pIwKd9t0nW+RuUpOUAjRysY=; h=From:To:Cc:Subject:Date:From; b=JBUlax8tmMVJX0RDsKgxsZ/fN5+/1jVRuToaxuh365iRNyy2UOT2ZSqfAnrsInctr cPKnQzccPpFwEt+HpHP5k5Wnyk+ZtC9YVmKzvZz2U759ZgiEuIxtsR8HCwOX1sh8xN h7eDjJlwR13Wnt61Udb3Vcv+Q7rEAMh/2H0X/oh7jblRM4KAhioRl8tPqzESF+7MCB 3Fw7ts3Cqe5sCaEcRaIyAg2bVIprAiWRqCcpHiBkIv7rDnPYxGZRpi2PD2qvpBGXk+ qaKlCdoVtDgTAynxTC0y7JW6Lm5ThXUAk3m8NctOGBlliyta0z5JrHbnWD/U4XhF/K OLrcnjriJTxAg== Received: by simark.ca (Postfix) id D2EC21E04F; Fri, 17 Apr 2026 22:58:13 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdbsupport: remove iteration_status_str Date: Fri, 17 Apr 2026 22:58:10 -0400 Message-ID: <20260418025812.3494183-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 18 Apr 2026 02:58:14 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi When building with g++ 8 (on Alma Linux 8), we get: CXX ada-exp.o In file included from /binutils-gdb/gdb/../gdbsupport/array-view.h:24, from /binutils-gdb/gdb/../gdbsupport/common-utils.h:27, from /binutils-gdb/gdb/../gdbsupport/common-defs.h:214, from /binutils-gdb/gdb/defs.h:26, from : /binutils-gdb/gdb/../gdbsupport/iteration-status.h: In function ‘constexpr const char* iteration_status_str(iteration_status)’: /binutils-gdb/gdb/../gdbsupport/gdb_assert.h:43:22: error: call to non-‘constexpr’ function ‘void internal_error_loc(const char*, int, const char*, ...)’ internal_error_loc (__FILE__, __LINE__, _("%s: " message), __func__, \ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##__VA_ARGS__) ~~~~~~~~~~~~~~ /binutils-gdb/gdb/../gdbsupport/iteration-status.h:45:3: note: in expansion of macro ‘gdb_assert_not_reached’ gdb_assert_not_reached ("invalid iteration_status value"); ^~~~~~~~~~~~~~~~~~~~~~ It turns out that iteration_status_str isn't used, it apparently was only used transiently in my series. Remove it to fix the build failure. Change-Id: Icb43d4d719ad94a3eafa5fd55c81a56cbe0da91d --- gdbsupport/iteration-status.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/gdbsupport/iteration-status.h b/gdbsupport/iteration-status.h index c4c17fea4fb5..9d0b56e1b2b5 100644 --- a/gdbsupport/iteration-status.h +++ b/gdbsupport/iteration-status.h @@ -30,19 +30,4 @@ enum class iteration_status stop, }; -constexpr const char * -iteration_status_str (iteration_status status) -{ - switch (status) - { - case iteration_status::keep_going: - return "keep_going"; - - case iteration_status::stop: - return "stop"; - } - - gdb_assert_not_reached ("invalid iteration_status value"); -} - #endif /* GDBSUPPORT_ITERATION_STATUS_H */ base-commit: 89ab6f98afc35581b9fe32d9a59225d4aab19518 -- 2.53.0