From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5ardC/Wt4ml+0iAAWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 18:02:29 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jUGeiKqf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF1381E0B1; Fri, 17 Apr 2026 18:02:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 351641E04F for ; Fri, 17 Apr 2026 18:02:27 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1D6524D108F0 for ; Fri, 17 Apr 2026 22:02:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D6524D108F0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jUGeiKqf Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 020274CCCA22 for ; Fri, 17 Apr 2026 22:02:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 020274CCCA22 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 020274CCCA22 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776463322; cv=none; b=SQpQXyxzdj7EHBj6b8XNR46XENeP3aM9CZq14kS6JYK5yFLjJ7EElkGDCgo1Uzfbt4KKRhaPu/d2+cUJllbcOSzXSn8qO7Zf4By55Z2eEIrJ02glJC1fFesR3f/8A5o4VyyaOv5oNSMOJo0sTk85jVJ9tc8Peqzl0NoWQva0aFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776463322; c=relaxed/simple; bh=itDTRsemm1I9q/aY1wfh8Su0YSiFgq4I0GdJAyJBrww=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=cQrpZDArdD4USvs/tS7ZvnKx+bDEZ3rL2sWm50efsFRcXeFhglPIQqWLh4CjkozJDDV/1HAeAMRNUEfztWomi64XPmFav870+9FbymwzpPlJpgM9QK+xvJ2XXSHDFZX/nm7JEdZHS1xr32jLtwYzBbbAeAi9jifCt6Mrcsx9Tyo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 020274CCCA22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776463321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D9FCGumMMRmc5ggzY5544s+pX1a/ZQrlvB6/ZFv/3aI=; b=jUGeiKqf1e9IzY3lUd9eE/c5MfVe1bmVBRpfdfkZwKj9zRaV3d3ZWvbDdE9/VCgNIJWnbO X5Z9JwjD3aJ4a9aJyZMrHegh381qOrMEJ7ILw2IB3jHeNZS2uTK9s9Y5Agzp1o2n+ksPD7 41tmTRrxoDr/I9BtXt1me6ca1iVztWg= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-0o46uUaINh2vaU4kkgEs7w-1; Fri, 17 Apr 2026 18:02:00 -0400 X-MC-Unique: 0o46uUaINh2vaU4kkgEs7w-1 X-Mimecast-MFC-AGG-ID: 0o46uUaINh2vaU4kkgEs7w_1776463319 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CFF61956094; Fri, 17 Apr 2026 22:01:59 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.64.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 688441800357; Fri, 17 Apr 2026 22:01:58 +0000 (UTC) Date: Fri, 17 Apr 2026 15:01:55 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove OBJSTAT and OBJSTATS macros Message-ID: <20260417150155.411ab2c7@f42-zbm-amd> In-Reply-To: <20260417192039.2758461-1-tromey@adacore.com> References: <20260417192039.2758461-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: A3Hdefag8zxL1kOWqT8KgR4VC4-zzoFad2oW6IkHz7Q_1776463319 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 17 Apr 2026 13:20:39 -0600 Tom Tromey wrote: > The OBJSTATS macro seems pretty pointless, so I removed it. Then when > looking at the OBJSTAT macro as well, I decided to remove it and also > struct objstats. > > After this patch, symbols are allocated using a template method that > automatically updates the n_syms member. This cleans up the code a > little. > > Also, nothing ever set objstats::sz_strtab, so this is removed. > > Regression tested on x86-64 Fedora 43. LGTM. Approved-by: Kevin Buettner