From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb, testsuite: fix regression in gdb.multi/multi-{exit, kill}.exp
Date: Fri, 17 Apr 2026 12:35:02 +0200 [thread overview]
Message-ID: <20260417103502.2051279-1-tankut.baris.aktemur@intel.com> (raw)
Commit d19862435df418a2ec78d078048f54d115c67a66 ("gdbserver:
require_running_or_break for the 'z' and 'vCont' packets") introduced
regressions in gdb.multi/multi-exit.exp and gdb.multi/multi-kill.exp.
If the remote target has multiple inferiors and is resumed with
schedule-multi on, all processes may terminate, making the target have
no threads left. The target reports termination events to GDB. GDB
processes the first event and attempts to stop all processes. For
this, it sends 'vCont;t' packets to the target. But the patch mentioned
above required the target to be in a running state, which is not true
anymore. Therefore, target responds with an error.
Fix the regression by reverting the 'require_running_or_return'
enforcement for vCont.
---
gdb/testsuite/gdb.server/require-running.exp | 1 -
gdbserver/server.cc | 1 -
2 files changed, 2 deletions(-)
diff --git a/gdb/testsuite/gdb.server/require-running.exp b/gdb/testsuite/gdb.server/require-running.exp
index f06ece3496d..179c7ccc1ca 100644
--- a/gdb/testsuite/gdb.server/require-running.exp
+++ b/gdb/testsuite/gdb.server/require-running.exp
@@ -49,7 +49,6 @@ set packets \
"s" \
"S00" \
"T1" \
- "vCont;c" \
"x1234,1" \
"X1234,1:00" \
"z0,0x1234,0" \
diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index ebde831d603..37859f26b7e 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -3575,7 +3575,6 @@ handle_v_requests (char *own_buf, int packet_len, int *new_packet_len)
if (startswith (own_buf, "vCont;"))
{
- require_running_or_return (own_buf);
handle_v_cont (own_buf);
return;
}
--
2.34.1
Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2026-04-17 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 10:35 Tankut Baris Aktemur [this message]
2026-04-17 14:10 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417103502.2051279-1-tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox