From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ISxuOxLo4WkY2B0AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 03:58:10 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QTZ9LSlH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6vsR4jN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QTZ9LSlH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6vsR4jN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DBFA61E0C3; Fri, 17 Apr 2026 03:58:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 467151E0B1 for ; Fri, 17 Apr 2026 03:58:09 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id CB8614BB58BE for ; Fri, 17 Apr 2026 07:58:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB8614BB58BE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QTZ9LSlH; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6vsR4jN; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QTZ9LSlH; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=W6vsR4jN Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 499FE4C515FA for ; Fri, 17 Apr 2026 07:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 499FE4C515FA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 499FE4C515FA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776412647; cv=none; b=qf/GLJZUQyXyREgJ/FwynoQyrMQMjn2NeMmJKBtUWFJuaRf9n2ErzMoyEllyBqafx0QIpDljqHd562YoYo3SvWPaidXYEkG6Q9OzZCnw4x4oUPwcqStbNcUMlO0u/okzENncDXnaEW2gVfzX7HO5gwn27MN5UA/Fll9h1L8j1vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776412647; c=relaxed/simple; bh=WXHWgVeHUDgwfc0/4DlDZQvjKdahEjHmHXIxOTIHQzE=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=lxLgm61MHKwsvN9b3mS4yoc0XK75YPL+5xB6xBIFps3WLr9IdHDznbkSCPxQT8B5r9+mZvL9SHJPFSNfOLa6tXz9lT25C8CPiKU3B4e90dz7U3b3LFD3oyaq9rKxJkXAzC/uVfz7Qy4U2OzMzC4mLGZY8S0OX7m7PghVYZYCTGE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 499FE4C515FA Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0446E5BE47 for ; Fri, 17 Apr 2026 07:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wDndL7ccoDT+cFZfjmSuwHjuwh7fLuYtu5Q7ud4g9AQ=; b=QTZ9LSlHTN5ineN2Z+wIz0Yzi1OTBJYtIEMX0xuLuCBwpQVZJi29hKFIx5XMGpjNF3oVtj NQIp+cbGjqN8jtIHmzZdXwbdQtMIzRcGTjvXhw1pYn/llQW1mNtIbelYT2wnTWKVXtdoQ9 7d4BA4DL9UcqFlSRRaw6FgXmjcYFKQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wDndL7ccoDT+cFZfjmSuwHjuwh7fLuYtu5Q7ud4g9AQ=; b=W6vsR4jNv0JX5V92HcagjSgyn0BxIl/8rlG1NrOZW4TMOXWiMHMt2OFkscjTNmKYbskAws muDWZ1zzmN4IczCw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QTZ9LSlH; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=W6vsR4jN DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wDndL7ccoDT+cFZfjmSuwHjuwh7fLuYtu5Q7ud4g9AQ=; b=QTZ9LSlHTN5ineN2Z+wIz0Yzi1OTBJYtIEMX0xuLuCBwpQVZJi29hKFIx5XMGpjNF3oVtj NQIp+cbGjqN8jtIHmzZdXwbdQtMIzRcGTjvXhw1pYn/llQW1mNtIbelYT2wnTWKVXtdoQ9 7d4BA4DL9UcqFlSRRaw6FgXmjcYFKQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776412640; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wDndL7ccoDT+cFZfjmSuwHjuwh7fLuYtu5Q7ud4g9AQ=; b=W6vsR4jNv0JX5V92HcagjSgyn0BxIl/8rlG1NrOZW4TMOXWiMHMt2OFkscjTNmKYbskAws muDWZ1zzmN4IczCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E3317593AE for ; Fri, 17 Apr 2026 07:57:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OhwUNt/n4WkYHgAAD6G6ig (envelope-from ) for ; Fri, 17 Apr 2026 07:57:19 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v6 0/4] [gdb/tui] Fix crash with debuginfod query Date: Fri, 17 Apr 2026 09:57:15 +0200 Message-ID: <20260417075719.852558-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,sourceware.org:url] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 0446E5BE47 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch series fixes two PRs, PR31449 and PR33794. An initial patch for PR31449 was submitted here [1]. A review comment reported a problem when using C-x C-a to enable TUI instead of "tui enable", not fixed by the patch. This was filed as PR33794. The initial patch fixes PR31449 by calling a function that will force the debuginfod query to happen before enabling the TUI. Changes in v1 [2]: - change approach: - add a layout with only the command window, and activate that layout first, making sure that we finalize the initialization of the command window before we activate the initial layout Changes in v2 [3]: - change approach: - add a facility defer_tui_rerender that allows deferral of calling the rerender methods (which draws everything but the window borders), and - use that facility to postpone rerendering in tui_enable until after io has been initialized. Changes in v3 [4]: - change approach: - add a check at the start of tui_inject_newline_into_command_window that avoids the SIGFPE. Changes in v4 [5]: - change approach: - bail out if debuginfod enabled is set to ask when entering TUI. This is very similar to [1]. Unlike the previous approaches, this does fix PR33794 as well. Changes in v5 [6]: - fixed some trivial errors in the v4. - split the v4 patch up into three patches, - added a patch introducing defaulted_query_auto_answers_p, - used defaulted_query_auto_answers_p to make the fix less intrusive Changes in v6: - committed first patch of v5, a refactor patch - change approach: - revert to v3 approach for PR31449. The error thrown in tui_enable also affected "gdb -tui", and for that scenario could only be avoided with "set debuginfod enabled on/off" in .gdbearlyinit. - describe entire version history in series description, instead of partly in the series description and partly in one of the patches Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31449 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33794 [1] https://sourceware.org/pipermail/gdb-patches/2024-March/207224.html [2] v1 https://sourceware.org/pipermail/gdb-patches/2026-January/224038.html [3] v2 https://sourceware.org/pipermail/gdb-patches/2026-January/224103.html [4] v3 https://sourceware.org/pipermail/gdb-patches/2026-February/225210.html [5] v4 https://sourceware.org/pipermail/gdb-patches/2026-February/225351.html [6] v5 https://sourceware.org/pipermail/gdb-patches/2026-March/226009.html Tom de Vries (4): [gdb/tui] Fix crash with debuginfod query (tui enable) [gdb] Add debuginfod_enabled_ask_p [gdb] Add defaulted_query_auto_answers_p [gdb/tui] Fix crash with debuginfod query (C-x C-a) gdb/debuginfod-support.c | 40 ++++++++++--- gdb/debuginfod-support.h | 5 ++ gdb/testsuite/gdb.tui/query-foo.c | 24 ++++++++ gdb/testsuite/gdb.tui/query.exp | 98 +++++++++++++++++++++++++++++++ gdb/tui/tui-io.c | 3 + gdb/tui/tui.c | 10 +++- gdb/tui/tui.h | 2 +- gdb/utils.c | 55 +++++++++++++++-- gdb/utils.h | 4 ++ 9 files changed, 224 insertions(+), 17 deletions(-) create mode 100644 gdb/testsuite/gdb.tui/query-foo.c create mode 100644 gdb/testsuite/gdb.tui/query.exp base-commit: 19bcbe810d8c49eb05324624c0af72091d38c4a7 -- 2.51.0