From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ocHeHyV74mmhvh8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 14:25:41 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=UerF/+Hw; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E59681E0A2; Fri, 17 Apr 2026 14:25:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3A68E1E0CA for ; Fri, 17 Apr 2026 14:25:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A48194CD2000 for ; Fri, 17 Apr 2026 18:25:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A48194CD2000 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=UerF/+Hw Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 3663E4BC0577 for ; Fri, 17 Apr 2026 18:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3663E4BC0577 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3663E4BC0577 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776450247; cv=none; b=LW71hEcoFrUPp/gC4TX4HqNRyf4oHwx0J2cOjIls1y47ITqoRcf8yRqPWSKPZ2h/KXsOGpMfCN5t1I/W+mS9Rsclg6HbZzN06y44gqSopxYdquKekGTpCQkyM6OFUxbsvNS/BH8IXpyYJI7HoFlkch2LPsjdR1ehIK/TYRX6ba4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776450247; c=relaxed/simple; bh=gedMcwMFTVt0ViDT5Bn7VGWT8dXEHmYHot2bhvk1B64=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=I+hBH0WpSBli4TOa/m61tW4yPIiJL1UfPXtoF7lKRY+kOXTwaaFE+uHf9jYaok8S/xDs/GegkTxIW0X7X8EuXIIrUuSe5Cvxx+TMw/WVZJNF/+JKjxaFWfsPD0BZ5qbRZgxi8omIwTkCA1BcyKNCQJJh5+L4g5PdOOnm6LvQXhc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3663E4BC0577 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-7dbca22dbfeso554025a34.1 for ; Fri, 17 Apr 2026 11:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1776450246; x=1777055046; darn=sourceware.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=skJLvWMe2++hbzDHGxxSNyE4HW9Vmrzqi186j5MN/vo=; b=UerF/+HwsSz2nOpPjiOk7+qqb/SA6qjHPzmKy69BXmvFt/Z2fixwfCIVMThl9HtkkQ 29fFbvOUnnfhMcg3ENmtgPaSAr3rT1SqsnVt2x0PmJBZiO+3ate2JnbgEsw+R8kw5FUl SAshj1+CHHt36Bs/3rpWVU+FGnr/oJ97jkJETsL2zOKKB9RJH8u1HHG8/pMhs/GwHgrD +3UBSNu2qFyY1HB/8id41WlUqah2eq3zyc9/Q56cS7vAGCvoGoeBFB3OTd7P9uHJvQUI XX+MKr4T/G1MSWpzZj1H4jOTsINVdWR2GyNxOk0c4712zSiKIXh3BuC1naKk2d4WV9KZ x+Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776450246; x=1777055046; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=skJLvWMe2++hbzDHGxxSNyE4HW9Vmrzqi186j5MN/vo=; b=ZA/o8RaLKxkipEv+4wdzUoV9GnoTkOu9K5cLQsJT73d83SKpYjfOX7Rvp8KeWbUDBi GErZaTlkg44cRWVamfSLmdV9DzSfIL2Z1w7SZSPAizfVfEG5pZU5LQ1GxkdRmAybtkB4 /w9Vas/ovwIImeQNjfvcuOKn37317k92KgXpQsLFtJRxDf528EMlHSB/an1HEMwEWSPq EZopBOV29R12j4J5cvOyYnXTMcu8xpg+QQagYx6V5LlWN3ysvKwAtmTW0kIDz6lgEBNc i7ROtPT5ZZ9IC61Gb0LPP4+pdOai47ozbjSUtuD+INQaaQQ7bQyjX+jJM9ESU8EuMC8N ohyA== X-Gm-Message-State: AOJu0Yy0Sv1XX7mYzWkBeiSG6fdVQHKkYtPxQdY/Fg9z3jW2d3pbVsW7 KhSiRfRIH3JVbcAh2almxFsGkDWRrRphXKLazwVGAzradAN759tR/k/QkCXPmk8/D/DhMBrJGmT UJKs= X-Gm-Gg: AeBDiesxjDkO8zNAdPgm0yKIWNJ2nf9b7UwKU2QY4FzShcsfXy7pjQD44gy+EGhMk7V LbxPjq208gyn4k9ihRU+u51sNBRjhOj//P8qGBWVtnKCuLAy+L9PB6MG0zT9wgHteCfUXMthiQ4 LlvxuggaTDYuiq1UNMNYuQHndaOYHe8UjvGbxwHlmgmcwa6ajkbnhfTYi3NqGKmqv51okpic7cp IWKJ1nEUcGA0WZ32/cQsgdsjVnx4Wq5ZQjLzK+dC9fX4/L+ZFlfntDVE1iCcCnlNVhNRQ37Chbh Zq5+1NiyPQnVqNUV3YHZ9Q5IMAz/Be6tc9258pLtMm4zFMYIUAvCye1USQU2Q0iQnQ+Sq75MGdh x9UMukWp83zUDdMGr6hcXutPazxarrLpSZ2mwoAp8AySPKygxmKHCBiGy4vIi0VtiEGU1TKCE5A dOnCxVgqR3xGX6kd1kExqracLjRhEut45yLemv+YAfHduuqRuTM5eFaYcY6vPVdPzm X-Received: by 2002:a05:6830:448c:b0:7d7:fb03:f6ba with SMTP id 46e09a7af769-7dc95271604mr2963433a34.21.1776450246383; Fri, 17 Apr 2026 11:24:06 -0700 (PDT) Received: from [192.168.0.26] (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dc9a7102b0sm1182475a34.0.2026.04.17.11.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 11:24:06 -0700 (PDT) From: Tom Tromey Date: Fri, 17 Apr 2026 12:24:04 -0600 Subject: [PATCH 2/6] Remove some dead code from buildsym.c MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260417-list-in-scope-v1-2-0deb050fc03d@adacore.com> References: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> In-Reply-To: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This patch removes some code from buildsym.c that, according to the comment, was only used for some SCO or maybe COFF thing. This code is dead now, and it was a hack anyway and probably should never have been allowed. --- gdb/buildsym.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/gdb/buildsym.c b/gdb/buildsym.c index aa95889424b..f6cc5c153c2 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -635,18 +635,8 @@ buildsym_compunit::end_compunit_symtab_get_static_block (CORE_ADDR end_addr, /* Make a block for the local symbols within. */ finish_block (cstk.name, cstk.old_blocks, NULL, cstk.start_addr, end_addr); - - if (!m_context_stack.empty ()) - { - /* This is said to happen with SCO. The old coffread.c - code simply emptied the context stack, so we do the - same. FIXME: Find out why it is happening. This is not - believed to happen in most cases (even for coffread.c); - it used to be an abort(). */ - complaint (_("Context stack not empty in end_compunit_symtab")); - m_context_stack.clear (); - } } + gdb_assert (m_context_stack.empty ()); /* Executables may have out of order pending blocks; sort the pending blocks. */ -- 2.53.0