From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EaNgMgY932kKjxgAWB0awg (envelope-from ) for ; Wed, 15 Apr 2026 03:23:50 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Vh9nXEXR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C63D81E0CA; Wed, 15 Apr 2026 03:23:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B4C421E0BC for ; Wed, 15 Apr 2026 03:23:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 696C14BA23E2 for ; Wed, 15 Apr 2026 07:23:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 696C14BA23E2 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Vh9nXEXR Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by sourceware.org (Postfix) with ESMTPS id 84B154BA23CC for ; Wed, 15 Apr 2026 07:23:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84B154BA23CC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84B154BA23CC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.8 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776237804; cv=none; b=P6rN4io/1oAXbulRr3dpA97C6Vafq7eRhvRNpHTKtJXSbGgeXQrpCTIZxpJfcCV/GUYKAL/LLrQAiL1CWEj3j1rhPhJgNdCxPXVZSaVT+ODbp3fxDMaiPiCht7yS7u07t0IcYw3uBAR4ha3l5Nc/lm5wjQmcfBP2+BXnIsufQB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776237804; c=relaxed/simple; bh=AH9eFmbaNIQZfccp1p1jNSCiKOVSwsBvdPaFR4Kp66g=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=cjJsZK3zXwJQgGnyC3KPkF5ePgZuFgoGiS81KF/ARKDjWrxIAaPFjIueNMm6yFJZNUgNVm5a2jyPJO5PL8dUtEH/POW2asvM6i7ZtvysV95zVyNxYIvmCucse9fjU0VppA0JYGFqisDATyF4Fbjogtnbowgmh4ONQqU6JjXseKQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84B154BA23CC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776237805; x=1807773805; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AH9eFmbaNIQZfccp1p1jNSCiKOVSwsBvdPaFR4Kp66g=; b=Vh9nXEXRXDQLKkJx7be9YafNRUAbqjVwps0+ik/20EoixyVTUl9py+ww qMJIsw6AzGO1OMTsJWAMyzd30Q9gdgWxuFf9absCGx8oC8h/nPvU3vn4r F92NvSZeCCBFBNQ7aXMe0zRSN/bbZgTEumA8XjYxuwOU4/0kev5fpIIqV oMVoVFLcY2ayNphP68wIGE50l+/tSRUtGpOKMTIfpyGfffFUmt42WUZIt wWfooojf6baRvvNEFDIhzwfqGyFfI2R2mqribiBrCat05eKkVXMnd7zIN 9F5BFyKklWHZnhNZK6+2jU4uG0TGJWOX8fwJqkqg8smMOLb+BOw0s/p7E w==; X-CSE-ConnectionGUID: IdaEjOoOQwyXoxFQC5dTNQ== X-CSE-MsgGUID: v0rAWjnbSfqPIBpVMak7OA== X-IronPort-AV: E=McAfee;i="6800,10657,11759"; a="94776411" X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="94776411" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2026 00:23:24 -0700 X-CSE-ConnectionGUID: /6j87k2fQ+qbnpEh1x5zLw== X-CSE-MsgGUID: UJDQbJ3BSJS6gB6zQ8350w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,179,1770624000"; d="scan'208";a="230194956" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2026 00:23:23 -0700 From: Markus Metzger To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: [PATCH v8 3/4] gdb, infrun, record: move no-history notification into normal_stop Date: Wed, 15 Apr 2026 07:23:10 +0000 Message-Id: <20260415072311.3597558-4-markus.t.metzger@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260415072311.3597558-1-markus.t.metzger@intel.com> References: <20260415072311.3597558-1-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Leave calling gdb::observers::no_history.notify to normal_stop based on the last waitstatus. Reviewed-By: Guinevere Larsen --- gdb/infrun.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index ac3449d1e19..0c8d737b5fe 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -6595,8 +6595,6 @@ handle_inferior_event (struct execution_control_state *ecs) if (handle_stop_requested (ecs)) return; - interps_notify_no_history (); - /* Cancel an in-flight step-over. It will not succeed since we won't be able to step at the end of the execution history. */ { @@ -9077,7 +9075,6 @@ keep_going_pass_signal (struct execution_control_state *ecs) if (ecs->event_thread->control.is_replaying && !target_record_is_replaying (ecs->event_thread->ptid)) { - interps_notify_no_history (); ecs->ws.set_no_history (); set_last_target_status (ecs->target, ecs->ptid, ecs->ws); stop_print_frame = true; @@ -9788,6 +9785,9 @@ normal_stop () if (saved_context.changed ()) return true; + if (last.kind () == TARGET_WAITKIND_NO_HISTORY) + interps_notify_no_history (); + /* Notify observers about the stop. This is where the interpreters print the stop event. */ notify_normal_stop ((inferior_ptid != null_ptid -- 2.34.1 Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928