From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ejZlL+pb2mkyQhIAWB0awg (envelope-from ) for ; Sat, 11 Apr 2026 10:34:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=monnerat.net header.i=@monnerat.net header.a=rsa-sha256 header.s=mnet header.b=sad0GywZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AEA7D1E04F; Sat, 11 Apr 2026 10:34:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 378971E04F for ; Sat, 11 Apr 2026 10:34:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 4D3754BA23DD for ; Sat, 11 Apr 2026 14:34:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D3754BA23DD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=monnerat.net header.i=@monnerat.net header.a=rsa-sha256 header.s=mnet header.b=sad0GywZ Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id B9A764BA23D4 for ; Sat, 11 Apr 2026 14:33:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9A764BA23D4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=monnerat.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=monnerat.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9A764BA23D4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=46.226.111.226 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775918034; cv=none; b=EmiuIKpVSJwWkGWC4n7Ad1E2hzz/V9cP8JRCBzVGv9gkMYPv3kuMviK0pGNE6l4PRw0joJvDro98DhLm8kfftWffx/xCWyHiD3iCAwmZyMGXSLxs3ziS4gVyUhI65cZWCuBMtlfynXNUSoQXkW6/Uy+prXFUg0gfO8F/aEdAlV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775918034; c=relaxed/simple; bh=4DFyBTdYh5s0fPcqZiDJuTZNNZq9PGKILB3F+WJQOZ8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VHzA2YnnrqJk9ho0KECyCcryYjPLdGPt8ChjGGwmtaKECGc/ciWawsazPh9cFvBqiD3QdMVN//N+38gPySHT/hjx8XNX76AIsrfQvwshJIDIXreDVdmFkTAXqK8H5I4u/c290e3TGaeeSirvoYQUghXIbntXhiWeCNU4bH4u6Qc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B9A764BA23D4 Received: from patrick.monnerat ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 63BEXkJD027123 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Apr 2026 16:33:52 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 63BEXkJD027123 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=monnerat.net; s=mnet; t=1775918032; bh=4DFyBTdYh5s0fPcqZiDJuTZNNZq9PGKILB3F+WJQOZ8=; h=From:To:Cc:Subject:Date:From; b=sad0GywZK6Q9/O/Q1/jGBkcTDT+lb11qk4unY/6b+r4HRh+AaW4hBEJs6Kkfxe9Jq +nsefaOA+9jVbVMQQskn6XzuEhWc2F9s++TLeKFgAHasURwS254SzQvT28n4TUamu7 WBj9IGjZ9uX0Qou0k46R96fP7Jx07Y9VjAy1bs8U= From: Patrick Monnerat To: gdb-patches@sourceware.org Cc: Patrick Monnerat Subject: [PATCH] Implement windows_nat_target::stop Date: Sat, 11 Apr 2026 16:32:43 +0200 Message-ID: <20260411143242.143320-2-patrick@monnerat.net> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Insight makes a difference between hitting Ctrl-C (that triggers target::pass_ctrlc) and clicking the GUI stop button, triggering target::stop). As windows_nat did not implement the stop method, the GUI stop button was inoperant on Windows. --- gdb/windows-nat.c | 6 ++++++ gdb/windows-nat.h | 1 + 2 files changed, 7 insertions(+) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index e25ae81f054..d08faaa89ba 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -909,6 +909,12 @@ windows_nat_target::pass_ctrlc () interrupt (); } +void +windows_nat_target::stop (ptid_t ptid) +{ + interrupt (); +} + /* Get the next event from the child. Returns the thread ptid. */ ptid_t diff --git a/gdb/windows-nat.h b/gdb/windows-nat.h index 8263729554b..4368a29b2bb 100644 --- a/gdb/windows-nat.h +++ b/gdb/windows-nat.h @@ -141,6 +141,7 @@ struct windows_nat_target : public inf_child_target void interrupt () override; void pass_ctrlc () override; + void stop (ptid_t ptid) override; const char *pid_to_exec_file (int pid) override; -- 2.53.0