From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0Xu2FnXN2GlAXhAAWB0awg (envelope-from ) for ; Fri, 10 Apr 2026 06:14:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1zKj5xAi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hqA7LfgB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1zKj5xAi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hqA7LfgB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 57DD01E08C; Fri, 10 Apr 2026 06:14:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC6381E08C for ; Fri, 10 Apr 2026 06:14:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 176DA4BA2E3B for ; Fri, 10 Apr 2026 10:14:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 176DA4BA2E3B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1zKj5xAi; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hqA7LfgB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=1zKj5xAi; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hqA7LfgB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 684A04BA23C1 for ; Fri, 10 Apr 2026 10:13:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 684A04BA23C1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 684A04BA23C1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775815980; cv=none; b=nTPgtCtBfAUnVwhZkkhUOoKikYx0fEAyF0zflNWRd0D5K7/KHvrEeyyxj+N4lPlo8cem6SR8FQuDhCssZoNXMy5gPF6wbIlYSBX+DsVgcNHMhvJCq8wnZEWRKUUbbJi2pvEEQVauY3p1K3XMgtVORGjlHw+v+0nZmOXiAJlCUgI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775815980; c=relaxed/simple; bh=m0+k1qtpoLQO8jo+7UVRXzDPCIoNyzoLDICJR0KTx6s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=NWLWtVRdWIp+ENNCfwDLBf9dNGUdsk0XhnZslLks+9Zg9XbZfyN+sigoEy5fMO8ans/fkRStw1jzNhVo5zsRWBdICppe02OCshHKo5gdzn6RnORRqXIAY6IoyRJKDWjfsmnY0tK4ZW5Aw1aMVSDnT+e/5WHeBy2XSu1OiCld5Qo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 684A04BA23C1 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3F5065BD2D for ; Fri, 10 Apr 2026 10:12:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775815973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65D26TrCwaPs3yscpy5iCCUG4//P13ad95EpR+lidAE=; b=1zKj5xAiJpbXUbSQKpkgDAsffhaF3x86dExThvSCB9HOVvvN1SnjKt6RW3br/C+ITYKHc8 PhfWuUa0BvI9F5Ev/LMSRx6SwALCiRTaia5XUYsg1Go/gmte1B9wn/9VMg6rzXbQOnuGnJ k0HSLSmMnRlsoHbGn6oFFrWcTHPfgB0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775815973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65D26TrCwaPs3yscpy5iCCUG4//P13ad95EpR+lidAE=; b=hqA7LfgB91L3FKxWn24xuVwHBqAMECB3b3txc2QHqWS60ou66Vt9aaDyJ6KlH/z6ok0H1y 3FYa0ZquO9D+CJAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=1zKj5xAi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hqA7LfgB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775815973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65D26TrCwaPs3yscpy5iCCUG4//P13ad95EpR+lidAE=; b=1zKj5xAiJpbXUbSQKpkgDAsffhaF3x86dExThvSCB9HOVvvN1SnjKt6RW3br/C+ITYKHc8 PhfWuUa0BvI9F5Ev/LMSRx6SwALCiRTaia5XUYsg1Go/gmte1B9wn/9VMg6rzXbQOnuGnJ k0HSLSmMnRlsoHbGn6oFFrWcTHPfgB0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775815973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=65D26TrCwaPs3yscpy5iCCUG4//P13ad95EpR+lidAE=; b=hqA7LfgB91L3FKxWn24xuVwHBqAMECB3b3txc2QHqWS60ou66Vt9aaDyJ6KlH/z6ok0H1y 3FYa0ZquO9D+CJAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2786A4A0B3 for ; Fri, 10 Apr 2026 10:12:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UFxzCCXN2GlFaQAAD6G6ig (envelope-from ) for ; Fri, 10 Apr 2026 10:12:53 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v4 1/4] [gdb/testsuite] Extend gdb.opt/inline-cmds.exp Date: Fri, 10 Apr 2026 12:12:49 +0200 Message-ID: <20260410101252.1805303-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260410101252.1805303-1-tdevries@suse.de> References: <20260410101252.1805303-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 3F5065BD2D X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Andrew Burgess When using this tentative patch [1], GDB regresses like this in test-case gdb.opt/inline-cmds.exp: ... Temporary breakpoint 1, main () at inline-cmds.c:64 64 y = 8; /* set mi break here */ (gdb) s +main () at inline-cmds.c:66 66 result = func1 (); (gdb) s func1 () at inline-cmds.c:35 35 bar (); (gdb) ... but the regression doesn't produce a FAIL. The regression does produce a FAIL during the part of the test that runs in MI mode. Extend the test so the regression also produces a FAIL in CLI mode. [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226272.html --- gdb/testsuite/gdb.opt/inline-cmds.exp | 33 ++++++++++++++++++--------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.opt/inline-cmds.exp b/gdb/testsuite/gdb.opt/inline-cmds.exp index 12db0709fe6..9bfc32f58b3 100644 --- a/gdb/testsuite/gdb.opt/inline-cmds.exp +++ b/gdb/testsuite/gdb.opt/inline-cmds.exp @@ -176,24 +176,35 @@ if { $bt_test == 0 } { # "stop" at the call sites before entering them. runto_main -set msg "step into func1" -set saw_call_site 0 -gdb_test_multiple "list" $msg { - -re "($first|$opt).*$gdb_prompt $" { +set saw_call_site false +set saw_main_frame false +# Don't send the command using gdb_test_multiple, as it will be +# injected into the regexp that start with '^' and use '-wrap', and we +# send a different command using 'send_gdb' within the gdb_test_multiple. +send_gdb "list\r" +gdb_test_multiple "" "step into func1" { + -re "^(list|step)\r\n" { + exp_continue + } + -re -wrap "^\[^\r\n\]*($first|$opt)\[^\r\n\]*" { send_gdb "step\r" exp_continue } - -re "result = func1.*$gdb_prompt $" { - set saw_call_site 1 + -re -wrap "^\[^\r\n\]*y = 8\[^\r\n\]*" { + send_gdb "step\r" + exp_continue + } + -re "^main \\(\\) at \[^\r\n\]+\r\n" { + set saw_main_frame true + exp_continue + } + -re -wrap "^\[^\r\n\]*result = func1 \\(\\);" { + set saw_call_site true send_gdb "step\r" exp_continue } -re "func1 \\\(\\\) at .*\r\n$decimal.*bar \\\(\\\);\r\n$gdb_prompt $" { - if { $saw_call_site } { - pass $msg - } else { - fail $msg - } + gdb_assert { $saw_call_site && !$saw_main_frame } $gdb_test_name } } -- 2.51.0