From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zTLiMEd82Gno4g8AWB0awg (envelope-from ) for ; Fri, 10 Apr 2026 00:27:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H5FXdvYL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B41A31E08C; Fri, 10 Apr 2026 00:27:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3439D1E08C for ; Fri, 10 Apr 2026 00:27:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AA9264BA2E15 for ; Fri, 10 Apr 2026 04:27:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA9264BA2E15 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H5FXdvYL Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 900DC4BA2E0F for ; Fri, 10 Apr 2026 04:27:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 900DC4BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 900DC4BA2E0F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775795244; cv=none; b=gWJKPa+pKRCGgboxq2S2uQRu2enfdwvs/aT15QVza4dqJax7goDNpP5u7dcOLNj6SEct/NXU1BJLTMln/uIpdzl6N8F3fWCkzgGMNtVGUaId+EySHbHW17ZJmDES0YfI7k1WcCH/U4wJEWU/cP9FWs7CoLcTMRKzhrCkbK/Ac4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775795244; c=relaxed/simple; bh=c3rIe8xNLakRWkH1p7RMQOPPnfd5otkmUVk36/nXJpQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=aLr6GaybHnHVIufi5l/4XfmMYFmQqcNAfXWThov695YzRvy4Y8dVilWJgauTtYFzn4jv/doVOAy5wAp30tXjBrPw7DPGiIWiztpsJA1gV4WwXu3LE62yN6r1q8W0/dUTbJapb5EetXLKPOyqIWEFgwpl0ubcxuooqYeVtVjnmt0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 900DC4BA2E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775795244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2QQe99DMPd/LXyJYB4icDekEyzrfi4sYe8fjYpS53Q=; b=H5FXdvYLHgka+P85PH2n8KRvvGaereoT1/m3hmxE7nm1M9xKFPV705S/DVu+ZIKY4nfVWd NnrGcODiUvr/QIbAJN813WRbFodRRBGLWAEcMJrbWYN+E16owQspq+9DWXfxXOCrpRF1ud +5CHq04bqeYQoPm1DRBR1KJEOVqYlYY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-bPBbhk4IMXuRkfl5vA0mRQ-1; Fri, 10 Apr 2026 00:27:22 -0400 X-MC-Unique: bPBbhk4IMXuRkfl5vA0mRQ-1 X-Mimecast-MFC-AGG-ID: bPBbhk4IMXuRkfl5vA0mRQ_1775795241 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B899F19560BB for ; Fri, 10 Apr 2026 04:27:21 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.80.122]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 325723000C16 for ; Fri, 10 Apr 2026 04:27:20 +0000 (UTC) Date: Thu, 9 Apr 2026 21:27:18 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH] Clean up comment in language.h Message-ID: <20260409212718.5254aadc@f42-zbm-amd> In-Reply-To: <20260408150123.3095252-1-tromey@adacore.com> References: <20260408150123.3095252-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rlbnCzEpiykoowpzT-6S3G9LOJL7x1tPDTH3eqMGeDg_1775795241 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 8 Apr 2026 09:01:23 -0600 Tom Tromey wrote: > I noticed a comment in language.h that was partially obsolete. This > patch removes the obsolete bits and makes a small change to the rest. > --- > gdb/language.h | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/gdb/language.h b/gdb/language.h > index 67e6ac438b6..da903eb702d 100644 > --- a/gdb/language.h > +++ b/gdb/language.h > @@ -661,17 +661,11 @@ extern const struct language_defn *get_current_language (); > always points to *some* valid struct; it can be used without checking > it for validity. > > - The current language affects expression parsing and evaluation > - (FIXME: it might be cleaner to make the evaluation-related stuff > - separate exp_opcodes for each different set of semantics. We > - should at least think this through more clearly with respect to > - what happens if the language is changed between parsing and > - evaluation) and printing of things like types and arrays. It does > - *not* affect symbol-reading-- each source file in a symbol-file has > - its own language and we should keep track of that regardless of the > - language when symbols are read. If we want some manual setting for > - the language of symbol files (e.g. detecting when ".c" files are > - C++), it should be a separate setting from the current_language. */ > + The current language affects expression parsing and evaluation and > + printing of things like types and values. It does *not* affect > + symbol-reading -- each source file in a symbol-file has its own > + language and we should keep track of that regardless of the > + language when symbols are read. */ > > #define current_language (get_current_language ()) > > > base-commit: e3998113f9b66cbd0806424ac4700d2aaf8d0f77 LGTM. Approved-by: Kevin Buettner