From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Clean up comment in language.h
Date: Wed, 8 Apr 2026 09:01:23 -0600 [thread overview]
Message-ID: <20260408150123.3095252-1-tromey@adacore.com> (raw)
I noticed a comment in language.h that was partially obsolete. This
patch removes the obsolete bits and makes a small change to the rest.
---
gdb/language.h | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/gdb/language.h b/gdb/language.h
index 67e6ac438b6..da903eb702d 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -661,17 +661,11 @@ extern const struct language_defn *get_current_language ();
always points to *some* valid struct; it can be used without checking
it for validity.
- The current language affects expression parsing and evaluation
- (FIXME: it might be cleaner to make the evaluation-related stuff
- separate exp_opcodes for each different set of semantics. We
- should at least think this through more clearly with respect to
- what happens if the language is changed between parsing and
- evaluation) and printing of things like types and arrays. It does
- *not* affect symbol-reading-- each source file in a symbol-file has
- its own language and we should keep track of that regardless of the
- language when symbols are read. If we want some manual setting for
- the language of symbol files (e.g. detecting when ".c" files are
- C++), it should be a separate setting from the current_language. */
+ The current language affects expression parsing and evaluation and
+ printing of things like types and values. It does *not* affect
+ symbol-reading -- each source file in a symbol-file has its own
+ language and we should keep track of that regardless of the
+ language when symbols are read. */
#define current_language (get_current_language ())
base-commit: e3998113f9b66cbd0806424ac4700d2aaf8d0f77
--
2.53.0
next reply other threads:[~2026-04-08 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:01 Tom Tromey [this message]
2026-04-10 4:27 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260408150123.3095252-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox