From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6RS+DYs31mkBWA0AWB0awg (envelope-from ) for ; Wed, 08 Apr 2026 07:10:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fe5ZCbmJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SdO6ESGq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fe5ZCbmJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SdO6ESGq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 327D21E0BC; Wed, 08 Apr 2026 07:10:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 052CE1E04F for ; Wed, 08 Apr 2026 07:10:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 19F334BA2E09 for ; Wed, 8 Apr 2026 11:10:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 19F334BA2E09 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fe5ZCbmJ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SdO6ESGq; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fe5ZCbmJ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=SdO6ESGq Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 828434BA23C3 for ; Wed, 8 Apr 2026 11:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 828434BA23C3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 828434BA23C3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775646515; cv=none; b=NzPbin4jzv82OWmBkJGxbDVneLQmOi2KwfH3vmPfLZ+dbMojRehLJXvX6h9/VILXfoH4AcjQlZAR2aiE3PNnuvfaodxYlY4QOP1J5HJdPkWYwMLSX4JGdF3CSKlHgI99+ZpnS/SwY0iYm4nwm+75uxrLQmsFA9ra2wp80/WQahc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775646515; c=relaxed/simple; bh=kGR4upGYk5xXwm/npIYmtNFxMZsy8lPzv6WepaM54SM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=xUuvf4C0L2nNt9UjgCh5Z82khg0J9pZMtWumBrdFhhJWsbgJNqKw8nDpzbuUIX5Vlc4SBXyW1ktGb9VZSOEpq5Wu3/3XWvMsIVaPDgExCJuL95GVortgtS/E2HveQKilM78fq6E2zpjixYrGsqYDTkVMkYi6WD580qfo9VwrQkg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 828434BA23C3 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DB07D4E97C for ; Wed, 8 Apr 2026 11:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775646507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9sROvAgMhky8CNFPQwg8fslCiB4RHK4RbGm6/hChvtQ=; b=fe5ZCbmJUaNdrTe+gk7rMLnMOuE9muTfr/7V7kIqIQjo0fczsn42lHBbHYqLau+3qpN42C Kxc/YYM4n3ipytQlsviKFarZ+YL/EHDJpHWB4gX6BBYUjIhBusLngWPusIja/dyU3zqbkl 5kOmm0URmyJbd93FaVvzsaiSQRrDK3U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775646507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9sROvAgMhky8CNFPQwg8fslCiB4RHK4RbGm6/hChvtQ=; b=SdO6ESGqvbJSKK7NunDoajP/k8ijSHK9MyG1tvK7Zl1ZgBfij6pc6zeHgoJNjATiGeyHEr nV9JXSpXsG6ryjCw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=fe5ZCbmJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SdO6ESGq DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775646507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9sROvAgMhky8CNFPQwg8fslCiB4RHK4RbGm6/hChvtQ=; b=fe5ZCbmJUaNdrTe+gk7rMLnMOuE9muTfr/7V7kIqIQjo0fczsn42lHBbHYqLau+3qpN42C Kxc/YYM4n3ipytQlsviKFarZ+YL/EHDJpHWB4gX6BBYUjIhBusLngWPusIja/dyU3zqbkl 5kOmm0URmyJbd93FaVvzsaiSQRrDK3U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775646507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9sROvAgMhky8CNFPQwg8fslCiB4RHK4RbGm6/hChvtQ=; b=SdO6ESGqvbJSKK7NunDoajP/k8ijSHK9MyG1tvK7Zl1ZgBfij6pc6zeHgoJNjATiGeyHEr nV9JXSpXsG6ryjCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C2DC44A0B4 for ; Wed, 8 Apr 2026 11:08:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GFBVLis31mmyFwAAD6G6ig (envelope-from ) for ; Wed, 08 Apr 2026 11:08:27 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [RFC 1/2] [gdb/symtab] Propagate search domain to process_queue Date: Wed, 8 Apr 2026 13:08:26 +0200 Message-ID: <20260408110827.2249311-2-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260408110827.2249311-1-tdevries@suse.de> References: <20260408110827.2249311-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: DB07D4E97C X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Propagate the active search domain to function process_queue. No functional changes. --- gdb/dwarf2/read.c | 25 ++++++++++++++----------- gdb/dwarf2/read.h | 3 ++- 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index 4035bba6e45..afd0b60006e 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -935,7 +935,8 @@ static struct type *get_die_type (struct die_info *die, struct dwarf2_cu *cu); static void queue_comp_unit (dwarf2_cu *cu); -static void process_queue (dwarf2_per_objfile *per_objfile); +static void process_queue (dwarf2_per_objfile *per_objfile, + domain_search_flags domain = 0); /* Class, the destructor of which frees all allocated queue entries. This will only have work to do if an error was thrown while processing the @@ -1481,7 +1482,7 @@ struct readnow_functions : public dwarf2_base_index_functions || per_objfile->get_compunit_symtab (per_cu.get ()) == nullptr) continue; if (!search_one (per_cu.get (), per_objfile, cus_to_skip, file_matcher, - listener, lang_matcher)) + listener, lang_matcher, domain)) return false; } return true; @@ -1532,7 +1533,8 @@ load_cu (dwarf2_per_cu *per_cu, dwarf2_per_objfile *per_objfile, static void dw2_do_instantiate_symtab (dwarf2_per_cu *per_cu, - dwarf2_per_objfile *per_objfile, bool skip_partial) + dwarf2_per_objfile *per_objfile, bool skip_partial, + domain_search_flags domain = 0) { { /* The destructor of dwarf2_queue_guard frees any entries left on @@ -1560,7 +1562,7 @@ dw2_do_instantiate_symtab (dwarf2_per_cu *per_cu, && per_objfile->per_bfd->dwp_file == nullptr) queue_and_load_all_dwo_tus (cu); - process_queue (per_objfile); + process_queue (per_objfile, domain); } } @@ -1576,7 +1578,7 @@ dw2_do_instantiate_symtab (dwarf2_per_cu *per_cu, static struct compunit_symtab * dw2_instantiate_symtab (dwarf2_per_cu *per_cu, dwarf2_per_objfile *per_objfile, - bool skip_partial) + bool skip_partial, domain_search_flags domain = 0) { /* Expand the corresponding canonical outermost CU. This will expand the desired CU as a side effect when following the @@ -1587,7 +1589,7 @@ dw2_instantiate_symtab (dwarf2_per_cu *per_cu, dwarf2_per_objfile *per_objfile, { free_cached_comp_units freer (per_objfile); scoped_restore decrementer = increment_reading_symtab (); - dw2_do_instantiate_symtab (per_cu, per_objfile, skip_partial); + dw2_do_instantiate_symtab (per_cu, per_objfile, skip_partial, domain); } return per_objfile->get_compunit_symtab (per_cu); @@ -1925,7 +1927,8 @@ dwarf2_base_index_functions::search_one auto_bool_vector &cus_to_skip, search_symtabs_file_matcher file_matcher, search_symtabs_expansion_listener listener, - search_symtabs_lang_matcher lang_matcher) + search_symtabs_lang_matcher lang_matcher, + domain_search_flags domain) { /* Already visited, or intentionally skipped. */ if (cus_to_skip.is_set (per_cu->index)) @@ -1941,7 +1944,7 @@ dwarf2_base_index_functions::search_one } compunit_symtab *symtab - = dw2_instantiate_symtab (per_cu, per_objfile, false); + = dw2_instantiate_symtab (per_cu, per_objfile, false, domain); gdb_assert (symtab != nullptr); if (listener != nullptr) @@ -3886,7 +3889,7 @@ maybe_queue_comp_unit (dwarf2_cu *cu, dwarf2_cu *dependent_cu) /* Process the queue. */ static void -process_queue (dwarf2_per_objfile *per_objfile) +process_queue (dwarf2_per_objfile *per_objfile, domain_search_flags domain) { DWARF_READ_SCOPED_DEBUG_START_END ("Expanding one or more symtabs of objfile %s ...", @@ -14057,7 +14060,7 @@ cooked_index_functions::search QUIT; if (!search_one (per_cu, per_objfile, cus_to_skip, file_matcher, - listener, lang_matcher)) + listener, lang_matcher, domain)) return false; } return true; @@ -14225,7 +14228,7 @@ cooked_index_functions::search bool check = entry->visit_defining_cus ([&] (dwarf2_per_cu *per_cu) { return search_one (per_cu, per_objfile, cus_to_skip, - file_matcher, listener, nullptr); + file_matcher, listener, nullptr, domain); }); if (!check) return false; diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h index 1150c3cfdca..f21a8bd87aa 100644 --- a/gdb/dwarf2/read.h +++ b/gdb/dwarf2/read.h @@ -1324,7 +1324,8 @@ struct dwarf2_base_index_functions : public quick_symbol_functions auto_bool_vector &cus_to_skip, search_symtabs_file_matcher file_matcher, search_symtabs_expansion_listener listener, - search_symtabs_lang_matcher lang_matcher); + search_symtabs_lang_matcher lang_matcher, + domain_search_flags domain); }; /* Return pointer to string at .debug_str offset STR_OFFSET. */ -- 2.51.0