From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kzCvC0elz2muawUAWB0awg (envelope-from ) for ; Fri, 03 Apr 2026 07:32:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q4alMikd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8MG2J2er; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q4alMikd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8MG2J2er; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 211811E04F; Fri, 03 Apr 2026 07:32:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 399B61E04F for ; Fri, 03 Apr 2026 07:32:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AAD1D4BA23C3 for ; Fri, 3 Apr 2026 11:32:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AAD1D4BA23C3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q4alMikd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8MG2J2er; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Q4alMikd; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8MG2J2er Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 9830C4BA2E1B for ; Fri, 3 Apr 2026 11:31:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9830C4BA2E1B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9830C4BA2E1B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775215917; cv=none; b=cKm+cc3QkwAa02DZmHPPwfZCQSOmDw8rWINj+FR8m+NKXhBoAf9Ybe1gBonJNdkz+FQajKZ5QJ3bSIYA32lrJd/J40HtAuhr4lHi5nWzaWzw7YYNNNw1kNz9T9Xlm64PkhPOvq9kovwde7vvNeSoXD8ONb34DZKsAUidogEtWYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775215917; c=relaxed/simple; bh=lEYOOJXI2vkXwz21egkoxwvZxRN8/qvkmt+AZIOjCeo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=xNVpT3vDyb3f32YRYyqoqpVDMaGkktiH5spaEyyt9DXza9RMh/jHCdHhu8fhRnwtzXka96uSlA+PMmkiBJ0XWp99GnqttR9amnSpmkGrNvtKSrC/X1qu8Z4pNhgKB1WqUcINnorhicF79xTloU/RvItqb4PACqYdbs6zNehCNPo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9830C4BA2E1B Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 99E5A5BD34 for ; Fri, 3 Apr 2026 11:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775215916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UL/vCiHQoTy3Awv+sN34cZuWlcV25BJAltOHLhRBBpA=; b=Q4alMikdnSi5GZzVG/to4cyijbdqk9rKdQ9TiykozFqmiJMDZEbQBbcDHakJsqauNiXJgv j+YV7QadaUI38YXQTh5t74zWebUK8G6HnWnpTsq0yYgmZD3br7MVi51YSleMmzhVggHsKt H2y2JVSUgaLbKnxxGGsEM2AHUflmPPA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775215916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UL/vCiHQoTy3Awv+sN34cZuWlcV25BJAltOHLhRBBpA=; b=8MG2J2er4TLHmbi/5NkUgwIt7JY4S0ILbFCFdmrj5ZPqEgVYGQ0XQ90VamM/chhNjKDDYv kBz2MkxTIS0yGDBg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q4alMikd; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=8MG2J2er DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775215916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UL/vCiHQoTy3Awv+sN34cZuWlcV25BJAltOHLhRBBpA=; b=Q4alMikdnSi5GZzVG/to4cyijbdqk9rKdQ9TiykozFqmiJMDZEbQBbcDHakJsqauNiXJgv j+YV7QadaUI38YXQTh5t74zWebUK8G6HnWnpTsq0yYgmZD3br7MVi51YSleMmzhVggHsKt H2y2JVSUgaLbKnxxGGsEM2AHUflmPPA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775215916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=UL/vCiHQoTy3Awv+sN34cZuWlcV25BJAltOHLhRBBpA=; b=8MG2J2er4TLHmbi/5NkUgwIt7JY4S0ILbFCFdmrj5ZPqEgVYGQ0XQ90VamM/chhNjKDDYv kBz2MkxTIS0yGDBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 842BA4A0A6 for ; Fri, 3 Apr 2026 11:31:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id AYXMHiylz2kaNQAAD6G6ig (envelope-from ) for ; Fri, 03 Apr 2026 11:31:56 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb] Add selftest for tui_setup_io Date: Fri, 3 Apr 2026 13:31:56 +0200 Message-ID: <20260403113156.2890482-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim, suse.de:mid, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: 99E5A5BD34 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Add a selftest for the problem described in commit b171f68e945 ("[gdb/tui] Make tui_setup_io more robust"). --- gdb/tui/tui-io.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gdb/tui/tui-io.c b/gdb/tui/tui-io.c index 4b4bc818430..642b88ead0c 100644 --- a/gdb/tui/tui-io.c +++ b/gdb/tui/tui-io.c @@ -46,6 +46,7 @@ #include "pager.h" #include "gdbsupport/gdb-checked-static-cast.h" #include "logging-file.h" +#include "gdbsupport/selftest.h" /* This redefines CTRL if it is not already defined, so it must come after terminal state related include files like and @@ -1328,3 +1329,36 @@ tui_getc (FILE *fp) return 0; } } + +#if GDB_SELF_TEST +namespace selftests { +namespace tui { +namespace io { + +static void +run_tests () +{ + if (!tui_active) + { + /* Calling tui_setup_io (0) when tui is disabled should have no effect. */ + tui_setup_io (0); + + /* If the output streams are reduced to nullptrs, then the self-test + infrastructure will crash when trying to report these failures. */ + SELF_CHECK (*redirectable_stdout () != nullptr); + SELF_CHECK (*redirectable_stderr () != nullptr); + SELF_CHECK (*redirectable_stdlog () != nullptr); + } +} + +} /* namespace io */ +} /* namespace tui */ +} /* namespace selftests */ +#endif /* GDB_SELF_TEST */ + +INIT_GDB_FILE (tui_io) +{ +#if GDB_SELF_TEST + selftests::register_test ("tui-io", selftests::tui::io::run_tests); +#endif +} base-commit: db4f00be62d3396374df989b5f938c3ebec6833e -- 2.51.0