From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GdT4JF3JxmlWAjwAWB0awg (envelope-from ) for ; Fri, 27 Mar 2026 14:15:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VbQfKxJh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8F1EB1E0BC; Fri, 27 Mar 2026 14:15:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F0F9F1E08C for ; Fri, 27 Mar 2026 14:15:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 5C6F24BA23D3 for ; Fri, 27 Mar 2026 18:15:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C6F24BA23D3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VbQfKxJh Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 711B94BA2E0B for ; Fri, 27 Mar 2026 18:15:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 711B94BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 711B94BA2E0B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774635330; cv=none; b=uV6EqZPZh/iaR3yevPZWWZ4XHCWX9PpN/bmxJvqpP3s/yBTWCIlurRGkM8GbVeq9y1Aw+TeRbD6jwKrmN4H2fGxiH67dRlQrwTMuc8vL60eEQx12aW9ek2M+JsOPub0mo9aEGTeNSX62fhhicpmYi14VsYgQHkjhop/qVWyfkL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774635330; c=relaxed/simple; bh=UNQ4CzSwdFP0Km3ey9UROR6IQA7ElLrt3R8MfP97VLA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=WtIig+QbfH+rdHw6MyXpPTnbJ00B9qt7AGxDNxXutwMjrY5EcEU2oHQIEaWxygLld4hlx4f2vRdIxzQmpymtoWVlfYMTz1zLA3BCNFqLBUPPegXY8nc/OHO9Bd76JII015oxlC5jT/NzOsonulDaKHBZRfDCVsFxZYF99cgbgi0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 711B94BA2E0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774635330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nk25cdZUfTMFTJfcatnPTUoTK2uiz9jf3ds2LkCmrO0=; b=VbQfKxJhHHOIvb4MjCDCcJXTRa6RfVO7V/MviIcKpOs0LaQvpUlglA/NC+hQNaJvgIVEkv OpvxZvrIezOnuFFPwXnZF4K3YbBRh4pde1obYP3GvjWDGiAZsJNyvs557nQs7ToRYpmJuB KbARb6D+Y+CGhw1s1kRnVMNEvT76mhE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-S4LNeotdOu69RjrY5BJ3mQ-1; Fri, 27 Mar 2026 14:15:25 -0400 X-MC-Unique: S4LNeotdOu69RjrY5BJ3mQ-1 X-Mimecast-MFC-AGG-ID: S4LNeotdOu69RjrY5BJ3mQ_1774635322 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67204195608D; Fri, 27 Mar 2026 18:15:21 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.88.79]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 172241955EA2; Fri, 27 Mar 2026 18:15:17 +0000 (UTC) Date: Fri, 27 Mar 2026 11:15:15 -0700 From: Kevin Buettner To: sunilkumar.dora@windriver.com Cc: gdb-patches@sourceware.org, macro@orcam.me.uk, eliz@gnu.org, Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org, tromey@sourceware.org, simark@simark.ca Subject: Re: [PATCH v5 0/2] PR gdb/33747: gdb/ser-unix: fix musl build failure and add POSIX custom baud rate support Message-ID: <20260327111515.3adb29a9@f42-zbm-amd> In-Reply-To: <20260324164527.1446549-1-sunilkumar.dora@windriver.com> References: <20260324164527.1446549-1-sunilkumar.dora@windriver.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vCPVcF_zF4v3RugcNnE0aUVA-zVbt88rc8zZzzpgFLY_1774635322 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 24 Mar 2026 09:45:25 -0700 sunilkumar.dora@windriver.com wrote: > From: Sunil Dora > > On musl-based systems exposes BOTHER, so the > Linux-specific custom baud rate path was being compiled. However, > musl's struct termios does not provide the public members c_ispeed > and c_ospeed, causing a build failure. > > This series fixes the build issue at the macro level (patch 1). > It then adds the preferred POSIX cfsetispeed/cfsetospeed path as the > first choice on platforms where the host libc supports arbitrary baud > rates, such as glibc 2.42 and later, GNU Hurd, and potentially other > libc implementations (patch 2). The existing Linux (termios2/BOTHER) > and Darwin (IOSSIOSPEED) paths remain as fallbacks. > > The two patches are independent: > - Patch 1 is a pure build fix with no functional change. > - Patch 2 adds the new POSIX feature on top of the fixed guard. > > set_custom_baudrate_linux is left unchanged. > > Changes since V4: > - Split into two patches, with patch 1 as a pure build fix > and patch 2 adding the POSIX interface. > - Fixed #if guard formatting and added full stop to the > AC_DEFINE description. > - Removed parentheses from function name references in > commit messages and comments. > - Updated NEWS entry to describe which configurations are > affected. > > v4: https://sourceware.org/pipermail/gdb-patches/2026-March/226133.html > v3: https://sourceware.org/pipermail/gdb-patches/2026-March/225952.html > v2: https://sourceware.org/pipermail/gdb-patches/2026-February/225251.html > v1: https://sourceware.org/pipermail/gdb-patches/2026-February/224968.html > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=33747 Both parts are approved. Thanks for persevering through the many requests for changes. One thing I noticed - Some error messages in ser-unix.c still use "Can not" whereas you uniformly (and correctly IMO) use "Cannot". If you're up for doing a follow-on patch, one which does s/Can not/Cannot/ on the remaining occurrences would be appreciated. Approved-by: Kevin Buettner