From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UdXTH76uwmnvNzcAWB0awg (envelope-from ) for ; Tue, 24 Mar 2026 11:33:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JUWKYfRd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X6rujRnC; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zSRFUATn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ymqYB63h; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6EB2A1E0BC; Tue, 24 Mar 2026 11:33:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 10B091E04F for ; Tue, 24 Mar 2026 11:33:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id A12744BB5895 for ; Tue, 24 Mar 2026 15:33:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A12744BB5895 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=JUWKYfRd; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=X6rujRnC; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zSRFUATn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ymqYB63h Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id EFE1F4BA23E1 for ; Tue, 24 Mar 2026 15:32:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFE1F4BA23E1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EFE1F4BA23E1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774366365; cv=none; b=Ts7OS6k2jeW22ITU043sz/aVCcarxh0HjGdHq9Xhx/0bu0IWg/7NTEIR3XMB5CBkhjKwHD6M+4jxGTtHW/zDiIzNZ2zZA4HSKcl5n2ppP028bJH61WNibTa22nm/wHVuKG0Qn6BTGILhpCzM45VVTrBjfQI9JEa5Ho5IllBJfDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774366365; c=relaxed/simple; bh=60rNu1J+RQNrNvPl/9wosLxS5LrIvmsraodnghMMEk4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=Y+naXbZ54b9n3rsrkFEO4aVn0ZC/4bHaiTfwUBkHOC7qkqSF6PPS8ZQE6WeJEfaAlFN2YCQYkgj7yuBX3Sc8yheXEN1cNpjx+wOcho+JvoV5geNf16y156lRC/jt8k5pgmBQOqwYDzbzhoH4l2dvu6hPvnG8cdz91bEXSwmCphc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFE1F4BA23E1 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BF3AA5BD30 for ; Tue, 24 Mar 2026 15:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774366364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FFX6xzWVpCTZmYFwN1FSnPm/Ccme1EYQSU38lpW7fz8=; b=JUWKYfRdz5v2eusCKb9VReYi9Yw7SXmJMRK+OwW2KWoJgr7LTmeeJD6qbUCA5NPytM6qn/ r9MREoDnt5EReaGSu6Rx9K0v9vDI1Vwfpq5ZgWUOG4t9ynUAx4bA7b1yQfLeNsuhj8e7jh ZPoqVIbqGDb/a7Se1Xs9dKCCBZM74YI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774366364; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FFX6xzWVpCTZmYFwN1FSnPm/Ccme1EYQSU38lpW7fz8=; b=X6rujRnCiETarxtZPbaAbxoEzLZqKUvoqhbVPLhGCGRweDPg8hkmrIqJXuy7pbD6zTZ7LB HyhykI+TMnU2wLAQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774366362; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FFX6xzWVpCTZmYFwN1FSnPm/Ccme1EYQSU38lpW7fz8=; b=zSRFUATnKpHJly5dQb188u58S2sA+1mi9i6zB8Tl039MtxycfNdhGaRfRSHWvI1YA4Hu9q OfJn62wEGqw9fW6h2kRHgYvJWz8RKEx4pnT2r3JkuuSsuuIK7t5a0IwttRWJ1+jR2FzwU0 qXG58pE8/ZdktSchw4qrrgG2y8doDBE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774366362; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FFX6xzWVpCTZmYFwN1FSnPm/Ccme1EYQSU38lpW7fz8=; b=ymqYB63hGUHYVE4Urliqc2pBrs9job03RRPi0zp0YxUcDh6Fvp7od9TeLlNxy4Sr8xGJKI Lqrgq7+XFlRRKLDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A932E43EEB for ; Tue, 24 Mar 2026 15:32:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id JgTaJ5quwmkiKwAAD6G6ig (envelope-from ) for ; Tue, 24 Mar 2026 15:32:42 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v3] [gdb/remote] Use sevenbit_strings == true in escape_buffer Date: Tue, 24 Mar 2026 16:32:42 +0100 Message-ID: <20260324153242.916826-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[sourceware.org:url,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org With Fedora RH, using Tcl 9.0.2, I run into: ... (gdb) break -q main^M [remote] Sending packet: $qXfer:auxv:read::0,1000#6b^M [remote] Packet received: l!\000\000\000\000\000\000\000\000 ERROR: \ i_read(spawn_id fd=9): invalid or incomplete multibyte or wide character ... UNRESOLVED: gdb.server/bkpt-other-inferior.exp: inf 2: set breakpoint ... For reference, on openSUSE Leap 16.0, with Tcl 8.6.15 the initial part of the problematic string looks like: ... [remote] Packet received: l!\000\000\000\000\000\000\000\000`ü÷ÿ\177\000... ... With Tcl 9.0, something (dejagnu/expect/gdb testsuite infrastructure) has problems with gdb IO containing non-utf-8 chars. Having said that, I don't think having chars like 'ü' in the debug output is particularly helpful. Fix this by forcing sevenbit_strings to true in escape_buffer, getting us instead: ... [remote] Packet received: \ l!\000\000\000\000\000\000\000\000`\374\367\377\177\000... ... Note that this output is ambiguous, because: - one char '\0', and - 4 chars '\\' '0' '0' '0' are printed the same: \000, but I guess that's a pre-existing problem. This also fixes test-case gdb.python/py-send-packet.exp, where we run into a similar problem with the "Sending packet:" line. Tested on x86_64-linux, with Tcl 9.0.2 and 8.6.15. A v1 submitted was submitted here [2]. Changes in v2 [3]: - use c_isprint instead of std::isprint - use string_appendf instead of std::ostringstream Changes in v3: - Rather than re-implementing escape_buffer, change it to use sevenbit_strings == true. - update $subject to indicate new approach Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34012 [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/General-Query-Packets.html#index-qXfer-packet [2] v1 https://sourceware.org/pipermail/gdb-patches/2026-March/226110.html [3] v2 https://sourceware.org/pipermail/gdb-patches/2026-March/226119.html --- gdb/remote.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/remote.c b/gdb/remote.c index e84a0dc578b..3ec56a6d61b 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -10509,14 +10509,20 @@ remote_target::remote_serial_send_break () } /* Return a string representing an escaped version of BUF, of len N. - E.g. \n is converted to \\n, \t to \\t, etc. */ + E.g. '\n' is converted to R"(\012)", '\t' to R"(\011)", etc. */ static std::string escape_buffer (const char *buf, int n) { string_file stb; + /* Temporarily set sevenbit_strings to true to make sure that we print + chars >= 0x80 as octal escape \ooo, independent of the current + sevenbit_strings setting. This conservative choice is appropriate for + debug logs. */ + scoped_restore reset = make_scoped_restore (&sevenbit_strings, true); stb.putstrn (buf, n, '\\'); + return stb.release (); } base-commit: 6fdfbd43bb85e3c5749a08494a5ae4af506dc4fb -- 2.51.0