From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id agzbBP0SwGncXDQAWB0awg (envelope-from ) for ; Sun, 22 Mar 2026 12:04:13 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KXKTGsQh; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3CX5Tage; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KXKTGsQh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3CX5Tage; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 037791E0BC; Sun, 22 Mar 2026 12:04:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A74EC1E08C for ; Sun, 22 Mar 2026 12:04:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 10D774BB3BA2 for ; Sun, 22 Mar 2026 16:04:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 10D774BB3BA2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KXKTGsQh; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3CX5Tage; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KXKTGsQh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3CX5Tage Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 5DD724BB3B84 for ; Sun, 22 Mar 2026 16:03:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5DD724BB3B84 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5DD724BB3B84 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774195420; cv=none; b=Z9dh+PSmIUdOUaLf/xhQsfCTTPeZ8TdbJWv0/EGy84IX5gqusu0cnvzxcbuV4ZI3U+Lzk90GUC0XbMcSvEje2j/XuSigXcfuAwAvQ9FJ2yR+2kLTBC+5en5l6WiSbSrRF5Bwq5QbZETAuj8IVvQGVEvIxcTezZKjgWVwTen+1Dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774195420; c=relaxed/simple; bh=MIHbC9NStOkb6fRttvnvsWAMJZkyzx6hYLI8k3ysur0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=vlmGePLqa3s8jVbIcGpC9kt/XJ9zjfRgHHOnLeK5mr+ud5kLDBjDdtpKpWUAjvSus6g5KeSZLSdJ+zXy/ePk3LSBleutrGuDDh6qIOAYl/Nctp9Llw7LxPjQ/e9xW4wQxsXalHpOrCEYYJ2Qg6o0RSSbVal94xCgPNVqkPdp+3M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DD724BB3B84 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1CE134D2B2 for ; Sun, 22 Mar 2026 16:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774195419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wgVCKwFkkLxUuFk9eFn3pPlP+mXIqkoKqY4L3UYj2WY=; b=KXKTGsQhXZ9UkHN2inBc1nPIwnY7qi6jtpRs2qapduAymhkB3BgkxbJI0qgqNXt8vE4C+R L7okX2CjXHyOb38Kbp6LPHbvFqlDNlN9BwxZMTuq4dt9Mjwkh0NAnf2AOEMzkw3nfDS2sA CJveHOUUuiLX6a7yXYtfVT3dlO6/SF4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774195419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wgVCKwFkkLxUuFk9eFn3pPlP+mXIqkoKqY4L3UYj2WY=; b=3CX5TageaqN1PUgr5wvt+nCRsbu9U+yqmC8q5l29b7JaTXNLziOGBIafEKoJH4knqbRGpH 0UnZN4jSHtZWYuDw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KXKTGsQh; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3CX5Tage DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774195419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wgVCKwFkkLxUuFk9eFn3pPlP+mXIqkoKqY4L3UYj2WY=; b=KXKTGsQhXZ9UkHN2inBc1nPIwnY7qi6jtpRs2qapduAymhkB3BgkxbJI0qgqNXt8vE4C+R L7okX2CjXHyOb38Kbp6LPHbvFqlDNlN9BwxZMTuq4dt9Mjwkh0NAnf2AOEMzkw3nfDS2sA CJveHOUUuiLX6a7yXYtfVT3dlO6/SF4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774195419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wgVCKwFkkLxUuFk9eFn3pPlP+mXIqkoKqY4L3UYj2WY=; b=3CX5TageaqN1PUgr5wvt+nCRsbu9U+yqmC8q5l29b7JaTXNLziOGBIafEKoJH4knqbRGpH 0UnZN4jSHtZWYuDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 061C7433C8 for ; Sun, 22 Mar 2026 16:03:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8EtzO9oSwGn/UAAAD6G6ig (envelope-from ) for ; Sun, 22 Mar 2026 16:03:38 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdbsupport] Poison ctype.h / cctype functions Date: Sun, 22 Mar 2026 17:03:38 +0100 Message-ID: <20260322160338.3224997-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,sourceware.org:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 1CE134D2B2 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org GDB generally uses c_isprint instead of isprint or std::isprint [1]. Poison uses of ctype.h / cctype functions in gdbsupport/poison.h. This excludes isupper, islower and toupper because they're currently used in GDB. Add a fixme to find out whether these exceptions are ok, and if so document why, otherwise fix them. Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34017 [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226117.html --- gdbsupport/poison.h | 52 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gdbsupport/poison.h b/gdbsupport/poison.h index 904646110a5..0963645ee81 100644 --- a/gdbsupport/poison.h +++ b/gdbsupport/poison.h @@ -237,4 +237,56 @@ non-POD data type."); #undef XOBNEWVEC #define XOBNEWVEC(O, T, N) xobnewvec (O, N) +#ifndef IN_PROCESS_AGENT +/* Poison functions like isprint from header filer ctype.h and std::isprint + from header file cctype. */ + +#define POISON_CCTYPE(F) \ + template \ + F \ + { \ + static_assert (false, "Please use gnulib's c-ctype.h"); \ + return 0; \ + } + +/* Poisoning of some functions is disabled: + - isupper, because it's used in ada_decode. + - islower and toupper, because they're used in UNCTRL from readline, + which is used in tui_redisplay_readline and gdb_fnprint. + + FIXME: Find out whether these exceptions are ok, and if so document + why, otherwise fix them. */ + +POISON_CCTYPE (int isalnum (T c)); +POISON_CCTYPE (int std::isalnum (T c)); +POISON_CCTYPE (int isalpha (T c)); +POISON_CCTYPE (int std::isalpha (T c)); +POISON_CCTYPE (int isblank (T c)); +POISON_CCTYPE (int std::isblank (T c)); +POISON_CCTYPE (int iscntrl (T c)); +POISON_CCTYPE (int std::iscntrl (T c)); +POISON_CCTYPE (int isdigit (T c)); +POISON_CCTYPE (int std::isdigit (T c)); +POISON_CCTYPE (int isgraph (T c)); +POISON_CCTYPE (int std::isgraph (T c)); +/* Disabled: int islower (T c)). */ +POISON_CCTYPE (int std::islower (T c)); +POISON_CCTYPE (int isprint (T c)); +POISON_CCTYPE (int std::isprint (T c)); +POISON_CCTYPE (int ispunct (T c)); +POISON_CCTYPE (int std::ispunct (T c)); +POISON_CCTYPE (int isspace (T c)); +POISON_CCTYPE (int std::isspace (T c)); +/* Disabled: int isupper (T c). */ +POISON_CCTYPE (int std::isupper (T c)); +POISON_CCTYPE (int isxdigit (T c)); +POISON_CCTYPE (int std::isxdigit (T c)); +POISON_CCTYPE (int tolower (T c)); +POISON_CCTYPE (int std::tolower (T c)); +/* Disabled: int toupper (T c). */ +POISON_CCTYPE (int std::toupper (T c)); + +#undef POISON_CCTYPE +#endif + #endif /* GDBSUPPORT_POISON_H */ base-commit: efc26507d9998eef6dc0b17480e0d921f40958c1 -- 2.51.0