From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4TykByeTv2m1wDMAWB0awg (envelope-from ) for ; Sun, 22 Mar 2026 02:58:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BtRqJa0a; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DubwA/49; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BtRqJa0a; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DubwA/49; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 16A0B1E0BC; Sun, 22 Mar 2026 02:58:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B47A71E04F for ; Sun, 22 Mar 2026 02:58:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 578694BB3BF2 for ; Sun, 22 Mar 2026 06:58:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 578694BB3BF2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BtRqJa0a; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DubwA/49; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BtRqJa0a; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=DubwA/49 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 66BFE4BAE7D8 for ; Sun, 22 Mar 2026 06:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 66BFE4BAE7D8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 66BFE4BAE7D8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774162690; cv=none; b=eXETfz7DoiWn7Kp+bdZNGIigYXTK+tgp8AfhJ5ruORJOGrMznnYqhdf8CHfy/GOqF+mB8kREycocRZeAlzYgp1hlu04ltZ2FDXuUKoPrG3W4hLpCXYweZ6gl/uVfTkfvUcxsEneuT/kzYmCiegk/kMQusoNbTseUdOUGANjcU4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774162690; c=relaxed/simple; bh=iQSJhMmsRFCJkRerUWqhlcrgXbikl2GFGT75m8h3KtM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=i5MAPhBKQdlK7jriQMEo4vs8vVRMywP1hdjwK6wsUGo+nlgkSj1MpK7l210DJW6lv/hguAcX3/l9mpt2FOXSj2XmPwizyRrz0BVnqkgl65w8AFCRk0mTv+0y+t/OO6q4W6sF8IwCZfzYDYj6xbq8CxRI9Yfr0fOmbCH1aiCF7mk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 66BFE4BAE7D8 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5693E4D34F for ; Sun, 22 Mar 2026 06:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774162689; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ukc9yUHebteOk9AnsoouvXZg4SvwCbMf/02aZ15YBX4=; b=BtRqJa0a6SNqJ3tIiDi2lLqmIi2ap7nT6LbXz04HBajuSmw/ivqLn1wI6XrRMZz+Oeacg9 3Ae519FyJrGXpBjSBerJtyMZKfAhdCWyzTThw398KLt0dvr4GaeTpyz0oRVwepcCbdnqTF BSzjNPG7CS2cq5E0NDP84Tm7f8b4t8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774162689; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ukc9yUHebteOk9AnsoouvXZg4SvwCbMf/02aZ15YBX4=; b=DubwA/49LANLJBLQEqsyhsCJflW4z/6ESjJ36wUCSlMDRdTLNEqvc2lPyC5UcD4oa5CQSO gXkDaiiAUQjv3LBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774162689; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ukc9yUHebteOk9AnsoouvXZg4SvwCbMf/02aZ15YBX4=; b=BtRqJa0a6SNqJ3tIiDi2lLqmIi2ap7nT6LbXz04HBajuSmw/ivqLn1wI6XrRMZz+Oeacg9 3Ae519FyJrGXpBjSBerJtyMZKfAhdCWyzTThw398KLt0dvr4GaeTpyz0oRVwepcCbdnqTF BSzjNPG7CS2cq5E0NDP84Tm7f8b4t8E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774162689; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ukc9yUHebteOk9AnsoouvXZg4SvwCbMf/02aZ15YBX4=; b=DubwA/49LANLJBLQEqsyhsCJflW4z/6ESjJ36wUCSlMDRdTLNEqvc2lPyC5UcD4oa5CQSO gXkDaiiAUQjv3LBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3B0F0431C5 for ; Sun, 22 Mar 2026 06:58:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id O76qDAGTv2mfNwAAD6G6ig (envelope-from ) for ; Sun, 22 Mar 2026 06:58:09 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/tdep] Eliminate ostringstream use from arc_check_tdesc_feature Date: Sun, 22 Mar 2026 07:58:08 +0100 Message-ID: <20260322065808.1127765-1-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCVD_TLS_ALL(0.00)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org We generally avoid C++ streams in GDB sources [1]. Remove an instance of std::ostringstream in arc_check_tdesc_feature. While we're at it, fix an array index bug: ... - reg_names << " or '" << reg.names[0] << "'"; + string_appendf (reg_names, " or '%s'", reg.names[i]); ... Tested on x86_64-linux, using a trigger patch: ... - if (!found && reg.required_p) + if (true || (!found && reg.required_p)) ... and doing "maint selftest" and observing the output: ... Running selftest unpack_field_as_long::ARC600. Error: Cannot find required register(s) 'r0' in feature 'org.gnu.gdb.arc.core'. Error: Cannot find required register(s) 'pc' in feature 'org.gnu.gdb.arc.aux'. ... [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226117.html --- gdb/arc-tdep.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c index ff283014e52..4936a5c8fbb 100644 --- a/gdb/arc-tdep.c +++ b/gdb/arc-tdep.c @@ -44,7 +44,6 @@ /* Standard headers. */ #include -#include /* The frame unwind cache for ARC. */ @@ -2100,16 +2099,16 @@ arc_check_tdesc_feature (struct tdesc_arch_data *tdesc_data, if (!found && reg.required_p) { - std::ostringstream reg_names; + std::string reg_names; for (std::size_t i = 0; i < reg.names.size(); ++i) { if (i == 0) - reg_names << "'" << reg.names[0] << "'"; + string_appendf (reg_names, "'%s'", reg.names[0]); else - reg_names << " or '" << reg.names[0] << "'"; + string_appendf (reg_names, " or '%s'", reg.names[i]); } arc_print (_("Error: Cannot find required register(s) %s " - "in feature '%s'.\n"), reg_names.str ().c_str (), + "in feature '%s'.\n"), reg_names.c_str (), feature->name.c_str ()); return false; } base-commit: d1cb5bd656a253cd69dbcd096f21f658cda697c7 -- 2.51.0