Re: [PATCH 5/8] gdb: Update Haiku support for 17.x

Tom Tromey
2026-03-12T17:59:29Z

>>>>> "Jérôme" == Jérôme Duval <jerome.duval@gmail.com> writes:

I chose this one to make a note on (see below), but also I wanted to
make a more general request --

In gdb we strive to have commits be bisectable. So while I think what
you did here -- having separate patches to upgrade to different baseline
gdb versions -- makes a great deal of sense when working out-of-tree,
for landing in gdb it would be better to squash these commits into the
appropriate spot in the series. Like I guess keeping the gdb/gdbserver
commits separate makes sense (at least from a gdb perspective, I didn't
really closely examine the patches).

Hope that makes sense.

Jérôme> + /*else
Jérôme> {
Jérôme> - solib_target_so_ops.relocate_section_addresses (so, sec);
Jérôme> - }
Jérôme> + solib_target_so_ops::relocate_section_addresses (so, sec);
Jérôme> + }*/
Jérôme> }

Also in gdb we generally don't land commented-out code. There is some
in the tree already (basically every rule is violated somewhere in the
tree) but we try not to add new instances.

So these should just be dropped from the patches, or resurrected if
that's more appropriate.

thanks,
Tom